[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v1 06/12] xen-hvm: move common functions to hw/xen/xen-hvm-common.c
- To: Paul Durrant <xadimgnik@xxxxxxxxx>, "qemu-devel@xxxxxxxxxx" <qemu-devel@xxxxxxxxxx>
- From: "Garhwal, Vikram" <vikram.garhwal@xxxxxxx>
- Date: Wed, 19 Oct 2022 23:12:30 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cge5Yb2CzSD5Bu0WVHIFKjdDadxJS6eZRxLuDht1xKU=; b=iJqACC5pZUEgL3+sngHYNKvoUL5B0OZqbQdMiggKbWyq045yKZJ7kYYO1GUvjVFFhbY+58z1HzyzMD5q/M2wBkhVJZaMEud8m0SXXxf5dKBbAgVc/ZnMS4uv4AQvBQPBpF72zwrxgjnmy4D4j25AfyJyvIFF/54NsiI+WbVi7HocJe7pKDpv35pLZs1/ApLitpuVQ3q3u0XFTIHrATziyAmRkGTq29ktHMbSumXA29uIy+xARiAVOXnMrRNwQuPsWQbuVY6P3ETzxlYHsrUoGjKDIKDScg59dJhb0xAdb3Q5VDEdoz+0xZyg6A1OK6fQeR30cBLrkFjKXNLohGetmQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LBxDirxmDG4gKiq0WWvE3/4tM7PDw7emonIHCjGHPwXy7uIvq4nTd2bmMhKHxAndiBwO6QXGLrRcmEPDYyFj13AWT/A5kLOoMglmx+iyF0pwwljbN4B4nJ2YpqgJrn9pKh6F85+G9XECZgDkxB+K+fA36t7RGsi1MKzDS4Hspw10krQUNNTE1pY0PC5P0k+talFI+TzuD68KTEPtC3xIWVMaleduM2QChEVHAE4o45xMES76tR21EEHhyXa7ouzaitxEPQq4wV+MCzLVesbccUSX4BSHpn02OCdko9a1uJZDZL3j1KulIPjwmlZjJWLNS1WlbfDMeQAGX5ErVm/Tng==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com;
- Cc: "Stabellini, Stefano" <stefano.stabellini@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Anthony Perard <anthony.perard@xxxxxxxxxx>, "Michael S. Tsirkin" <mst@xxxxxxxxxx>, Marcel Apfelbaum <marcel.apfelbaum@xxxxxxxxx>, Paolo Bonzini <pbonzini@xxxxxxxxxx>, Richard Henderson <richard.henderson@xxxxxxxxxx>, Eduardo Habkost <eduardo@xxxxxxxxxxx>, "open list:X86 Xen CPUs" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Wed, 19 Oct 2022 23:12:43 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHY4FQ0tVypMawM1ke4uV2W+2m2Q64V66+AgAB0FBU=
- Thread-topic: [PATCH v1 06/12] xen-hvm: move common functions to hw/xen/xen-hvm-common.c
Thanks Paul & Julien for reviewing. I will update this in v2.
Regards,
Vikram
From: Paul Durrant <xadimgnik@xxxxxxxxx>
Date: Wednesday, October 19, 2022 at 9:16 AM
To: Garhwal, Vikram <vikram.garhwal@xxxxxxx>, qemu-devel@xxxxxxxxxx <qemu-devel@xxxxxxxxxx>
Cc: Stabellini, Stefano <stefano.stabellini@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Anthony Perard <anthony.perard@xxxxxxxxxx>, Michael S. Tsirkin <mst@xxxxxxxxxx>, Marcel Apfelbaum <marcel.apfelbaum@xxxxxxxxx>, Paolo Bonzini <pbonzini@xxxxxxxxxx>,
Richard Henderson <richard.henderson@xxxxxxxxxx>, Eduardo Habkost <eduardo@xxxxxxxxxxx>, open list:X86 Xen CPUs <xen-devel@xxxxxxxxxxxxxxxxxxxx>
Subject: Re: [PATCH v1 06/12] xen-hvm: move common functions to hw/xen/xen-hvm-common.c
On 15/10/2022 06:07, Vikram Garhwal wrote:
[snip]
> + qemu_add_vm_change_state_handler(xen_hvm_change_state_handler, state);
> +
> + state->memory_listener = xen_memory_listener;
> + memory_listener_register(&state->memory_listener, &address_space_memory);
> +
> + state->io_listener = xen_io_listener;
> + memory_listener_register(&state->io_listener, &address_space_io);
> +
> + state->device_listener = xen_device_listener;
> + QLIST_INIT(&state->dev_list);
> + device_listener_register(&state->device_listener);
> +
As Julien said, these do not belong here. These are the (current and
legacy) PV backend setup functions; they most certainly have nothing to
do with device emulation.
Paul
|
|
