Re: [PATCH v11 17/17] net: stream: add QAPI events to report connection state

[Laurent Vivier <lvivier@xxxxxxxxxx>]

On 10/20/22 12:22, Markus Armbruster wrote:
> Sorry for the slow replay, too many distractions...
>
> Laurent Vivier <lvivier@xxxxxxxxxx> writes:
>
> > On 10/17/22 15:23, Markus Armbruster wrote:
> > > Laurent Vivier <lvivier@xxxxxxxxxx> writes:
> > >
> > > > The netdev reports NETDEV_STREAM_CONNECTED event when the backend
> > > > is connected, and NETDEV_STREAM_EOC when it is disconnected.
> > > >
> > > > The NETDEV_STREAM_CONNECTED event includes the URI of the destination
> > > > address.
> > > >
> > > > Signed-off-by: Laurent Vivier <lvivier@xxxxxxxxxx>
> > > > Acked-by: Michael S. Tsirkin <mst@xxxxxxxxxx>
> [...]
>
> > > > diff --git a/qapi/net.json b/qapi/net.json
> > > > index 6a1a49749294..69f83bceff3f 100644
> > > > --- a/qapi/net.json
> > > > +++ b/qapi/net.json
> > > > @@ -895,3 +895,49 @@
> > > >    ##
> > > >    { 'event': 'FAILOVER_NEGOTIATED',
> > > >      'data': {'device-id': 'str'} }
> > > > +
> > > > +##
> > > > +# @NETDEV_STREAM_CONNECTED:
> > > > +#
> > > > +# Emitted when the netdev stream backend is connected
> > > > +#
> > > > +# @netdev-id: QEMU netdev id that is connected
> > > > +# @uri: The Uniform Resource Identifier identifying the destination address
> > > Is an URI the appropriate representation here?  It's not how we specify
> > > such addresses elsewhere in QAPI/QMP...
> > I put in the event the same information we have in info_str and displayed by 
> > the HMP command 'info network'. What would be a more appropriate reprensation?
> SocketAddress?
I agree SocketAddress looks better.

Thanks,
Laurent