[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH v2] xen/arm: mark handle_linux_pci_domain() __init
- To: Julien Grall <julien@xxxxxxx>, Stewart Hildebrand <stewart.hildebrand@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Henry Wang <Henry.Wang@xxxxxxx>
- Date: Fri, 21 Oct 2022 01:43:01 +0000
- Accept-language: zh-CN, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=I/1lRJQoi940BYFAJ88BXjIaVMViStIp0n5oPY7StpI=; b=GOzb27BZKFAieD2XCX6wcGmJTS08PLkS2zDbM9vme0oB7y/xHEDQeBZ3D14n/pXru+oLeRMTOi9t2haAOuqHVUhFNFxZXmZeyYnMoSIZM6/7412GjTwfbQnZfUGBNGM4/z5IAV4reDHOX7PgdYyvFTbzzfZl3OWJgPixIk1F5V0unm4FCFz7ekiopgAkpSoMkJ16yHB+fyIXJN/k8Vc9AqQ/NSxkmAoDDxmMi3UPz0ofW8hGGjD9WEp8GB1KD1YRO6RqITExHG449+IkMfPCCcwOcGUrako9EcinYmS2Hv/ybXbUKrFBRxi4NFOm+WQ0RLNRrPlb63QBXoWqRuQpcA==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=I/1lRJQoi940BYFAJ88BXjIaVMViStIp0n5oPY7StpI=; b=RUIRhXvXf4A8QGBltC4CBSIIvBpWRpI11krOSpyopEj6UTXMAVvXSQ4Zjf92yO/ruXB436l2w1MxvUNHS5xLev8dNVDEBEhVnOlErOw2b+HNhg9qGOnh3LInt/ZkFbjDleUVlr0I3WDi6/IFQ3sCd6ETs/b0T5c/dGGA5WCR4it24OOzadQ+C5DQYxDBiopQimZ1mkszA+U70OJPV9Y+E808qsrxiPwLs9blKysEJHxXza+W5j0LqWYKXViaqcfFA/l63s0ir93CLFfDwCMaVZTStfFrkS/TC4ND41WDq7hfYH6S7CA1nUphpeSyfG5lz5FVWSHHvG1uoBi57VKwyw==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=OIfMpaPX3cL0sVFmND/d3o3EBA8rW0pGbNSALAzRfnhl/MICcJW3CpuK7OrSyUTLEDKtOP6j3ju/cX5NZC3919+mp7+Dd/JUrykTtuHeHHBzaTFcW4HZnsltfU4JiPuYu20eospltMGo5LwPciMOSV+zB45tl+hiOsqkyUhBj0u54/3VFO33HC9p5Y3lM5hzqwpbHhSyrJli0IS2Fh+XXmG7ePcrzMSzOa3tZAqE7aflpCTQMvsBufc3wktqG87phgOkmsZoETD8o2bCTxIZjuGQKExa9pVpu8M9t8V/6X+ZfNiYHgXONPC+mxLIZ1eycI/inzLI8OcsYf6rKihGCg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XZ45DSLL6o9U8EP3/QZezEDo5KpsGI0wQjaO3OrI9loo1jpUrgggQ8KVwvkD8XjBkCzSHAlO9b0dD124ZG0xctvT56OiD+hmPMFHX+oW38SmJkK/ldY1Qo106UyXEt7Zuk7t73d473zChXKx/6pvM4iK/pLmad1Yrv8e6m3wQztEsZa++y6UoCPOyy9c+FEcjFSfiBd3EMID0toSSfxipizBmclMLKdX7ARB641jD2WPh+8cfK2nnZ96dfX7OQv8W798yABwIjlLkqP/Zq2tzkcVFZkwVlt+ZBH8gIcAzwW24akPB0GZFCfACXHoqhSQlT9TQvkgyj3yRS/45WKs+A==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Fri, 21 Oct 2022 01:43:19 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHY4AkLAZG1W03ugkqkeLVQdjVQ9K4XoOsAgAB7wRA=
- Thread-topic: [PATCH v2] xen/arm: mark handle_linux_pci_domain() __init
Hi Julien,
> -----Original Message-----
> From: Julien Grall <julien@xxxxxxx>
> Subject: Re: [PATCH v2] xen/arm: mark handle_linux_pci_domain() __init
>
> Hi Stewart,
>
> I nearly missed this one because it was threaded under v1. In the
> future, would you be able to send new version in a separate thread? This
> makes easier to track it.
>
> On 14/10/2022 21:09, Stewart Hildebrand wrote:
> > All functions in domain_build.c should be marked __init. This was
> > spotted when building the hypervisor with -Og.
> >
> > Fixes: 1050a7b91c xen/arm: add pci-domain for disabled devices
> > Signed-off-by: Stewart Hildebrand <stewart.hildebrand@xxxxxxx>
>
> Acked-by: Julien Grall <jgrall@xxxxxxxxxx>
>
> Henry, this patch is fixing a potential build failure on some compiler
> (at the moment we are relying on the compiler to inline
> handle_linux_pci_domain). AFAIU, the problem was introduced in Xen 4.17.
> Would you be happy if we include it in the release?
Of course. Thanks for the ping :)
Release-acked-by: Henry Wang <Henry.Wang@xxxxxxx>
Kind regards,
Henry
>
> Cheers,
>
> >
> > ---
> > v1 -> v2:
> > Add Fixes: tag
> > Add patch description
> > ---
> > xen/arch/arm/domain_build.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
> > index 61cda8e843..fc2961895b 100644
> > --- a/xen/arch/arm/domain_build.c
> > +++ b/xen/arch/arm/domain_build.c
> > @@ -1051,8 +1051,8 @@ static void __init assign_static_memory_11(struct
> domain *d,
> > * The current heuristic assumes that a device is a host bridge
> > * if the type is "pci" and then parent type is not "pci".
> > */
> > -static int handle_linux_pci_domain(struct kernel_info *kinfo,
> > - const struct dt_device_node *node)
> > +static int __init handle_linux_pci_domain(struct kernel_info *kinfo,
> > + const struct dt_device_node
> > *node)
> > {
> > uint16_t segment;
> > int res;
>
> --
> Julien Grall
|
