[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH v2 4/4] vpci: include xen/vmap.h to fix build on ARM
- To: Oleksandr <olekstysh@xxxxxxxxx>
- From: Henry Wang <Henry.Wang@xxxxxxx>
- Date: Fri, 21 Oct 2022 14:40:19 +0000
- Accept-language: zh-CN, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4DhfaRwzrj7R7Idn7agp7jd2sNNMTdVmTJhcXH2ttPE=; b=CbcNj9c8ArRo7gVXzg4U0v8xQ3qijF9VK61RH+ZgOn80XUGccj6clM8DX9zVhqN5yFMF2jqkYeUSH0CErFXQyyh/mhgn7E6gAkzi5QRlr2hy79w7QlHgbOz6gm/fKq/gciONX2cZMThxuAVG3//fqFhkBRyPhfFsLLldW5QwPPOzRRQ3sbJX0uj5a9ALUP/FwDkaC5SyO6CD6tjCLrGo0sXCSh1r+B823x/IkFyo+NHJxAjakXJdjBGmy8SfbyZtKw67du5tmpVt7rUoJlaYnR8j6XqnO8YYB2uyuX4pbG4d2V7awxLGTRbGnq7nOZ4I+/jx00HQMosv4kNT41HOxg==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4DhfaRwzrj7R7Idn7agp7jd2sNNMTdVmTJhcXH2ttPE=; b=Dg4+TJUl9/nWFgAqStYmpRVcMC4hwii/kQSZGLH008hx03jmKDjftnta+REuEUtJ48KSgGtaCv+1sdr2uQiCMcPSWQupOmiQWT69UY7NJWtQTIiQ+rDHVkzu/L6P5ff7kMEE2T66eAHFSv02O6Sg7Qp/X5/nESq8vlIyqSif9eeURUE0QvIUeXVfVrPoWOeyabD7LMfJ+jQahPf0GiYobkQbpas435QJDwmOvGH8HsbL6jVtakF8Yo+nprT9sMD3OZ6HDtdvVlzITagzQ+m0wAAaPhz/d8u61TiYa2OV94UiG5sMykXAUf0BEmz4hMd+ieMT+YEoYysKX6HHSFfbAA==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=f/NbYJsJ2COhpMjsdce9OdOr8mhBFN/+YhKFkYRSJDUbxuGgT+0vjOO461i6I7/mythHre8DVPXb4VntQr4mfxybXJLsIDsDR2BFQpqWWre7rVMWhowriITLjkniGh7uGDlA4B/6Bs8VDT5NFDZclGrQjmWyleGoV7idoSIlSklhcVgPv63bZLTxH3BMlzhKFKW1cQfN9301JwDKsecq+KdWzf+64XIhWqfA/ZZX8OOi6tB4uKF/uwlO1MsPgAJq9j4dBMeDavCONOglmy8s2l1Uv+glKbSP5M3THsnh8QN1x5KxCJ6gaU5O8LympH+U0nUiCEc9OerFJBqk1zWrEg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Kh84EcLqflwr+t9203NG7zwCpfVrDUGfmX45RTxj0CGee/FOCevGYX4sI2jDmzAotwDtYiKIoVBnd0qA4fuoMeFDJvH/tyYDqyLhUlBo2GodwxitXmrjtlwsK0/MPg3jAQqSOAQY8kQQaLTT8HxiVBga/nQZeKnOVUXcwRkUY9O2tNx8aNQEq63vEIi2i5n5wVltEGAqg1w/lCnk79PET681ogTLDCFEm9bTwL40CbDYiS2RhFAFWjFU3nuo+8rwUkUvmpx5BTbxp6jlPBgoDD8vZm8GjEBPJpoWa54xBGtWYoKG89g8EHpaYe/UNtpEVcMoeBT4S0AsgLDYsixQqA==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, "sstabellini@xxxxxxxxxx" <sstabellini@xxxxxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
- Delivery-date: Fri, 21 Oct 2022 14:40:45 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHYmuuJ09LC1x/2uEWs942YY/fNVK2FNeCAgABJdQCAAALGgICT+/QAgAAA3ZA=
- Thread-topic: [PATCH v2 4/4] vpci: include xen/vmap.h to fix build on ARM
(+ Arm maintainers)
Hi Oleksandr,
> -----Original Message-----
> From: Oleksandr <olekstysh@xxxxxxxxx>
> Subject: Re: [PATCH v2 4/4] vpci: include xen/vmap.h to fix build on ARM
> Hello all.
> On 19.07.22 13:40, Jan Beulich wrote:
> > On 19.07.2022 12:32, Volodymyr Babchuk wrote:
> >> Jan Beulich <jbeulich@xxxxxxxx> writes:
> >>
> >>> On 18.07.2022 23:15, Volodymyr Babchuk wrote:
> >>>> Patch b4f211606011 ("vpci/msix: fix PBA accesses") introduced call to
> >>>> iounmap(), but not added corresponding include.
> >>>>
> >>>> Fixes: b4f211606011 ("vpci/msix: fix PBA accesses")
> >>> I don't think there's any active issue with the "missing" include:
> >>> That's only a problem once Arm has vPCI code enabled? In which
> >>> case I don't think a Fixes: tag is warranted.
> >> Fair enough. May I ask committer to drop this tag?
> > I had taken respective note already, in case I end up committing this.
> > But this is the last patch of the series, so I can only guess whether
> > it might be okay to go in ahead of the other three patches.
> >
> > Jan
>
>
> I am wondering, where this patch could be 4.17 material?
>
> The patch series seem to get stuck, but the current patch just adds a
> missing include to fix a build on Arm, so it is completely independent.
> I agree, there is no issue with the current code base as vPCI is
> disabled on Arm, so nothing to fix right now. But as PCI
> passthrough/vPCI on Arm is in the development stage, the developers
> enable that support in their builds. I think the risk is rather low than
> high.
It seems reasonable to me, but I am curious about what Arm maintainers
and PCI maintainers think. From the history discussion in this thread I
think it is pretty safe to include this in 4.17. Thanks for the ping.
Kind regards,
Henry
>
>
>
> --
> Regards,
>
> Oleksandr Tyshchenko
|
