[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [for-4.17] automation: Do not use null scheduler for boot cpupools test


  • To: Michal Orzel <michal.orzel@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>
  • Date: Fri, 21 Oct 2022 17:21:09 +0000
  • Accept-language: en-GB, en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jjfyHLihhuhnu/YJf6pwiYxfMAD85K4XcXo40A5JsQ8=; b=S+swa9xcN/P2hPNFNrg41j0ogfm3jdL+D28OtNYRiK0wLbjQOFY5nUgAlMldQLJi2rcKrQOMqu/4Wn5les+CUYvx4/hKKMTY9twRtdvy0sl11wlZPNAPJNwBNIant5szNpIcPe+xBjr6v2LSYhkrfE8aeyU3gtC8dlpaCud45depq7D6JYK4yhPHJ0ZWuQ4SWfAbzyugnKWtcH++FzyoUxFOe6/H1fBUTv9/eItk4ciUuvasE/kMDs9l5Lwnh0XcbOXNpTNLyvP2joS+3s0MhhjU80wumU3HUEUFfqwSLaWZfgwajzA8cf1JkWWuQq+178YkmgRKVuH8EPKijeAztA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jP09fAKJwSSl2rdD0bgqt9s3vTzLe9q/ODTPOGDr1XfDvuoSYMgZ4VWM20WT4P7oONiRw/+aIE4wOteRWVzVIFX++rSJ1OfmHCdH3gHUXx4HAomt0lZoOhLAh5PbJhjiNzIwg/UYnf/Cmo8/QxZbvwaVlKX/FZnhF8llKf6tg5C2HZtXfT8N7UG6ExNEdPviDCsJgSX+1fJ69efZFzEkShLkiOcq9zNE41CEewztEe1L9dOh5O2koQCLlqWEMjcSRnN8wMENpC/Kh2AoUBbR1IgbsrARLJf2rjYL7gAFCzja6152ombrj60qaXf2sGb2Hd7efu5yD6nkIsVG8/3deA==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
  • Cc: Doug Goldstein <cardoe@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Henry Wang <Henry.Wang@xxxxxxx>
  • Delivery-date: Fri, 21 Oct 2022 17:21:22 +0000
  • Ironport-data: A9a23:z4gSM6OVlx7MsrfvrR15lsFynXyQoLVcMsEvi/4bfWQNrUp01jFRx 2IXXWDUOanZM2H8fot+Ooqw9hlU7MWGz9NhGgto+SlhQUwRpJueD7x1DKtS0wC6dZSfER09v 63yTvGacajYm1eF/k/F3oDJ9CU6j+fQLlbFILasEjhrQgN5QzsWhxtmmuoo6qZlmtH8CA6W0 T/Ii5S31GSNhnglbwr414rZ8Ek15ayo4WtC1rADTasjUGH2xiF94K03fcldH1OgKqFIE+izQ fr0zb3R1gs1KD90V7tJOp6iGqE7aua60Tqm0xK6aID76vR2nQQg075TCRYpQRw/ZwNlPTxG4 I4lWZSYEW/FN0BX8QgXe0Ew/ypWZcWq9FJbSJQWXAP6I0DuKhPRL/tS4E4eYqtJx+0rIj1y+ McZdB1XSTCMicCX6efuIgVsrpxLwMjDGqo64isl9heASPEsTNbEXrnA4sJe0HEonMdSEP3CZ s0fLz1ycBDHZB4JMVASYH48tL7w2j+jLHsF9xTJ/8Lb4ECKpOB1+JHrPMDYZZqhQsJNk1zDj mnH4374ElcRM9n3JT+toiny1r6XwnmTtIQ6E7q/z/pD3gSqn3EoGUdKf0OU+Ou+oxvrMz5YA wlOksY0loA39UerR927WAeqrXqstxsQHdFXFoUS+AyLj6bZ/QudLmwFVSJaLswrstcsQj4n3 UPPmMnmbRRkuaeZTn+1/b6OoTS/fyMSKAcqfjQYRAEI593ipoAbjR/VSNtnVqmvgbXdOTz22 SHMkyE4iJ0al8tN3KK+lW0rmBqpr5nNCxUzvwzRV2f9tAdhPtb5Pcqv9ETR6utGIMCBVF6ds XMYms+YqucTEZWKky/LS+IIdF2028u43PTnqQYHN/EcG/6FoRZPoag4DOlCGXpU
  • Ironport-hdrordr: A9a23:EON/w6y53H0jiXQAKWjYKrPxj+skLtp133Aq2lEZdPULSKGlfp GV9sjziyWetN9IYgBapTiBUJPwIk81bfZOkMQs1MSZLXPbUQyTXc1fBOrZsnfd8kjFmtK1up 0QFJSWZOeQMbE+t7eD3ODaKadu/DDkytHPuQ629R4EIm9XguNbnn5E422gYy9LrXx9dP4E/e 2nl696TlSbGUg/X4CePD0oTuLDr9rEmNbNehgdHSMq7wGIkHeB9KP6OwLw5GZebxp/hZMZtU TVmQ3w4auu99uhzAXH6mPV55NK3PP819p4AtCWgMR9EESttu/oXvUjZ1SxhkFxnAid0idvrD AKmWZmAy1H0QKSQohym2qq5+Cv6kd215ao8y7kvZKqm72EeNt9MbsOuWsRSGqm16Jr1usMr5 5jziaXsYFaAgjHmzm479/UVwtynk7xunY6l/UP5kYvGLf2RYUh2rD3xnklZqsoDWb/8sQqAe NuBMbT6LJfdk6bdWnQui1qzMa3Vno+Ex+aSgxa0/blmAR+jTR81Q8V1cYflnAP+NY0TIRF/f 3NNuBtmKtVRsEbYKphDKMKQNexCGbKXRXQWVjiaWjPBeUCITbAupT36LI66KWjf4EJ1oI7nN DbXFZRpQcJCjbT4A21reh2Gzz2MRaAtG7Wu7BjDrBCy83BbauuNzGfQ1YzlMblq+kDA6TgKo SOBK4=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Thread-index: AQHY5W3J3NgQRSiY5kiY+kL0DoKe0q4ZGCaA
  • Thread-topic: [for-4.17] automation: Do not use null scheduler for boot cpupools test

On 21/10/2022 17:53, Michal Orzel wrote:
> Null scheduler is not enabled on non-debug Xen builds so the current
> test can lead to a failure on such jobs. We still want to test that we
> can assign the cpupool to a domU with a different scheduler than default
> one (credit2). Switch to credit as it is enabled by default.
>
> Fixes: 36e3f4158778 ("automation: Add a new job for testing boot time 
> cpupools on arm64")
> Signed-off-by: Michal Orzel <michal.orzel@xxxxxxx>

/sigh - I'm sure I nacked that stupidity to begin with.  apparently not...

It is totally bogus for CONFIG_DEBUG to influence logical chunks of
functionality like this.  The CI script is good in its current form.

RTDS and ARINC should be default n.

NULL is more tricky.  PV_SHIM is explicitly security supported, and has
been for years, so the "UNSUPPORTED" is bogus, whatever the default is.

As NULL is explicitly tested in CI, it's clearly supported, and probably
ought to be on default.


Please instead fix Kconfig to not be broken.  That will be a far better
fix overall for people.

As a more general note, tests which are using non-default pieces of
logic ought to activate them explicitly.

~Andrew

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.