[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH for-4.17?] test/vpci: enable by default
- To: Roger Pau Monne <roger.pau@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>
- Date: Fri, 21 Oct 2022 19:01:01 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qilwvmJ6SzWIy26zLCXFDIh2qV9fRmIr13OxR7GzFEQ=; b=jnO8bVMD2Jiwx2dJC6Az24E68QixEDquAan8STcXtgLFlDYGVVLRuNXdrGrMyUwV+KfcDfUyTBSOH45uFyuRg3S9yN5K5DRj7IDUnCEPXDatNjBshb3IQELjJwPxPUlPvvOcbmnMF0Nr2GR6hNzhDbkb3gdzLk13+xJ8BMx2cp+L0G0nrHCRwjZ22wJzUdGKDQXe+K5ztGVG6iX+rnbdJa+GQ5hTn+eXuK0w7a0iemuINX0vP/WV6UnVhXCKB+74i0+u51qzivk60OUWdBzhsSNNv3rbdnB25JRO3BdCuZ/mBtH6gMiTk33bbLUc5Sf81AExVv/nEphA4+7pq64zpA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TGwVpFqf8rhf6hfQn26uzzkg7SepbxpaQKLLu+OauCOqvAAKFEmpjBFqQgtfSokbkU3CXmdhxaIMxFWvTVgZJDoUluft6SE6oJMdMUECwpTGi1PdZBGisN98xrGH3CaXrDcMIqaMRRBgpynZeMgDcO9YHO3XLo4l3+R8IJ2nKxQr/jc9R+vmhW6Sy6pYfr2gkTCxYmfV5X6xua6yNODyDucqYEsLYigh3vzPxRyT4uYzoz858Thv5WZ+Y11dXTvJlZyH3lGcdPKgHjXPzhJlmQ3o83N1QN8yKNiVpOgWNh/7qhRQRDmTsp+zDHjkpTes1gQ+AHM/tmc19nhvwU6hSg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: "Henry.Wang@xxxxxxx" <Henry.Wang@xxxxxxx>, Wei Liu <wl@xxxxxxx>, Anthony Perard <anthony.perard@xxxxxxxxxx>
- Delivery-date: Fri, 21 Oct 2022 19:01:41 +0000
- Ironport-data: A9a23:XTUnk6jyB+8mwklYWfOfF5nWX161QBEKZh0ujC45NGQN5FlHY01je htvW26FOf6KY2bwLtF/Pdvl8BkBu5WEmIJrTANtri41QyMb9cadCdqndUqhZCn6wu8v7q5Ex 55HNoSfdpBcolv0/ErF3m3J9CEkvU2wbuOgTrSCYkidfCc8IA85kxVvhuUltYBhhNm9Emult Mj75sbSIzdJ4RYtWo4vw//F+U4HUMja4mtC5AVmP6kT5jcyqlFOZH4hDfDpR5fHatE88t6SH 47r0Ly/92XFyBYhYvvNfmHTKxBirhb6ZGBiu1IOM0SQqkEqSh8ai87XAME0e0ZP4whlqvgqo Dl7WT5cfi9yVkHEsLx1vxC1iEiSN4UekFPMCSDXXcB+UyQq2pYjqhljJBheAGEWxgp4KWVO7 +MCC2ogVx2Ou+7qzLv8E+JQ19t2eaEHPKtH0p1h5RfwKK56BLX8GeDN79Ie2yosjMdTG/qYf 9AedTdkcBXHZVtIJ0sTD5U92uyvgxETcRUB8A7T+fVxvDOVlVIhuFTuGIO9ltiibMNZhEuH4 EnB+Hz0GEoyP92D0zuVtHmrg4cjmAurAtlNS+fiqJaGhnWrn3BMMw9KbmK24uu90EvgfvFvC hAtr39GQa8asRbDosPGdw21pjuIswARX/JUEvYm80edx6zM+QGbC2MYCDlbZ7QOlMIwXy1s6 VaPkPvgHzkpu7qQIVqC8p+EoDX0PjIaRVLufgcBRAoBptz8+oc6i0qTSs45SfDlyNroBTv33 jaG6jAkgKkehtIK0KP9+k3bhzWrpd7CSQtdChjrY19JJzhRPOaND7FEI3CAs56s8K7xooG9g UU5
- Ironport-hdrordr: A9a23:q0yrjK0HxvsmegWU1QfPKwqjBRFyeYIsimQD101hICG9Lfb0qy n+pp4mPEHP4wr5AEtQ4uxpOMG7MBDhHQYc2/hdAV7QZnidhILOFvAv0WKC+UyrJ8SazIJgPM hbAs9D4bHLbGSSyPyKmDVQcOxQj+VvkprY49s2pk0FJW4FV0gj1XYBNu/xKDwVeOAyP+tcKH Pq3Lsjm9PPQxQqR/X+IkNAc/nIptXNmp6jSwUBHQQb5A6Hii7twKLmEjCDty1uEg9n8PMHyy zoggb57qKsv7WQ0RnHzVLe6JxQhZ/I1sZDPsqRkcIYQw+cyjpAJb4RGIFqjgpF5d1H22xa1O UkZC1QePib3kmhPF1dZyGdnTUIngxeskMKgmXo/EcL6faJOA7STfAxy76xOyGplXbJ9rtHod 129nPcuJxNARzamiPho9DOShFxj0Kx5WEviOgJkhVkIMIjgZJq3PsiFXluYeE9NTO/7JpiHP hlDcna6voTeVSGb2rBtm0qxNC3RHw8EhqPX0BH46WuonNrtWE8y1FdyN0Un38G+p54Q55Y5/ 7cOqAtkL1VVMcZYa90Ge9ES8qqDW7GRw7KLQupUBzaPbBCP2iIp4/84b0z6u3vcJsUzIEqkJ CES19cvX5aQTObNSRP5uw/zvngehTPYd228LAu23FQgMyNeJP7dSueVVspj8ys5/0CH8yzYY fABK5r
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHY5G6FfAZD2+fTa0a3sP1MAXO4Za4ZNg6A
- Thread-topic: [PATCH for-4.17?] test/vpci: enable by default
On 20/10/2022 11:27, Roger Pau Monne wrote:
> CONFIG_HAS_PCI is not defined for the tools build, and as a result the
> vpci harness would never get build. Fix this by building it
> unconditionally, there's nothing arch specific in it.
>
> Reported-by: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>
> Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
> ---
> While not strictly a bugfix, I think it's worth adding this change to the
> release in order to always build the vpci test hardness and prevent it
> from bitrotting.
> ---
> tools/tests/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/tests/Makefile b/tools/tests/Makefile
> index 33e32730c4..d99146d56a 100644
> --- a/tools/tests/Makefile
> +++ b/tools/tests/Makefile
> @@ -10,7 +10,7 @@ SUBDIRS-$(CONFIG_X86) += x86_emulator
> endif
> SUBDIRS-y += xenstore
> SUBDIRS-y += depriv
> -SUBDIRS-$(CONFIG_HAS_PCI) += vpci
> +SUBDIRS-y += vpci
I'm afraid this is only half the fix. The other half is:
diff --git a/tools/tests/vpci/Makefile b/tools/tests/vpci/Makefile
index 5075bc2be28c..336904958f6a 100644
--- a/tools/tests/vpci/Makefile
+++ b/tools/tests/vpci/Makefile
@@ -22,6 +22,8 @@ distclean: clean
.PHONY: install
install:
+ $(INSTALL_DIR) $(DESTDIR)$(LIBEXEC_BIN)
+ $(INSTALL_PROG) $(TARGET) $(DESTDIR)$(LIBEXEC_BIN)
vpci.c: $(XEN_ROOT)/xen/drivers/vpci/vpci.c
# Remove includes and add the test harness header
so it can actually get deployed somewhere useful.
~Andrew
|
