[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC v2 01/12] xen/arm: Clean-up the memory layout
- To: Julien Grall <julien@xxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Michal Orzel <michal.orzel@xxxxxxx>
- Date: Tue, 25 Oct 2022 11:21:18 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=xen.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kc1OdzbUVoH/An6BsueD6Yy51rtby1vUctz6mo7jnHc=; b=lwnQSkpOXnkrHH8i9il3GA48s74Utuw+x7t4QH5E62dYWXm3kJA2Ldic2NpIyOSfsa6MIyJgqlIHTmq+okO4woS4H2abBZmnAqrmBwgVyKYuyC2Tkf28mQ6Q+As4PoffBfI3MLUpaDpSVhUYd9JI+D2OVIUjVk8JwAxMhhmOfFVNGh7PHgev2fbkSqNB2my9D5vYBejt6sAWZHeMJp5KjV02NjFw35n2qtjJ+BMlYuiv9BtD7YsMTjrjjDGV4ubMVNwlieE3WiHHorPvCExkd4IlybbKDfL3uMetErkvPeZrwZZn7aHieVgAjULyAjotbB2rHhfI/h7/drfMNmgvNQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hS2Rx1p9bW7TQVJR0HiG97FpJxhQKsInhm3Zdqe/rHU994OcD2a5R80Clo+AdxZX2Mh8lCgyNL23ZJxuRo/w9R/TWPAvhxX486JIMXb2pnHOMlAOYaKLaTPN7EGKMEuM4TZWqsgcY0pCrylP0sv1iul66hgPOtJdWJWdiS2NBjkMU7JwA40foQrQEPd6rFVdzS4XOPJ7KzNU4yXFVOwODw+xK8ia/HxiZVzgEH6PcMXNWoeXM9p1JAwIugcM9ilQt3T2kLX3bngkdkiCI8w3JcTwuuhlcEfgZbEQD6K000AUvyfnKe77MDGaVHrEF6bbp4SC8N2RmEpyFWKkcWcLLg==
- Cc: <marco.solieri@xxxxxxxxxxxxxxx>, <lucmiccio@xxxxxxxxx>, <carlo.nonato@xxxxxxxxxxxxxxx>, Julien Grall <jgrall@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Tue, 25 Oct 2022 09:22:00 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
Hi Julien,
On 22/10/2022 17:04, Julien Grall wrote:
>
>
> From: Julien Grall <jgrall@xxxxxxxxxx>
>
> In a follow-up patch, the base address for the common mappings will
> vary between arm32 and arm64. To avoid any duplication, define
> every mapping in the common region from the previous one.
Maybe the following title would be better suited if you only want to touch the
common mappings?
"xen/arm: Clean-up the common memory layout"
>
> Take the opportunity to add missing *_SIZE for FIXMAP_VIRT_* and
> XEN_VIRT_*.
>
> Take the opportunity to add missing *_SIZE for some mappings.
I think this sentence can be removed as the previous one already covers it.
Apart from that, wouldn't it be useful to do the cleanup for the arm32 macros
as you are here (FRAMETABLE, VMAP, {XEN/DOM}HEAP) ?
~Michal
|
