[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH for-4.17 v2 2/5] vpci/msix: remove from table list on detach


  • To: Roger Pau Monne <roger.pau@xxxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Tue, 25 Oct 2022 16:59:04 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=m1wrWbC+Caq4MiSWmFjLRvB0Npf8O/zMP009kIqYEJw=; b=Shw5Oc+bDOWgUS1/zjqqSvO7zGZ8Dz/ZHyQ7OwhllHvyzwuO/SP/mOqCxuiYZhfGtkGiQeFX0oefsRyY7cml68WpJKfWVUtSszrEhmFxQZPODNT9WAp6IUvkb+jeBDhjJH0p92qayzU9mez99NnPHAR2PrE4JVi+Tk+NPsbbmK922G+hs5H4aWfTq+emuek2REYhuTpGkUCJddDiL9tx7jYWpF3XxWvekdot2k7l/JKLUsg2PsI7nIo+Nc8iP2DQ9RsweMcwOXNVFAJy3QNCdkZJDWPTHi4f68po+QNAs1DDM9koHtDmJFeLot+63jwtEr5ckaQTzHQ8QA2OepxkbQ==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JMqMtOJn/vr7+2TSLI9tFz5eAK6PaNaMvV3vsmdww8K0SH75BahPwpVotlo2/7ltH69RLZJ3O4taZ+Co3kD17BmWDN6ZDXqm5yruPgeJnP/esVo3ofD+h/ndl53swVZaAPhccOaylnTNL8cR36dr0wVTLEdu6UhQvnmi7Y3qvYAAtUAWHjCndG6FHyBsb6pDW4JeeqIILmjDdGCvqf6fUMRaUNMC97fNNi9NaxXI2kqcyHZ/yWNUkOsgrL3cFwNRghMz0ecJJimp3yxASOynR4BldQ2ujpNLAAuCkmwR97JXvHjIwHxSWPa1vgxkAh23+2rWmgtGopHYUrMiTdKgYQ==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: Henry.Wang@xxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • Delivery-date: Tue, 25 Oct 2022 14:59:10 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 25.10.2022 16:44, Roger Pau Monne wrote:
> Teardown of MSIX vPCI related data doesn't currently remove the MSIX
> device data from the list of MSIX tables handled by the domain,
> leading to a use-after-free of the data in the msix structure.
> 
> Remove the structure from the list before freeing in order to solve
> it.
> 
> Reported-by: Jan Beulich <jbeulich@xxxxxxxx>
> Fixes: d6281be9d0 ('vpci/msix: add MSI-X handlers')
> Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>

Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>





 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.