[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [v2] Proposal for deviations in static analyser findings
- To: Luca Fancellu <Luca.Fancellu@xxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Wed, 26 Oct 2022 14:06:58 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bvS+6gAm3nZXIXSoOJSEGQ/JthYAowZtbB5XTXkQ818=; b=DjS467Q9x4qODoAz/v8GqPk41XYCmVDOYAs6fUiFZywb9O0VxHLC23BSh5D2vkoxW1fVXW8pHxCMIkeEmF0SXcFwOk7Kvxlyjhp5H2Ontmqgm/naB27HozTaGmWwocI76fI6vG2kctgg5B74vTf+MQodF3xdd9e09SZpf5aagLwQVzF353XBceEmxtBoRNS60FyifNtTnS/+q8MjxLHPllV1NoYVru+XTOxp2j6JxssvW9zPhKUUteYwDg/ygePY49ji4hKg3H/yoSiMBtQi+dg9cyo+gs6peHjbNYdVybTi+jCROnVZA4VdQ+MqRhifKRGg1vn93vZ59SUKb8NuCQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=O80MbpcSXSjhG2XtsgpJbu4Bj51Vx93a6DAhlIosT8elPEXBiV9VdKZBGXLnhKcnHV5QlRSgHxp58dmJmeblMWEMSEl7jttEk9WVG4/KKDjd2C8D2SPx31Ut04z/+pqNRtm9Tt8z18tWhk2V04G6oKr6aYaIn8wxE7FlXCWcprXZYpSBYwPWy987OvW6VK22B7ZEMUvFn9gvo0Q9ew/zE6UWZX4OOtjLOZ+YUTRBEaNkiqg1TJU8WmmQ/VAazZYZv1oox/ZjCI2f4ZsepXj9HAyFUsl1BoqmX7b6PF/JMBs6EPNC0NhXnn6yZ/XrFP59QKsWs8Cb9j2pGBoeQLrhvA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Wei Chen <Wei.Chen@xxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Wed, 26 Oct 2022 12:07:10 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 25.10.2022 12:13, Luca Fancellu wrote:
> Here is an example to add a new justification in safe.json::
>
> |{
> | "version": "1.0",
> | "content": [
> | {
> | "id":"SAF-0-safe",
> | "analyser": {
> | "cppcheck": "misra-c2012-20.7",
> | "coverity": "misra_c_2012_rule_20_7_violation",
> | "eclair": "MC3R1.R20.7"
> | },
> | "name": “R20.7 C macro parameters not used as expression",
> | "text": "The macro parameters used in this […]"
> | },
> | {
> | "id":”SAF-1-safe",
> | "analyser": {
> | "cppcheck": "unreadVariable",
> | "coverity": "UNUSED_VALUE"
> | },
> | "name": “Variable set but not used",
> | "text": “It is safe because […]"
> | },
> | {
> | "id":”SAF-2-safe",
> | "analyser": {},
> | "name": "Sentinel",
> | "text": ""
> | }
> | ]
> |}
Besides the still inconsistent use of double quote forms (as also pointed
out by Stefano) I'd further like to point out that colons still aren't
uniformly followed by a blank (both pointed out at v1 already, and iirc
you agreed to make both aspects consistent).
Jan
|
