[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH for-4.17 v2 1/5] vpci: don't assume that vpci per-device data exists unconditionally


  • To: Roger Pau Monne <roger.pau@xxxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Mon, 31 Oct 2022 13:14:17 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yC+z+b60CPfkAzm4S3wKlgxdb+EjYvwbbICGuJTmy3E=; b=iHkOnuqyQHnkV0GoxA3lDeZf2vOxSHPAZCE2WmZPo5rs93HeBaFVuYU3snY9QkVi84JTu/sf5dXJAyaNXAGF/zoCArVxce/YD23BgUB0/2qTgrqBlWdHAq1IAfTPBa3jyaJsSXf6ysdiZ1WZglEROGQRfdX5sOfB5ZILBRP9GbKg0wbL5HsSVkclV8qoOT9euRRpINS2pTJAxWp06TayiLA2SWojq/40QjC18eyqwK+/1h6jNWhWBp2SmFwG+06BdgbU2b7LEXbfIlfmdohgOlW6Si7+KaR0Y4Faeap9V8gu0pWFnn35oQotWRtd/pXUPWNRsxcLMM3jFuyH4R9zBA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NXsne1y/wTX4el87L4tQV13mODKsdNopkjhma3k0n3klHLYEn+QnBlu3DTx7IRb+EflCscfWX6jlCq4pIGHJ26hUk7/EwmiJZ3uBQPZsoNf5YQ1BTHcz2JGRbleo4j4E50Q7ijbZ1uNDx/8NxgDHpXvmN7VoVY3IE1xubKFcwhGpuR3Ve0JfWqJEhN6vZ3my8+uOh8vw2hmqPngElNB04eJ6nnIUd+fHZQcVw9Zjml4pWKv73atvF2kW5tiySMzcJb/lpKVYfzP4d4Z/gK+zrCXrYB3HQ1v/w6iTY9ssYRGUdjAt/32wGF08ixavnP8jWTKV5hUtfZcexm53cO0PYQ==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: Henry.Wang@xxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • Delivery-date: Mon, 31 Oct 2022 12:14:24 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 25.10.2022 16:44, Roger Pau Monne wrote:
> --- a/xen/drivers/vpci/vpci.c
> +++ b/xen/drivers/vpci/vpci.c
> @@ -37,7 +37,7 @@ extern vpci_register_init_t *const __end_vpci_array[];
>  
>  void vpci_remove_device(struct pci_dev *pdev)
>  {
> -    if ( !has_vpci(pdev->domain) )
> +    if ( !has_vpci(pdev->domain) || !pdev->vpci )
>          return;

Btw (noticing while backporting) - is the left side of the || still
needed then?

Jan




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.