[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH for-4.17 v1 0/2] xenctrl.ml: improve scalability of domain_getinfolist
- To: Edwin Torok <edvin.torok@xxxxxxxxxx>
- From: Christian Lindig <christian.lindig@xxxxxxxxxx>
- Date: Wed, 2 Nov 2022 09:11:16 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=L/h6dsfgncYhEPqHTBICIMVOyM5d4zj+ofmNBj6XvEY=; b=iw/CfGDxJSm6XoOIzcgqTda5cRKId1aEeU56dR2n1EqnIOukM4A1oYdoiisvTwncN9oaAiOfLUm1mM2Vw0sgSxpTih8SeVHbDfY/DzNHCd1JCvlDFLUkbpAnl1x0Y7XGDHpM+GY8YTFKujJXxsFTjMvOwV91rk6QrQ3K5R/4Ax7viPgqT6MVhMdP+WfZlROXHKyT3JRRfqr/j+hff+U3HSeXq9LpQTOOMXEg8bmW8ayxPe36MBrpK0TVRlZeGBPVtODk5D0CXERWjGhJNYXR7ERCO+ME1JV26oWjH8M8t95KB6T5Mw/3Uaenvvz9FQFz/Aa3GtjJStslyoZswNonUg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=be9V4yJeuumd5sM0UBVHvlNdCM35FVq+Zwyd298d/NUhjRTa1QxMNs5pmg6iJN7KA7qLDPHOv97FWfLHIds7aNG6+kt4BfcbaLMJfTSfD/xrrw0fc6CmIp0HkxVWOHOy6zB0wEtJv2YvwRc7n0wQaFoq+mB3fmmoZl5YL0HTU1VZSTOKZF1YBi7UnKL+1h3kIkLRc0kUWMpa1MJm8aYq7tVYHMFKnJO7OeGoMRWcEYlnqtGJ7fhuVgsf4ob2vpb6lASUfYNd/+TeC6igP4KLrbBNhc0AcXoXdxTSoVHhH5xCy+pkq/zXr9tZAGyYjzpolZrSCVtVl0gbGljhq5UQPw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Pau Ruiz Safont <pau.safont@xxxxxxxxxx>, David Scott <dave@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Anthony Perard <anthony.perard@xxxxxxxxxx>
- Delivery-date: Wed, 02 Nov 2022 09:11:41 +0000
- Ironport-data: A9a23:JpXY0avRyJRX0UgEtn5JFfJngufnVHRfMUV32f8akzHdYApBsoF/q tZmKTqCOq3cNDGne953aITi9xlU65LXn9I3TABpq3pgH3wV+JbJXdiXEBz9bniYRiHhoOCLz O1FM4Wdc5pkJpP4jk3wWlQ0hSAkjclkfpKlVKiffHg0HVU/IMsYoUoLs/YjhYJ1isSODQqIu Nfjy+XSI1bg0DNvWo4uw/vrRChH4bKj5Vv0gnRkPaoR5QaGzSFMZH4iDfrZw0XQE9E88tGSH 44v/JnhlkvF8hEkDM+Sk7qTWiXmlZaLYGBiIlIPM0STqkAqSh4ai87XB9JFAatjsB2bnsgZ9 Tl4ncfYpTHFnEH7sL91vxFwS0mSNEDdkVPNCSDXXce7lyUqf5ZwqhnH4Y5f0YAwo45K7W9yG fMwcSoGNzqqnMiM3LODbbF+tpx7ItWxBdZK0p1g5Wmx4fcOZ7nmGvyPz/kImTA6i4ZJAOrUY NcfZXx3dhPcbhZTO1ARTpUjgOOvgXq5eDpdwL6XjfNvvy6Pk0osgP60boq9lt+iHK25mm6Tp njH5Hj4CxdcMN2ZxTuK2nmtmvXOjWXwX4d6+LiQpqA32gfInDB75Bs+X1GphPCymkiHW4x+A RM40TI2jKEU+xn+JjX6d1jiyJKehTYMVtwVH+Ak5QWlzqvP/x3fFmUCViRGatEtqIkxXzNC/ lOAgd7BHzFkt7yRD3WH+d+8sjeaKSUTa2gYakc5oRAt5tDipMQ5iELJR9M6Saqt1ISrSXf33 iyAqzU4i/MLl8kX2q6n/FfBxTWxupzOSQ1z7QLSNo640j5EiEeeT9TAwTDmATxode51knHpU KA4pvWj
- Ironport-hdrordr: A9a23:4ieTfaNj/MLa0MBcT2L155DYdb4zR+YMi2TDiHoddfUFSKalfp 6V98jzjSWE8wr4WBkb6LO90DHpewKQyXcH2/hqAV7EZnirhILIFvAp0WKG+VHd8kLFh4lgPM tbEpSWTeeAdWSS7vyKrzVQcexQpuVvmZrA7Yix854ud3ASV0gK1XYaNu/vKDwTeOAwP+tdKH Pz3Kp6jgvlXU5SQtWwB3EDUeSGjcbMjojabRkPAANiwBWSjBuzgYSKUiSw71M7aXdi0L0i+W /Kn0jS/aO4qcy2zRfayiv684lWot380dFObfb8yvT9aw+cyTpAVr4RHoFqjwpF5N1HL2xa1+ Ukli1QffibLUmhOF1d7yGdgjUImwxelkMKgWXo/UcL5/aJCg7SQvAx+75xY1/X7VEts8p717 8O12WFt4BPBReFhyjl4cPUPisa33ZdMRIZ4JEuZlFkIPwjgYVq3Poi1VIQFI1FEDPx6YghHu UrBMbA5OxOeVffa3zCpGFgzNGlQ3x2R369MwM/k93Q1yITkGFyzkMeysBalnAc9IglQ50B4+ jfKKxnmLxHU8dTZ6NgA+UKR9exFwX2MFrxGXPXJU6iGLAMOnrLpZKy6LIp5PuycJhN15c2kI SpaiItiYfzQTOaNSSj5uw5zvmWehTNYd3E8LAv27Fp/rvhWbHsLSqPDFgzjsrImYRsPvHm
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHY7hu7nGK02b4G20+MH2/c4dYgF64rWegA
- Thread-topic: [PATCH for-4.17 v1 0/2] xenctrl.ml: improve scalability of domain_getinfolist
> On 1 Nov 2022, at 17:59, Edwin Török <edvin.torok@xxxxxxxxxx> wrote:
>
>
> Edwin Török (2):
> xenctrl.ml: make domain_getinfolist tail recursive
> xenctrl: use larger chunksize in domain_getinfolist
>
> tools/ocaml/libs/xc/xenctrl.ml | 25 ++++++++++++++++++-------
> 1 file changed, 18 insertions(+), 7 deletions(-)
Acked-by: Christian Lindig <christian.lindig@xxxxxxxxxx>
> It was calling the Xen domainfolist hypercall N/2 times.
> Optimize this such that it is called at most 2 times during normal use.
>
> Implement a tail recursive `rev_concat` equivalent to `concat |> rev`,
> and use it instead of calling `@` multiple times.
Are there any assurances about the order in elements returned by
domain_getinfolist? I understand that the change maintains the current
behaviour but are we even required to maintain that order? Because otherwise we
could return the reverse list and save more work.
— C
|
