[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [XEN PATCH for-4.17 2/4] tools/include/xen-foreign: Capture licences from the input headers


  • To: Anthony Perard <anthony.perard@xxxxxxxxxx>
  • From: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>
  • Date: Wed, 2 Nov 2022 15:57:41 +0000
  • Accept-language: en-GB, en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7MKrfU+TfDZRRvp/RX8s8mz2mvqkzu6dKND9Aya/as0=; b=FcAN/db4lpECOlA+U6NQ1J1hxZpXyUvVZUTPRoff3MLRZtoN+J0wqlOD2QdH9meQZogft8lNBM2uR5HHawbhcaVR9aHkO2XlCxd0rC0DoHFrGqTZ1MkGb/qy85VIJRqPZa/b28lrapTPW413+dQeyfwRJuF2XFp0P9wxrwCfBFysJIvo1CC4Z2jhBcZlxvoiKIAXCjnUPavSBwB55K0qaoTGjsBr38zKFkzzTbzF/xga+mZ7Q/JqOfYQnI3VZJ16jbplQTIr1BzpJ/Kjzqp3YPatF7Y9R2AFKOZo4x7VSw81QqDdRg5Nlx09ACQFqLOq/mApMvC3b89ubzcOoLTDTA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TvXhTcGt8F77zDSaup5ED+vlUn/NT256DrLBBfu2uxtSh45FJf0juvlR/QNzmZ+rHTf0xJCli2jOZZfQORPn/JiYheXYW2Lhpkr3WwnVrgqjSdRreQtnk37XpBPlUnX2PO60MXR3j89YVNW+P3UnSS7k+WJY1KusObwFrwb+X04EmSeiyAqlT3i7+nOxhi9Mpptgo7hZyj/U6XDOARGcxfYAE3EtejvT4L+saXe4S62fDvVg4TZXoFPro+f7jmZApnu7jnykv3hlMx7Pv3Fc/K+5ezg/ZQXbjVXZMtyXwtZffJDdbVmmxXwa/U2oLpYnJdEUQo51u7oUUaTksMUSTA==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
  • Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Henry Wang <Henry.Wang@xxxxxxx>, George Dunlap <George.Dunlap@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
  • Delivery-date: Wed, 02 Nov 2022 15:57:56 +0000
  • Ironport-data: A9a23:vri6+6+wN1RKiY7SHrSlDrUDZn+TJUtcMsCJ2f8bNWPcYEJGY0x3m mAXXT+Ha62Dazf9KdkiYIu1805VsZDQnNRnG1A++X88E34SpcT7XtnIdU2Y0wF+jCHgZBk+s 5hBMImowOQcFCK0SsKFa+C5xZVE/fjUAOG6UKucYHsZqTZMEE8JkQhkl/MynrlmiN24BxLlk d7pqojUNUTNNwRcawr40Ire7kIy1BjOkGlA5AZnPKgR5AW2e0Q9V/rzG4ngdxMUfaEMdgKKb 76r5K20+Grf4yAsBruN+losWhRXKlJ6FVHmZkt+A8BOsDAbzsAB+v9T2M4nQVVWk120c+VZk 72hg3ASpTABZcUgkMxFO/VR/roX0aduoNcrKlDn2SCfItGvn9IBDJyCAWlvVbD09NqbDklk5 +RIDWwkYim6mrvm3Yz4dvh3oM8KeZyD0IM34hmMzBn/JNN/G9XpZfWP4tVVmjAtmspJAPDSI dIDbiZiZwjBZBsJPUoLDJU5n6GjgXyXnz9w8QrJ4/ZopTWOilUujNABM/KMEjCObexTklyVu STt+GPhDwtBHNee1SCE4jSngeqncSbTCN5KSOfirqYCbFu7z0UDESYIeFaBuKe8pmWQBctbJ hctw397xUQ13AnxJjXnZDWorXjBshMCVt54F+wh9BrL2qfS+xyeBGUPUnhGctNOnO87QyY7k GCAmdzBDCZq9raSTBq19L2ZsDezMig9NnIZaGkPSg5ty9v+pIA+iDrfQ9AlF7S65vXuAi35y T2OqCk4hp0QgNQN2qH9+krI6xqzorDZQwhz4R/YNl9J9St8bY+hIoauuV7S6K8aKJ7DFwbd+ n8Zh8KZ8eYCS4mXkzCAS/kMG7fv4OuZNDrbghhkGJxJGymRxkNPtLt4uFlWTHqF+O5eEdM1S Cc/YT9s2aI=
  • Ironport-hdrordr: A9a23:d8lHva4qfA1hgQVvowPXwWuBI+orL9Y04lQ7vn2ZFiY5TiXIra qTdaogviMc0AxhI03Jmbi7Scq9qeu1z+853WBjB8bZYOCAghrlEGgC1/qp/9SEIUHDH4FmpM BdmsRFaeEYSGIK9foSgzPIXOrIouP3lpxA7N22pxgCcegpUdAY0+4TMHf4LqQCfngjOXNPLu v42iMonVqdUEVSSv7+KmgOXuDFqdGOvonhewQ6Cxku7xTLpS+06ZbheiLonys2Yndq+/MP4G LFmwv26uGIqPeg0CLR0GfV8tB/hMbh8N1eH8aB4/JlagkEyzzYJ7iJaYfy+Qzdk9vfrGrCV+ O85CvICv4DqU85uFvF5ycFlTOQiQrGoEWStGNwyUGT3fARAghKRfapzLgpDCcwoSAbza5B+b MO0GSDu5VNCxTc2Cz7+tjTThlv0lG5uHw4jIco/jViuKYlGchsRLYkjTVoOYZFGDi/5JEsEe FoAs2Z7PFKcUmCZ3ScumV02tSjUnk6Ax/DGyE5y4eo+ikTmGo8w1oTxcQZkHtF/JUhS4Nc7+ CBNqhzjrlBQsIfcKo4DuYcRsm8DHDLXHv3QSqvCEWiELtCN2PGqpbx7rlw7Oa2eIYQxJ93g5 jFWEMwjx9HR6svM7z64HRmyGG/fIzmZ0Wd9ih33ekIhpTsALz2LCaEVFci18O9vvR3OLyoZ8 qO
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Thread-index: AQHY7q5XVsL2+RG/AUCiEkMy4e8OGa4rjrQAgAAvhgCAAAwWgA==
  • Thread-topic: [XEN PATCH for-4.17 2/4] tools/include/xen-foreign: Capture licences from the input headers

On 02/11/2022 15:14, Anthony PERARD wrote:
> On Wed, Nov 02, 2022 at 12:24:21PM +0000, Andrew Cooper wrote:
>> On 02/11/2022 11:28, Anthony PERARD wrote:
>>> Notes:
>>>     Maybe instead of this, we should just stamp this on the generated header
>>>         /* SPDX-License-Identifier: MIT */
>>>     
>>>     but we would be missing the "Copyright" informations. I guess we could
>>>     look for those line with Copyright and copy them.
>>>     
>>>     Or, we could replace the licence in the input header by a SPDX and have
>>>     the script parse that. (Probably still need to grab the Copyright lines)
>> All public headers (except one :-( ) are MIT.
>>
>> We should SPDX the lot, not least because that removes all the
>> guestimation from this script; we can require that the SPDX line is the
>> first line, and sanity check it as we process it.
> Yes, but I'm not sure I want to do the SPDX change when the tree is
> supposed to be frozen.

The licensing corrections are a release blocker.

The frozenness of the tree has no bearing on the acceptableness of the
fix.  Especially when all we're talking about is adjustment of some
(legally-relevant) comments.

In this case, switching to a more machine-parsable form, in order to get
the autogeneration correct, is IMO fully acceptable even at this point
in the release.

~Andrew

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.