[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH for-4.17] Revert "x86/HVM: also dump stacks from show_execution_state()"
- To: Roger Pau Monne <roger.pau@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Henry Wang <Henry.Wang@xxxxxxx>
- Date: Fri, 4 Nov 2022 15:02:03 +0000
- Accept-language: zh-CN, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hyjY2hz+EbXzSl4D44BhXe26W7DX48s4evM5fZRhP98=; b=Og1tIplWrqUJtr6CE9VBjeG8JIB+lxaPpL+YDmcl5sEfj0RDCIlsAgLlrpv4zfoOnoh2aSOQQ/iYRH1gkZiUsLaxZ7kb+XDIGn/qcnvQDi50xrklUvXJTDeHoNuobfLnBFoQ0gOR/0OWMhEbwP1OtcRISiWmdrgtCqWL/DF+zPSozV+lYQtvA6Td3lHmYJvEN5yLW08aFCtWMc/ep5cb7s68s8ceNRa6RDVnWmLq8/m5YmkYqUl6BPz4/f7m5trGpWzItPCmADMXw/ga5tTKgTcrPH8RukJ66xFLZIR67V3ZyyH+5pqPFv8GSyvgRLBj0YWobfNObxpfZXfRH/msxg==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hyjY2hz+EbXzSl4D44BhXe26W7DX48s4evM5fZRhP98=; b=UMBiffAj0QtP4wMnZoUekQIlomosydovqLAt093K1RIHmLD/DAB4m9Hkl/aXlrf+H31+BzlM/SDNMRTghCJbFSkDRfdcXBnHowwnyJqaCm10RRghv2nX7OW3/tj1ztpQJ5D2KbmRY+YC4a7dI0I03xubp1hRzXTLofqav5Oljw+MCMQSO0jAGNb0z2rY4jdaDOKNL4gcxqz3pHs+qC0JuOL212DQY5haBnJGalWDst6wtLVofmQ7sF03XJgY5XNR1d9UP95lshorJELAe9s874V4FnyIdGTAiKIdpVBQ1tAFW+/dXFUSlUqlMHXoVhsI6md9BwouNy/2sb6Ni3/kyQ==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=FOKdxA64ApjICumSqneVN16i8MdvcCpRjUMKFbXGbX1e4I/MfmnP9ce57qqQCnMbIqYzKH35g+PIw2lSYGVVkDzZr91amalxAs+0CXRmh8yHZTZwPLtC5k/ngq2E01cu5XJqIXiHL1/i8BxqT9QKhLCSB+Qt13hmWKodaqRvk2EEMOzPpeZ48hmsDdDJmX0Qn4Rl786DJL3Z1Le07YqABvoxDqEHDDK6Dw/qNo7X0WO5pg4jGa6wa0wd1qhhVqH30o3/K3qV71Uke0Y51vfV7lWiu702vwLHMtUc4Hc+zLkLc7hIH3Ga6ukf5rJnbAsMjcrJTTdwC1sSUEAlnmDGSg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DUrBB7bL1zN0CsU8q0AEuWIVxGtw4h/s3HJYOw9wszmEIOBXhrhh8g3sll/j2BNw/ZmNnuKlKJczqR27xkMb6ccRB+Aap/1IL5Bfb4ubKXMIAmC7ozdD1OCRuWkSVWKLEPJ2FAsRvqt7ZMNvUZYqFFkEcms6o2IY6DVuCCTE9A1qw8jjs4L86YXurXdDGyYuSIUI7tzHqXUKqJoGO8AEkpJylmuBQ1zIvG2jYhvutOri4iQBHY7JelSzPw6BL/3lH6Biu9AZMaHb0J6Y9Pmi36k+bZpT3i5B+dYPv61V912NpZXCRuSnRcWPLFcJg78v5Fj5/PRNKFP+gMfPRgeOUA==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Delivery-date: Fri, 04 Nov 2022 15:02:19 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHY8Fvo92EmCyvfk0qQoQum7MnN2a4u2/HQ
- Thread-topic: [PATCH for-4.17] Revert "x86/HVM: also dump stacks from show_execution_state()"
Hi Roger,
> -----Original Message-----
> From: Roger Pau Monne <roger.pau@xxxxxxxxxx>
> Subject: [PATCH for-4.17] Revert "x86/HVM: also dump stacks from
> show_execution_state()"
>
> This reverts commit adb715db698bc8ec3b88c24eb88b21e9da5b6c07.
>
> The dumping of stacks for HVM guests is problematic, since it requires
> taking the p2m lock in order to walk the guest page tables and the
> p2m.
>
> The suggested solution to the issue is to introduce and use a lockless
> p2m walker, that relies on being executed with interrupts disabled in
> order to prevent any p2m pages from being freed while doing the
> walk.
>
> Note that modifications of p2m entries are already done atomically in
> order to prevent the hardware walker from seeing partially updated
> values.
>
> Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
Release-acked-by: Henry Wang <Henry.Wang@xxxxxxx>
Kind regards,
Henry
|
