[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH for-4.17?] x86/pvh: report ACPI VFCT table to dom0 if present


  • To: xen-devel@xxxxxxxxxxxxxxxxxxxx
  • From: Roger Pau Monne <roger.pau@xxxxxxxxxx>
  • Date: Tue, 8 Nov 2022 14:55:16 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DJFdBjT8c7JFwxImwCDSmPg1YX4xF4xhzi5JAtkUwMA=; b=ajqgvZ3DjUdLVZ0xnrlFEcoTOqvxNJioraS8v4pJBy6BEDbDtCcb7LhF8NWDOfENjE813FMSxOIbNYo2kTnz5hgH9IM+A/v/0VOuxB2nMqvmu3mj9gcIjVr4z1FTge9IMi5HGT6oa5vSiNabpc8SqDENF0xbBMqGkY3PVWpPM/c805QaI8Wo3h5L4twgsmJ1aZT9AAvbhQvTMaYZfg9NP7UVq4IKcLAWvIKUKpAFXkakCGAFvcTsAanrpUXjXjLUd/+l2kdoxYZ6AjasriT1fThCoCTBi+Q2rJK3fq043P4ZvT30/qSaIj3reeTpIEEoZIAQZrs/OELlzc0wciZj0A==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MweVAkJxvCI1HpmtH3Yasg4DSpc91DL8njAgduyLhnXl1aPX7OnbA+JfSpwqGy8+KZsCiigRS9c8JFfdCID5ALUUdlnzR0WJxp0N/uKi/btcLNYLFQaKo3tBX+pFG5SFRlEgrTO0nVb3/WXaVzv+CMF6vEIOJgxlEY1bTaORWLy7DwT3ESVN+jbwvDK6RQFR62xdW81TYtfFdSlKWjETkta3GTfvfG1fvHK9DSIF9Gf4efm74Eaa1ZEVa3KDmLQeWnJIcn3HQlmWRVTvsvBXSX57YawFXfbBCfOjIU+rJejtzjl1Sbom6kgyZLyERfTjLcvQGp4efuGRnHRMYRaSHQ==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
  • Cc: Henry.Wang@xxxxxxx, ray.huang@xxxxxxx, Alexander.Deucher@xxxxxxx, Roger Pau Monne <roger.pau@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
  • Delivery-date: Tue, 08 Nov 2022 13:56:12 +0000
  • Ironport-data: A9a23:+qInK6+Iywbflc63Hh+GDrUDYX+TJUtcMsCJ2f8bNWPcYEJGY0x3m GFNUW7Sb/3cYWr1edp2Od/n90gFu8XQzYBiQQJl/CE8E34SpcT7XtnIdU2Y0wF+jCHgZBk+s 5hBMImowOQcFCK0SsKFa+C5xZVE/fjUAOG6UKucYHsZqTZMEE8JkQhkl/MynrlmiN24BxLlk d7pqojUNUTNNwRcawr40Ire7kIx1BjOkGlA5AZnPKgb5Aa2e0Q9V/rzG4ngdxMUfaEMdgKKb 76r5K20+Grf4yAsBruN+losWhRXKlJ6FVHmZkt+A8BOsDAbzsAB+v9T2M4nQVVWk120c+VZk 72hg3ASpTABZcUgkMxFO/VR/roX0aduoNcrKlDn2SCfItGvn9IBDJyCAWlvVbD09NqbDklXr KQWdgEdQyyens+45oC4dsxgiOYseZyD0IM34hmMzBn/JNN/GdXmfP+P4tVVmjAtmspJAPDSI dIDbiZiZwjBZBsJPUoLDJU5n6GjgXyXnz9w8QrJ4/ZopTWOilUpi9ABM/KMEjCObd9SkUuC4 HrP4kzyAw0ANczZwj2Amp6prr+RzHmnBdxIfFG+3v9GkH+v614uMjhMDhy4i+WF0mikcusKf iT4/QJr98De7neDXtT7GhG1vnOAlhodQMZLVf037hmXzajZ6BrfAXILJhZhZdo8pYkJTDol/ laTmpXiAjkHmKecWDSd676Sohu7PCRTJmgHDQctSQYV6t/vrZt1oh/SRdZuCoa8i9GzEjb1q xiIpiUjg7QYjeYQyr62u1vAhlqEuZzhXgMzoALNUQqYAhhRYYekY8mt9gLd5PMZdIKBFADZ5 z4DhtSU6/0IAdeVjiuRTe4RHbavofGYLDnbhl0pFJ4kn9iwx0OekUlryGkWDC9U3gwsI1cFv Ge7Vdtt2aJu
  • Ironport-hdrordr: A9a23:FQIpMK550W+5PL1tRwPXwSeBI+orL9Y04lQ7vn2ZFiY5TiXIra qTdaogviMc6Ax/ZJjvo6HjBEDmewKlyXcV2/hpAV7GZmXbUQSTXeVfBOfZowEIeBeOi9K1q5 0QFJSWYeeYZTYasS+T2njDLz9K+qjjzEnHv5a88587JjsaEJ2Ioj0JfjqzIwlTfk1rFJA5HJ 2T6o5uoCehQ20eaoCeCmMeV+bOitXXnNa+CCR2cSIP2U2rt3eF+bT6Gx+X0lM3VC5O+64r9S zgnxbi7quunvmnwlv31nPV7b5RhNz9o+Ezc/Cku4wwEHHBmwyobINuV/mruy00mvim7BIQnN zFs34bTrdOwkKUWlvwjQrm2gHm3jprwWTl00WkjXzqptG8bC4mCuJa7LgpOCfx2g4FhpVRwa hL12WWu958FhXbhhnw4NDOSlVDile0m3w/iuQe5kYvGrf2UIUh4bD3wXklX6vpREnBmc4a+a hVfYnhDc9tAB6nhyuzhBgv/DSuNk5DbituDHJy+vB96AIm4kyR/3FouPD3oU1wi67VM6M0gd gsEp4Y5o2mHfVmGJ5VNaMmffadLFDrbFblDF+ySG6XZZ3vfUi94qLK3A==
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

The VFCT ACPI table is used by AMD GPUs to expose the vbios ROM image
from the firmware instead of doing it on the PCI ROM on the physical
device.

As such, this needs to be available for PVH dom0 to access, or else
the GPU won't work.

Reported-by: Huang Rui <ray.huang@xxxxxxx>
Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
---
This is a bugfix, but given PVH dom0 is still experimental I'm not
sure it would qualify for the release.  OTOH being experimental means
there are no guarantees it will work, so the change is unlikely to
make this any worse.
---
 xen/arch/x86/hvm/dom0_build.c | 1 +
 xen/include/acpi/actbl3.h     | 1 +
 2 files changed, 2 insertions(+)

diff --git a/xen/arch/x86/hvm/dom0_build.c b/xen/arch/x86/hvm/dom0_build.c
index 1864d048a1..307edc6a8c 100644
--- a/xen/arch/x86/hvm/dom0_build.c
+++ b/xen/arch/x86/hvm/dom0_build.c
@@ -924,6 +924,7 @@ static bool __init pvh_acpi_table_allowed(const char *sig,
         ACPI_SIG_DSDT, ACPI_SIG_FADT, ACPI_SIG_FACS, ACPI_SIG_PSDT,
         ACPI_SIG_SSDT, ACPI_SIG_SBST, ACPI_SIG_MCFG, ACPI_SIG_SLIC,
         ACPI_SIG_MSDM, ACPI_SIG_WDAT, ACPI_SIG_FPDT, ACPI_SIG_S3PT,
+        ACPI_SIG_VFCT,
     };
     unsigned int i;
 
diff --git a/xen/include/acpi/actbl3.h b/xen/include/acpi/actbl3.h
index 0a6778421f..6858d3e60f 100644
--- a/xen/include/acpi/actbl3.h
+++ b/xen/include/acpi/actbl3.h
@@ -79,6 +79,7 @@
 #define ACPI_SIG_MATR           "MATR" /* Memory Address Translation Table */
 #define ACPI_SIG_MSDM           "MSDM" /* Microsoft Data Management Table */
 #define ACPI_SIG_WPBT           "WPBT" /* Windows Platform Binary Table */
+#define ACPI_SIG_VFCT           "VFCT" /* AMD Video BIOS */
 
 /*
  * All tables must be byte-packed to match the ACPI specification, since
-- 
2.37.3




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.