[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH for-4.17?] x86/paging: return -EINVAL for paging domctls for dying domains
- To: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Wed, 9 Nov 2022 13:02:28 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2YRWvhob7PLo/+0qHjSG6O0AeCXuOALRAFw2aOYy5c4=; b=JPEbm5o5t6Xpb6LGDs6eFhZKpPihRh803L79gRUxLditQfqIhRtf2fS3eo7OleoO8bUI76zRsygtB6s6jNxZrVfUBTBGU25lXDlrkwPtqDKX7OOznnvrVtfxhp5eTaZzhqdZAB8CNR3YOm/Kyg6nWhrbI+yUTiPEW3UaeJEVjPPQSpPJcKebbEnFZYQdYxQhpG8QBRjGe+Qw2X58CqfbdBEEh1PxySVrVula/U7EsXCaykSzDfBExI61dIl2XSwskR5Eo1Ost5FmPKBttAyhdA8YDQwekYsE8Yxf+RNuWDZSkpUu/buDI/ygi7g3/fSAvAPrQiZZCUaQeZ5Di6h3Bw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YfZgdrVM4ozJQHO4h3WIoYQWbgEqLujmumztq8zHtw/31sNGTjZ/Dg2i/u3GLWMUgninCnWEQK6ZbrfA3wIslnfOl/lTqG6pa5r1kEVmn+3MPGyEv7mPupPes6mq16TsoBGrSnccpCEqMHZ5F7mu5kovpAg/RWbpWqRLQz79/W36Mty4S6oqaVCCv3OLhDSq3TRK9nzIHHwmjRV8DPq06PADu2ScmT36jQlC19KBt5XE01QicTsU0Aar1ZuJdssa7Nhk07yAW942eSa63AAyZhFP0Oi5B9Ipw3jlyY4yLRrPpjN8s4LmppBvmXN61dKYq9c0HUzGn+xHcyMQrX8acg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Henry.Wang@xxxxxxx, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Edwin Török <edvin.torok@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Wed, 09 Nov 2022 12:02:52 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 09.11.2022 12:36, Roger Pau Monné wrote:
> Since I don't see replies to my other comments, do you agree on
> returning an error then?
No, my view there hasn't changed. I wouldn't block a change to go in
early for 4.18, but I also wouldn't ack such.
Perhaps just one remark on your other earlier comments: While you're
right about XEN_DOMCTL_SHADOW_OP_{CLEAN,PEEK}, (effectively) random
data in the bitmap may cause a caller to do extra work, but wouldn't
look to be otherwise harmful: Considering pages dirty which aren't
is never a functional problem, while considering pages clean which
aren't is (imo) not a problem for a dying domain.
Jan
|
