[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH for-4.17 v3 04/15] tools/ocaml/xenstored/Makefile: use ocamldep -sort for linking order


  • To: Edwin Torok <edvin.torok@xxxxxxxxxx>
  • From: Christian Lindig <christian.lindig@xxxxxxxxxx>
  • Date: Wed, 9 Nov 2022 13:44:59 +0000
  • Accept-language: en-GB, en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qXD1RxX7vqdw4JgR/bVNDIO4Shxu73cXxJbUFzFSm/A=; b=RXAnUBvVv7/6Mw+rtVoO+BNPlRDB08cJoK2R683EktRskC8YYwi7YGUDNoGcYHYb9tJ2UUoaWavOMSGTbCAgKuXU4dm17Xx/qdnM0ysP3Nj9ye1n6kD613t3UBfZUUGPHaMWb2+b92grzCM8v6b9RXrlB2CpwGFRqjBg1k9AvASPcqwYug8ZWG+jVG5IB5qGNd7WWFCUrsYa9g+aEo6jdYHpPwW0ec8x5QCPHLyXfYxjXmcH/EPz2k9h0f0AAQ9ga7cPFu2kQMHfAhCK6i3FobmaQjtiuvH/m1NzCKxgjnO9f866hQiC3LsPjSoXvwZAs+nmyc+qR6BmNA/+gq45XA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UzBMxRBsY83oz8IaQTJ4S3BF4REz0+vKpyFQ2d24aVm6n/8o3gjDlN1kKtUySwOs6eicw3GIHvjbpgpcjYnn8aGMUS++N19wg+9Wre5koWOVaxEiRO+2mYUSyuE4S5J9ewWPGTagSdr2jshrS3FNh8I2tqHuDSekSUiPIrha80baaCaCXdoFW8hjsJrOWli0lsK7icXkdj+7/gt05YrpgK+Exl6w2jFvilDBvXE2f3U4gBqTX4uXDbQOLbx3TALLMJjdmFE+9tJewP8la2oFJSkTugtpDYSJ7/bI/kPdpRgsmS6fEffkPD7EnBhd1wk82W0R19mLZVMANzLQoBzgNQ==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
  • Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Henry Wang <Henry.Wang@xxxxxxx>, David Scott <dave@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Anthony Perard <anthony.perard@xxxxxxxxxx>
  • Delivery-date: Wed, 09 Nov 2022 13:45:18 +0000
  • Ironport-data: A9a23:8xQmJ6DhHImmQBVW/xbiw5YqxClBgxIJ4kV8jS/XYbTApGgihDICx mcbUTzXOPeCNzTye9F+YIq18xtTucXUn9RlQQY4rX1jcSlH+JHPbTi7wuUcHAvJd5GeExg3h yk6QoOdRCzhZiaE/n9BCpC48T8nk/nNHuCnYAL9EngZbRd+Tys8gg5Ulec8g4p56fC0GArIs t7pyyHlEAbNNwVcbyRFtcpvlDs15K6o4WpA7wRkDRx2lAS2e0c9Xcp3yZ6ZdxMUcqEMdsamS uDKyq2O/2+x13/B3fv8z94X2mVTKlLjFVDmZkh+AsBOsTAbzsAG6Y4pNeJ0VKtio27hc+ada jl6ncfYpQ8BZsUgkQmGOvVSO3kW0aZuoNcrLZUj2CA6IoKvn3bEmp1T4E8K0YIw5cB5BWduz t8kcA8cNU+p1/D17b6eRbw57igjBJGD0II3nFhFlGucKMl8BJfJTuPN+MNS2yo2ioZWB/HCa sEFaD1pKhPdfxlIPVRRA5U79AuqriCnL3sE9xTL++xrvQA/zyQouFTpGNHVYN2RWcRcmACcp 2TK/mvRCRAGLt2PjzGC9xpAg8efwnujCdhMTNVU8NZWn3q6/00wNCQRFnyDkMi7jH7gWu9Qf hl8Fi0G6PJaGFaQZsnwWVi0rWCJujYYWsFMCKsq5QeV0K3W7g2FQG8eQVZpSNEgrt5wejUs2 XeAhdavDjtq2JWZQGyQ3q2ZpjSzPW4SN2BqTTAAZRsI5Z/kuo5bs/7UZtNqEarwi8KvHzj1m mqOtHJm2+tVitMX3aKm+1yBmyirupXCUg8y4EPQQ36h6QR6IoWiYuRE9GTm0BqJF67BJnHpg ZTOs5H2ADwmZX1VqBGwfQ==
  • Ironport-hdrordr: A9a23:Kcqscq/uIOagoSVfxp5uk+Fudb1zdoMgy1knxilNoENuH/Bwxv rFoB1E73TJYW4qKQodcdDpAtjifZquz+8O3WBxB8bpYOCCggeVxe5ZnOzfKlHbehEWs9QtrZ uIEJIOReEYb2IK6/oSiTPQe7lP/DDEytHQuQ609QYOcegeUdAF0+4PMHf/LqQZfml7LKt8MK DZyttMpjKmd3hSRN+8HGM5U+/KoMCOvI76YDYdbiRXpzWmvHeN0vrXAhKY1hARX3dk2rE561 XIlAT/++GKr+y78BnBzGXehq4m1ucJi+EzRfBkuPJlaQkEuTzYJriJnIfy+QzdldvfqGrCVu O85yvIcf4DrE85NVvF3CcFkzOQrArGrUWShWNwyEGT3/DRVXY0DdFMipledQac4008vMtk2K YOxG6BsYFLZCmw1RgUd7DzJm5Xf2eP0A0feNQo/gpieJpbbKUUoZ0U/UtTHptFFCXm6Jo/GO 0rCM3H/v5ZfV6Tcnic5wBUsZeRd2V2Gg3DTlkJu8ST3TQTlHdlz1EAzMhamnsb7poyR5RN+u yBOKV1k7NFSNMQcMtGda88aNryDnaITQPHMWqUL1iiHKYbO2jVo5qy+7kx7PHCQu198HLzou W1bLp1jx9AR6u1M7z+4HRiyGG8fEytGTLw18pZ+591/rXhWbuDC1zwdGwT
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Thread-index: AQHY84eenq2hHhUnbkWZgEyFUAHf2K42m9eA
  • Thread-topic: [PATCH for-4.17 v3 04/15] tools/ocaml/xenstored/Makefile: use ocamldep -sort for linking order



On 8 Nov 2022, at 15:33, Edwin Török <edvin.torok@xxxxxxxxxx> wrote:

A better solution is being worked on for master,
but for now use ocamldep -sort instead of a manually established link
order.
The manually established link order will be wrong when (security)
patches introduce new dependencies between files that would require
changing the link order.

If dune was used as a build system this wouldn't be a problem, but we
can't use Dune yet due to OSSTest, which is stuck on Debian oldstable.

No functional change.

Signed-off-by: Edwin Török <edvin.torok@xxxxxxxxxx>
---
Reason for inclusion in 4.17:

Avoids having to put this patch as a prerequisite into a security update.
Earlier versions of XSA-326 needed this, and although latest version
didn't we don't know whether it might be needed again in the future or not.

Changes since v2:
- new in v3 (was previously emailed to security team though)
---
tools/ocaml/xenstored/Makefile | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)

Acked-by: Christian Lindig <christian.lindig@xxxxxxxxxx>


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.