[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH][4.17] kexec: restore hypercall 1st arg's type
- To: Jan Beulich <jbeulich@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>
- Date: Wed, 9 Nov 2022 20:11:39 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=I/GmRUIs0ZBdVCOdBUQ3r9oVmexp/wRq6r25pT5EQjs=; b=Ko2BJGrZd5iiq1g9UuunbyWXBcM4H98+0hFfA0ETx5IRvR4BUpStswfRV6i6iSp20roUiK1hGa8nRYKLe81Uf22DPuhwoGYkSudJAwpjuqghLP6rTGwKcbj6QD1/nf87NsDw8fQl/s2b2nhmyqTHzyqg3CrQy0zeDjy1fAsp8s25+QCkuUxPqlyXoXacnrzeMfuUoQNXlSMlfgrwyQ8UTHJ9SG2QBj6p/KPWF+YRmxjQYmriPyGEbEOpthUSO0e/susCA3tsStrzTxU0cte633TzFv2TBpbop64S5dZK8LW/q2eUfYqRH7w5lAiwLuJWqRgOpDtdsTk0IJ+tuPXVgQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=j0OtnUg7FQ0mP1QvoPFmb+aXaHX2y51tT9toOjgu7dKeVNbr+crGQ0vLquYg4M0YSBAWFOY2qXbd3xcrA+plW1Ye1ZS/BLtEFiGGrsxZbEzvjbEreaMmrUYqtOBLuDGxpvdxHZ66kCAPdJza7UQDaYcASJV2odVw98PjWA6NMOpde1KB9rWAJaMWfbggnfBJORHxivxYtDczIJZPTdUZSq7YGdZ33LSicMeVNftpql8tJWgUlb1eIyBryMeTmdr5goMsP6GZXpxz+4R8oDINlN9QWoJcF8gR/7950gUBtx2HrReqUg7LULwII+Ym021YJ9HL9VWYQZHtA4pGXGZAdQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: George Dunlap <George.Dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Henry Wang <Henry.Wang@xxxxxxx>
- Delivery-date: Wed, 09 Nov 2022 20:12:10 +0000
- Ironport-data: A9a23:jZqZiqLIS15LSFC9FE+RN5QlxSXFcZb7ZxGr2PjKsXjdYENS0jJRz GcYXm/TOK7eN2H1L4wkO9u08R5Q78eBndVrGgtlqX01Q3x08seUXt7xwmUcnc+xBpaaEB84t ZV2hv3odp1coqr0/0/1WlTZhSAgk/rOHv+kUrWs1hlZHWdMUD0mhQ9oh9k3i4tphcnRKw6Ws Jb5rta31GWNglaYCUpJrfPdwP9TlK6q4mlB5wRvPasjUGL2zBH5MrpOfcldEFOgKmVkNrbSb /rOyri/4lTY838FYj9yuu+mGqGiaue60Tmm0hK6aYD76vRxjnVaPpIAHOgdcS9qZwChxLid/ jnvWauYEm/FNoWU8AgUvoIx/ytWZcWq85efSZSzXFD6I+QrvBIAzt03ZHzaM7H09c5yUHtR7 NUHGAsrTTmYgdOxwYDkW+RV05FLwMnDZOvzu1lG5BSAVLMMZ8CGRK/Ho9hFwD03m8ZCW+7EY NYUYiZuaxKGZABTPlAQC9Q1m+LAanvXKmUE7g7K4/dnpTGNnGSd05C0WDbRUvWMSd9YgQCzo WXe8n6iKhobKMae2XyO9XfEaurnzX+mA9hMReDQGvhCg3CWm28CBj0tD3SL/eWVtVXud+puE hlBksYphe1onKCxdfH/VRClpH+PvjYHRsFdVeY97Wml2qfSpgqUGGUAZjpAc8A98t87QyQw0 V2ElM+vAiZg2JWXVHac+7G8vT60fy8PIgcqfjQYRAEI593ipoAbjR/VSNtnVqmvgbXdBjXY0 z2M6i8kiN07rcMNzbT9wlnBjBqlvJ2PRQkwjjg7RUqg5wJ9IYSjN4qh7AGC6e4addjJCF6co HIDhs6SqvgUCo2AnzCMR+NLG6y14/GCM3vXhlsH84QdyglBMkWLJeh4iAyS7m8wWirYUVcFu HPuhD4=
- Ironport-hdrordr: A9a23:cM6CHqN9T0FuHcBcT3n155DYdb4zR+YMi2TDiHoddfUFSKalfp 6V98jzjSWE8Ar5K0tQ4uxoWZPwCU80kKQY3WB/B8bHYOCLggqVxcRZnPLfKl7bambDH4xmpM BdmsFFYbWeY2SSz/yKhjVQeOxQo+VvhZrY4Ns2uE0dLz2CBZsB0y5JTiKgVmFmTghPApQ0UL CG4NBcmjamcXMLKuymG3gsRYH41pD2vaOjRSRDKw8s6QGIgz/twqX9CQKk0hAXVC4K6as+8F LCjxfy6syYwr2GI17npiDuBqZt6ZrcI+h4dYyxYw8uW3bRYzOTFcpcsnu5zXIISa+UmRMXeZ L30m0d1oxImg7slyeO0FHQMkDboUoTwm6nxlmCjXT5p8vlADo8FspanIpcNgDU8kw6obhHod V2Nk+ixu9q5Cn77VDAzsmNUwsvmlu/oHIkn+JWh3tDUZEGYLsUqYAE5ktaHJoJASq/sekcYa BTJdCZ4OwTfUKRbnjfsGUqyNuwXm4rFhPDRkQZoMSa3zVfgXg8xUoFw84UmGsG6fsGOu95zv WBNr4tmKBFT8cQY644DOAdQdGvAmiIWh7IOHL6GyWUKEjGAQO/l3fa2sRF2AjxQu128HIbou W+bHpI8WgvZknpFcqCmJVW7xGlehTMYQjQ
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHY8rrxB22D+mhDmkyvs7CT99N0gq43CX2A
- Thread-topic: [PATCH][4.17] kexec: restore hypercall 1st arg's type
On 07/11/2022 15:09, Jan Beulich wrote:
> This reverts a small part of 7e21b25059ed ("xen: harmonize return types
> of hypercall handlers"). The change from "unsigned long" to "unsigned
> int" for the native handler function meant that previously invalid
> values became valid. While perhaps not a significant issue, strictly
> speaking that's still a change to the ABI. Don't go as far as restoring
> the compat entry point's type though: That one can't have values passed
> which don't fit in 32 bits.
>
> Note that as a side effect this fixes the invocation of
> hypercall_create_continuation(), which by mistake wasn't adjusted by the
> earlier change.
>
> Also take the opportunity and correct the respective comment in the
> public header. (The way it was it really supports that it probably was
> pointless to use "long", but that's the way the hypercall was
> introduced.)
>
> Requested-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
Thankyou for fixing this.
Acked-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
|
