[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 2/2] x86: Check return values from early_ioremap calls
- To: Peter Zijlstra <peterz@xxxxxxxxxxxxx>
- From: Ross Philipson <ross.philipson@xxxxxxxxxx>
- Date: Thu, 10 Nov 2022 14:31:45 -0500
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/sM/RPyc7Kd7E67aKBnYNlDIEac+lgJDXcu0AB5D5GA=; b=WAN3PBHBzpFlRLkNzQZUiRyisBB/X0tf2DD80KNTJRdKSHwBI7BqKpocBOm2SEXOFJEspleVQDizLHPbv/Chv/Deo51vJOoFI8QvY4lAfMaLoiHmujIKFHb1atbcOtf1rHfVVQd5jq61zEI5h3u2pUH4ZeGqqXZXsS6bloAGWX/K4Gw+nM/9EIsT4yFw1npf3PDwQhgVdPqH6jj9maHhszQgy36M0T0wBAysONjOqD/03qWIc2EJIsIQYDkeCkYMs+w4lucfHXOiqvc3IjfLJUfRP64yScEH87RYud4yM7DJ7TIuD8wzTBdUdpg5i+oJfQWIc+JRMKFAOcgdmqZKHQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QTWqO1T0XTQ1DiTZ4DytNiqkkRwlYZw9rbw6IeQpUfuQ+6J8L3/NqUkd9CTDbfx4TnZePYh2jfmIbba+O9w9cCldlJRIFNZAcXqyleOnlqINzdelZBW/gqaMSN/rDRt5CYdH1MvsTPyvd31vu3JM6VFU6uQyViwO9/waQ+6rOJvI0tSkNCRpzBj7LNb1q4Ht3irEOJ5klqW6CrJEyfPxwwLV76b6g4GhkYlt0AotQm00CRFf3de5eN6BrdpH9V6u5OIbO6svsFISeU7IU7mDFcMsmsdYxldw25aoZAIm2O/mvTGMWmLHjhzs4ebbz9G8R7GyZzSTnEB53kb4tRXI/A==
- Cc: linux-kernel@xxxxxxxxxxxxxxx, x86@xxxxxxxxxx, dpsmith@xxxxxxxxxxxxxxxxxxxx, tglx@xxxxxxxxxxxxx, mingo@xxxxxxxxxx, bp@xxxxxxxxx, hpa@xxxxxxxxx, luto@xxxxxxxxxxxxxx, dave.hansen@xxxxxxxxxxxxxxx, kanth.ghatraju@xxxxxxxxxx, trenchboot-devel@xxxxxxxxxxxxxxxx, jailhouse-dev@xxxxxxxxxxxxxxxx, jan.kiszka@xxxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxxx, jgross@xxxxxxxx, boris.ostrovsky@xxxxxxxxxx, andrew.cooper3@xxxxxxxxxx
- Delivery-date: Thu, 10 Nov 2022 19:32:23 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 11/10/22 13:07, Peter Zijlstra wrote:
On Thu, Nov 10, 2022 at 03:45:21PM +0000, Ross Philipson wrote:
On allocation failures, panic() was used since this seemed
to be the action taken on other failures in the modules
touched by this patch.
How is the panic() more useful than the obvious NULL deref that also
splats?
My answer here is basically the same as the answer in the reply to Dave
Hansen I sent a moment ago. I think one of the primary motivation was to
make things consistent.
Thanks
Ross
|
