[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [[PATCH for-4.17 v1]] tools/ocaml/xenstored/xenstored.ml: fix incorrect scope
- To: Edwin Torok <edvin.torok@xxxxxxxxxx>
- From: Christian Lindig <christian.lindig@xxxxxxxxxx>
- Date: Fri, 11 Nov 2022 08:47:57 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qfyL22txZXfv/J2TntjZ5eSLwm+hAxB0tQgn76UqQbg=; b=hzbk63mQgVjorUqV7hmSgsOo6IvR2/tWFBZ++EUpPq6EhYQeQXQh755AHyRWzMvCaygpP8UfNFXqwM9Y35gu2QmhraEFK7rRhmTpx0715KywY0agZ7JD6r7eTjYCG+eMInz/XjpJwxDNTMZjek/tgs4X4VtBtT89zMFDmwMBwWVxlPSAJLpqRJvnsWN3JnSq8TFAvBg5OOCqGSxnUOQyK3GwrIMDhVO0/j6U5yGUEmqIVFnRBLImLvzqZglsIFoufs4WNAyWDbc3njUVkf52wsTn7KU6W0GTAlPsfRiTBeDPc4ZelaaQebtZrs5dYG75/Nj6hRzkssEuhqyXO0jw7A==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bZn9AsSVi7iJnxyYIpyysm1hM2X+rFnuLVQNwQpzNca0RgxIcNR+47qI/tQ+1Jaiw02sEgBDPe148dbxrUyw3X/qvGBCrYmKWkCsCYXSOlqhDJkoaXw2QiH/42Z7TGu4ivTnqBAwSJ6ZYZGUbeP2148SMWIEZtiyp+bLJBvPNt2EboOV5b8oCzGHW3XZtesft9c5866Er/cjoIhzeq8zRR3K23Rxl8aPsbH2CMvtL367SbYkcnV8LANVmKJkYP5rCl66/qZgh4e9kpWxbY6n2KxTMWzVEETPzaUUs+6ecTDbrVWNwlBPURmEpRm6nbxlvlFsDy8zaPhTCHcAWtdCPg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Henry Wang <Henry.Wang@xxxxxxx>, David Scott <dave@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Anthony Perard <anthony.perard@xxxxxxxxxx>
- Delivery-date: Fri, 11 Nov 2022 08:49:49 +0000
- Ironport-data: A9a23:h88Dtq2GSpBd571Y7fbD5epwkn2cJEfYwER7XKvMYLTBsI5bpzUPz 2MbWDiAO6mINDDyKN11bou2pkwG6J7QnN9nHgJopC1hF35El5HIVI+TRqvS04F+DeWYFR46s J9OAjXkBJppJpMJjk71atANlVEliefTAOK5ULSfUsxIbVcMYD87jh5+kPIOjIdtgNyoayuAo tq3qMDEULOf82cc3lk8tuTS9nuDgNyo4GlC5wVnPKgS1LPjvyJ94Kw3dPnZw0TQGuG4LsbiL 87fwbew+H/u/htFIrtJRZ6iLyXm6paLVeS/oiI+t5qK23CulQRrukoPD9IOaF8/ttm8t4sZJ OOhF3CHYVxB0qXkwIzxWvTDes10FfUuFLTveRBTvSEPpqFvnrSFL/hGVSkL0YMkFulfQj9nr vZHKAs3bh3dvaW95ZeWF+BrmZF2RCXrFNt3VnBI6xj8VapjbbWdBqLA6JlfwSs6gd1IEbDGf c0FZDFzbRPGJRpSJlMQD5F4l+Ct7pX9W2QA9BTJ+uxouC6PnWSd05C0WDbRUteKX8ROgkeRo CTC/mL1Ax4yP92D0zuVtHmrg4cjmAurA91KTeTpqpaGhnXN/3AuEhlIR2G3pKSckWK7ZfFge 1ILr39GQa8asRbDosPGdw21pjuIswARX/JUEvYm80edx6zM+QGbC2MYCDlbZ7QOlMIwXy1s6 VaPkPvgHzkpu7qQIVqR/6mZhSm/Mi8UKSkFfyBsZRQBy8nupsc0lB2nczp4OKu8j9mwFTSux TmP9HQ6n+9L0Z9N0Lin91fahT7qvoLOUgM++gTQWCSi8x99Y4mmIYev7DA38Mp9EWpQdXHZ1 FBspiRUxLlQU/lhSATlrD0xIYyU
- Ironport-hdrordr: A9a23:oJP/FaF2EQy2x9UrpLqFS5HXdLJyesId70hD6qkvc3Fom52j/f xGws5x6fatskdrZJkh8erwW5Vp2RvnhNNICPoqTM2ftW7dySeVxeBZnMHfKljbdxEWmdQtsp uIH5IeNDS0NykDsS+Y2nj2Lz9D+qjgzEnAv463oBlQpENRGthdBmxCe2Sm+zhNNW177O0CZf +hD6R8xwaISDAyVICWF3MFV+/Mq5ngj5T9eyMLABYh9U2nkS6owKSSKWnY4j4uFxd0hZsy+2 nMlAL0oo+5teug9xPa32jPq7xLhdrazMdZDsDksLlUFtyssHfqWG1SYczGgNkHmpDq1L/sqq iKn/4UBbUw15oWRBDynfKi4Xi47N9k0Q6e9bbRuwqenSW+fkN1NyMJv/MmTjLJr0Unp91yy6 RNwiaQsIdWFwrJmGDn68HPTAwCrDv8nZKz+dRj8EC3fLFuH4O5l7Zvin99AdMFBmb3+YonGO 5hAIXV4+tXa0qTazTcsnN0yNKhU3wvFlPeK3Jy8fC9wnxThjR03kEYzMsQkjMJ8488UYBN46 DBPr5znL9DQ8cKZeZ2BfsHQ8GwFmvRKCi8eF66MBDiDuUKKnjNo5n47PE84/yrYoUByN8olJ HIQDpjxBoPkoLVeLizNbFwg2PwqT+GLEXQI+llluhEk6y5Qqb3OiueT11rm9e8opwkc7/mZ8 o=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHY9TJA3NadmOqYwUG//a2f83zQw645ajKA
- Thread-topic: [[PATCH for-4.17 v1]] tools/ocaml/xenstored/xenstored.ml: fix incorrect scope
> On 10 Nov 2022, at 18:28, Edwin Török <edvin.torok@xxxxxxxxxx> wrote:
>
> A debug statement got introduced and code not reindented
> (as it was part of a security fix and was trying to avoid that),
> however that resulted in *only* the debug statement being part of the 'if',
> and everything else outside of it.
> This results in some unnecessary ring checks for domains which otherwise
> have IO credit.
>
> Remove the debug line.
>
> Fixes: 42f0581a91 ("tools/oxenstored: Implement live update for socket
> connections")
>
> Signed-off-by: Edwin Török <edvin.torok@xxxxxxxxxx>
> ---
> Reason for inclusion in 4.17:
> - bugfix for commit already in master
Acked-by: Christian Lindig <christian.lindig@xxxxxxxxxx>
|
