[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] xen-pciback: Allow setting PCI_MSIX_FLAGS_MASKALL too
- To: Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Mon, 14 Nov 2022 11:55:09 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=A+l3sX5ll1BOtoYQOTgBV4AShXzgXANvr9yYhrIbgTY=; b=k4xx7YJRzvdxXxU9P8PuN+swvSVBdy+JPen0YWxJtDDyDbmKgB2o0nxj5WJUlAYhW4plLlisJm9l8CBlyE+Ii9ae+s7Vifc5l3tVAIS7DgL2EywF2FDzxIFntatlzz+s88qU9xizLznkT8xVUG4maMP30h2GPR0asfc6w+vGtH8IiVBVWh9J+0b7PXPqirp6EufWi85bO9ZBI11op7txl4qk7sdkdKKexPpsu8agpQhcnGtaGW6QSVFLzzvMwyfZG9wtvc8SselSz8bNOpbeHFzs+GJJn+bs4wJjyDTPjYSmQenvFRvpHYJT8D0/B9vkZVPaYY7dad26gM9Xx7MklQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TEt/uPzLIKdkVBat7FUApZ/jbril+zNw9+1fLw7PpZU5GZ+WCEo4CTLnxoXouHlkk5cqHgdLFxr0aU9uZPn1BDrHClF3CiCqyvODDd5SUUvFG69gVFuULvjb/KV8mlpMCEMlfMFmK3Re3jcZ4zcjnojqiyCf/+7ftkdaV9QLCL/uhJrvT7V07OdAZnsHlTvpZbGdqCn5Wg58rOC08nvLUJcgmxOAvA/HJ/UYBlTc+TRrwfeTbRQJx2iahLA61us9//aLrlTiiXBbY0jPnouGaSbs6R57Ln+YsU5IEvUyJSDwfu6DtIUMh6MgXCfzVWlXTCSj9OygIm/LbYZh/jM/XQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Juergen Gross <jgross@xxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Oleksandr Tyshchenko <oleksandr_tyshchenko@xxxxxxxx>, "moderated list:XEN HYPERVISOR INTERFACE" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx
- Delivery-date: Mon, 14 Nov 2022 10:55:19 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 14.11.2022 11:31, Marek Marczykowski-Górecki wrote:
> When Xen domain configures MSI-X, the usual approach is to enable MSI-X
> together with masking all of them via the config space, then fill the
> table and only then clear PCI_MSIX_FLAGS_MASKALL. Allow doing this via
> QEMU running in a stub domain.
>
> Previously, when changing PCI_MSIX_FLAGS_MASKALL was not allowed, the
> whole write was aborted, preventing change to the PCI_MSIX_FLAGS_ENABLE
> bit too.
>
> Note the Xen hypervisor intercepts this write anyway, and may keep the
> PCI_MSIX_FLAGS_MASKALL bit set if it wishes to. It will store the
> guest-requested state and will apply it eventually.
>
> Signed-off-by: Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx>
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
|
