[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [XEN PATCH for-4.17 v2 3/6] tools/include/xen-foreign: Add SPDX identifier to generated headers


  • To: Anthony Perard <anthony.perard@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>
  • Date: Wed, 16 Nov 2022 14:59:59 +0000
  • Accept-language: en-GB, en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FvknJ0yAruidXDMf8KU8J9heSHlajwBLWf4Q6KG4qyA=; b=N1w7lDvs0nSTb9ir4de2yv3YwS6qikXK0z/geriVb7ZUqLzJNVIf3vk7rSa4mosYtMV66vcVp6b+FJtOtOgTHKA7TiCXqG4+Y6nu+YYDMEyKWidXOnPDLFmO2KEbebPfa8sQ9Kkv+3/uRIdIeQnxzXqSDuqFYB4nkBY58UpoDqfrM5zHGyRRwfCQ2sYXmYCn9WlTqEtk7+GcjDkBgHIqooD89MV/piLJTDXlEEZ7wiI0/3wkgHUkfRbcxzaRpcsatCw1Myto58p6pkcOPbbuE32KCIYX3NVgAlLVhSL8fazVIvtt/MVzLLpUGmqMv5g/feAd30mwJiKSyhPXVWAiiQ==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DN6rAATPpdYNa/80HUX+NrS+z26ekqC4fVB4nwRcPFNo4qICOY+Mf16d4rUiww4Ii0T+FnhqVtVc7zHmzj5spyOE51YCFsH2K2+xwQPjaLxKxaHI7y6s3ct/vP/BnygxGdx+sPjy0f7WYZWqwV86Cej4aJRmbFZuGOCsn5E+mo1Ssv2ky+fHuXNS8BtxFTrVXFtotCz6g4VNLboT/VIjXt6mdm8bha9N9hc+dD+A9NcPcpgIuxo+Crd0HJ/n2GDZjn4zKBOKAEqBB2QNZ5+s2NIGIsAfYutS7CvUAWx/uUvGEUr0BYe2x2lYvTabvVb38fBJFL5yRIXUsu/gFxWDmg==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
  • Cc: Wei Liu <wl@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, George Dunlap <George.Dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Henry Wang <Henry.Wang@xxxxxxx>
  • Delivery-date: Wed, 16 Nov 2022 15:00:26 +0000
  • Ironport-data: A9a23:UsTdOqKAqJGD8HnyFE+RN5QlxSXFcZb7ZxGr2PjKsXjdYENShmACz 2UaCDjSOKuIYmHxfI11PNiy9h5VvJaBnIc2GwJlqX01Q3x08seUXt7xwmUcnc+xBpaaEB84t ZV2hv3odp1coqr0/0/1WlTZhSAgk/rOHv+kUrWs1hlZHWdMUD0mhQ9oh9k3i4tphcnRKw6Ws Jb5rta31GWNglaYCUpJrfPdwP9TlK6q4mlB5wVgPakjUGL2zBH5MrpOfcldEFOgKmVkNrbSb /rOyri/4lTY838FYj9yuu+mGqGiaue60Tmm0hK6aYD76vRxjnVaPpIAHOgdcS9qZwChxLid/ jnvWauYEm/FNoWU8AgUvoIx/ytWZcWq85efSZSzXFD6I+QrvBIAzt03ZHzaM7H09c5XWGdq0 MIoNAoBb02Z3MKQ0vGfZ9Zz05FLwMnDZOvzu1lG5BSAVLMKZM6GRK/Ho9hFwD03m8ZCW+7EY NYUYiZuaxKGZABTPlAQC9Q1m+LAanvXKmUE7g7K4/dopTGMkmSd05C0WDbRUvWMSd9YgQCzo WXe8n6iKhobKMae2XyO9XfEaurnzX+qBNxKSeHQGvhCiQO85EsDJSMsdEaaoameyV+seOpiE hlBksYphe1onKCxdfHtUhv9rHOasxo0X9tLD/Z8+AyL0rDT4QuSGi4DVDEpQMMinN87Q3otz FDht8jyGTVlvbmRSHSc3rSZtzW/PW4SN2BqTS0ZSQoI5fHzrYd1iQjAJv5hGqOoitz+GRnr3 iuH6iM5gt07rcMNzbT9wlnBjBqlvJ2PRQkwjjg7RUqg5wJ9IYKgOYqh7AGC6e4addnHCF6co HIDhs6SqvgUCo2AnzCMR+NLG6y14/GCM3vXhlsH84QdyglBMkWLJeh4iAyS7m8zWirYUVcFu HPuhD4=
  • Ironport-hdrordr: A9a23:rLhC+KGn4eMBa819pLqFwJLXdLJyesId70hD6qkvc3Fom52j/f xGws5x6fatskdrZJkh8erwW5Vp2RvnhNNICPoqTM2ftW7dySeVxeBZnMHfKljbdxEWmdQtsp uIH5IeNDS0NykDsS+Y2nj2Lz9D+qjgzEnAv463oBlQpENRGthdBmxCe2Sm+zhNNW177O0CZf +hD6R8xwaISDAyVICWF3MFV+/Mq5nik4/nWwcPA1oK+RSDljSh7Z/9Cly90g0FWz1C7L8++S yd+jaJp5mLgrWe8FvxxmXT55NZlJ/IzcZCPtWFjow4OyjhkQGhYaVmQvmnsCouqO+ixV42mJ 3nogsmPe5093TNF1vF7yfF6k3F6nID+nXiwViXjT/IusriXg83DMJHmMZwbgbZw1BIhqA+7I t7m0ai87ZHBxLJmyrwo/LSUQtxq0ayqX0+1cYOkn1kV5cEYrM5l/1cwKoVKuZEIMvJ0vFhLA BcNrCb2B+QSyLCU5nthBgq/DVrZAVqIv7JeDlYhiXf6UkqoJkw9Tpl+CVYpAZByHt1ceg72w yPWJ4Y641mX4sYa7lwC/wGRtbyAmvRQQjUOGbXOlj/ErobUki94qIfzY9Fk91CQqZ4uqcaid DEShdVpGQyc0XhBYmH24BK6AnERCG4US72ws9T6pBlsvmkLYCbehGrWRQriY+tsv8fCsrUV7 K6P49XGebqKS/rFZxS1wPzVpFOIT0VUdETuNw8R1WSy/i7YrHCp6jearLeNbDtGTErVif2BW YCRiH6IIFa4kWiShbD8WzssrPWCznCFL5LYdvnFrIoufkw36V3w3gooEX84N2XIjtftaFzdF diIdrc49GGmVU=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Thread-index: AQHY73rFw2EypUFm0USU279+Ma36zq5BuTuA
  • Thread-topic: [XEN PATCH for-4.17 v2 3/6] tools/include/xen-foreign: Add SPDX identifier to generated headers

On 03/11/2022 11:52, Anthony PERARD wrote:
> diff --git a/tools/include/xen-foreign/mkheader.py 
> b/tools/include/xen-foreign/mkheader.py
> index fb268f0dce..ec8a321395 100644
> --- a/tools/include/xen-foreign/mkheader.py
> +++ b/tools/include/xen-foreign/mkheader.py
> @@ -1,5 +1,6 @@
>  #!/usr/bin/python
>  
> +from __future__ import print_function
>  import sys, re;
>  from structs import unions, structs, defines;
>  
> @@ -114,23 +115,37 @@ input  = "";
>  output = "";
>  fileid = re.sub("[-.]", "_", "__FOREIGN_%s__" % outfile.upper());
>  
> -# read input header files
>  for name in infiles:
>      f = open(name, "r");
> +    # Check the licence of the input file, only SPDX identifier is accepted 
> by
> +    # this script.
> +    line = f.readline()
> +    if not line == "/* SPDX-License-Identifier: MIT */\n":

!=

> +        print("%s: Error: %s is missing SPDX identifier" % (sys.argv[0], 
> name), file=sys.stderr)

I've reworked this a little to provide more information in the case that
something actually goes wrong.

xen.git/tools/include/xen-foreign$ make all
python3 mkheader.py arm32 arm32.h.tmp
/local/xen.git/tools/include/xen-foreign/../../../xen/include/public/arch-arm.h
/local/xen.git/tools/include/xen-foreign/../../../xen/include/public/xen.h
mkheader.py
/local/xen.git/tools/include/xen-foreign/../../../xen/include/public/xen.h:
Error: Missing or unexpected SPDX tag '/* SPDX-Licens-Identifier: MIT */'
Makefile:29: recipe for target 'arm32.h' failed
make: *** [arm32.h] Error 1

~Andrew

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.