[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN v3 02/12] xen/Arm: GICv3: Adapt access to VMPIDR register for AArch32
- To: Ayan Kumar Halder <ayan.kumar.halder@xxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Michal Orzel <michal.orzel@xxxxxxx>
- Date: Thu, 17 Nov 2022 14:39:58 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=avVnQD7ww8knOGhKoIuyVz3Zx0k6lSvfIXELF6snUSk=; b=GO6l0BEZYg3TS4IuTD3WJjlxi546Cz8S33DuEcvzrCEsjUPftQQYakmCX6IFu7XURlD++ezBEM0xVyXfPPt3vHVrDcS/l6mtYEcm6c0AWjZEGtSW8nmaC/Edx5NfRtvAerT5/qHF8kuVEQUMq0SH0bnczejU3jY6jotZiztqmtsY9obZ1rC12LlojkxnAnkVZBipQcXHTGqqouPLO3BOz1RxZR3Oru9UB+4msuoGtQRp+ISJrafv3/tgyCKSQoPuiEfNON2BQ56bdtNIfuhT2oTdM4an7i8OuYtUZjgND1DmWZjObaP1uEMDa/1NNnO2xPr0Iv7BkUnARLNk4OiXIA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aSqRTt4fmQ4iCaITyfhpXRna5vOA2XSigjLfYTfyCZm5Y+vFFVx6SelbcJGV8WqcEU+egGNLgC07ex4iDufTm5LZcxkVdsZt28hmHW48IWTILxzzL4kz0j4xYAgyfcCk73xbNY8brcqVDnxTQaTcR4UirVB+DfS60GEmpsihIi0W4HSqYKQ3D8BNfYXlRaGxcQVOYEYNzKwNaE9SWc0EhubbUxZEYRuOh+MGeLFZx7q9HrNc8cb4sH0rt/4sh7zh3JDS76xZ/Pmd2+XQkX2t5X+qqPH5pnAw6Vs9VVi8kFEYY7cd/BnVid8bfQuNzzitwrzubv3SJVbcdBcZnpiYrQ==
- Cc: <sstabellini@xxxxxxxxxx>, <stefanos@xxxxxxxxxx>, <julien@xxxxxxx>, <Volodymyr_Babchuk@xxxxxxxx>, <bertrand.marquis@xxxxxxx>, <jgrall@xxxxxxxxxx>, <burzalodowa@xxxxxxxxx>
- Delivery-date: Thu, 17 Nov 2022 13:40:18 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
Hi Ayan,
On 11/11/2022 15:17, Ayan Kumar Halder wrote:
> Refer ARM DDI 0487I.a ID081822, G8-9817, G8.2.169
> Affinity level 3 is not present in AArch32.
> Also, refer ARM DDI 0406C.d ID040418, B4-1644, B4.1.106,
> Affinity level 3 is not present in Armv7 (ie arm32).
> Thus, any access to affinity level 3 needs to be guarded within
> "ifdef CONFIG_ARM_64".
>
> Signed-off-by: Ayan Kumar Halder <ayan.kumar.halder@xxxxxxx>
Reviewed-by: Michal Orzel <michal.orzel@xxxxxxx>
although, IMO the commit msg does not reflect the change (i.e. you do nothing
related to accessing MPIDR, but instead you are just not taking the Aff3 into
account for AArch32).
Also, I'm not sure why you used VMPIDR and not MPIDR.
~Michal
|
