[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 3/4] xen/arm, libxl: Revert XEN_DOMCTL_shadow_op; use p2m mempool hypercalls
- To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- From: Anthony PERARD <anthony.perard@xxxxxxxxxx>
- Date: Thu, 17 Nov 2022 14:07:59 +0000
- Authentication-results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
- Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Jan Beulich <JBeulich@xxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Henry Wang <Henry.Wang@xxxxxxx>
- Delivery-date: Thu, 17 Nov 2022 14:08:26 +0000
- Ironport-data: A9a23:vMwkW6CxvfwgsRVW/97jw5YqxClBgxIJ4kV8jS/XYbTApGkmhGZRz zQfW2GHPfiMazT2LtB0b47g8BxVvJbQmNNgQQY4rX1jcSlH+JHPbTi7wuUcHAvJd5GeExg3h yk6QoOdRCzhZiaE/n9BCpC48T8nk/nNHuCnYAL9EngZbRd+Tys8gg5Ulec8g4p56fC0GArIs t7pyyHlEAbNNwVcbyRFtcpvlDs15K6o4WpB4QRkDRx2lAS2e0c9Xcp3yZ6ZdxMUcqEMdsamS uDKyq2O/2+x13/B3fv8z94X2mVTKlLjFVDmZkh+AsBOsTAbzsAG6Y4pNeJ0VKtio27hc+ada jl6ncfYpQ8BZsUgkQmGOvVSO3kW0aZuoNcrLZUj2CA6IoKvn3bEmp1T4E8K0YIw5/9vLUdPz /oiLBM2fCKCmM29kJm4Y7w57igjBJGD0II3v3hhyXfSDOo8QICFSKLPjTNa9G5u3IYUR6+YP pdHL2o0BPjDS0Qn1lM/AZQinOCulz/nfidRsl69rqsr+WnDigd21dABNfKFJ4TQFJwIxy50o Err3XrdPE5GKeez0D6GwkChl77Ptnj0Ddd6+LqQqacx3Qz7KnYoIB8LUVq2p9Gph0j4XMhQQ 2QP4TYnp6U28E2tT/H+Uge+rXrCuQQTM/JuFOk95BCI27DjyQ+TDWgZTRZMcNUj8sQxQFQC9 lKPhcKvOjVpv5WcU3fb/bCRxRu4NDIJN2YEaWkBRBEc/tj4iIgpi1TESdMLOL64iJj5FC/9x xiOrTMinPMDgMgTzaK58FvbxTW2qfDhbCQ4+wHWVWKN9R5iaciuYInAwUffxeZNKsCeVFbpg ZQfs5HAtqZUV8jLzXHTBrVWdF202xqbGCDFmXJJHqMnzTCOwGyRfJ9/62FVJ248Z67oZgTVS EPUvApQ4rpaM32rcbJ7buqNNig68UTzPY+7D66JN7KidrA0LVbap382OSZ8yki3yCARfbcD1 YB3mCpGJVITEuxZwTW/XI/xOpd7l3lllQs/qX0WpilLMIZyhlbPF9/p03PUNIjVCZ9oRy2Lm +uzz+PQl31ivBTWO0E6Mec7dDjm10QTC5HssNBwfeWeOAdgE2xJI6aPn+N/Idc5wP4Lyb2gE pSBtqlwkwOXaZrvcFviV5yeQOm3AcYXQYwTYETAwmpEK1B8ON3yvc/zhrM8fKU99fwL8BKHZ 6BtRihBa9wRIgn6F8M1N8ih8tM/KU/z32pj/UONOVACQnKpfCSRkveMQ+cl3HBm4vaf3Sfmn 4Cd6w==
- Ironport-hdrordr: A9a23:XbrnQawkNawxqmJC51o+KrPwLL1zdoMgy1knxilNoRw8SKKlfu SV7ZAmPH7P+VMssR4b9OxoVJPtfZqYz+8T3WBzB8bBYOCFgguVxehZhOOIqQEIWReOldK1vZ 0QFZSWY+eQMbEVt6nH3DU=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Thu, Nov 17, 2022 at 01:08:03AM +0000, Andrew Cooper wrote:
> diff --git a/tools/libs/light/libxl_dom.c b/tools/libs/light/libxl_dom.c
> index 2abaab439c4f..f8f7b7e81837 100644
> --- a/tools/libs/light/libxl_dom.c
> +++ b/tools/libs/light/libxl_dom.c
> @@ -1448,6 +1448,25 @@ int libxl_userdata_unlink(libxl_ctx *ctx, uint32_t
> domid,
> return rc;
> }
>
> +int libxl__domain_set_p2m_pool_size(
> + libxl__gc *gc, libxl_domain_config *d_config, uint32_t domid)
> +{
> + libxl_ctx *ctx = libxl__gc_owner(gc);
> + uint64_t shadow_mem;
> +
> + shadow_mem = d_config->b_info.shadow_memkb;
> + shadow_mem <<= 10;
> +
> + int r = xc_set_paging_mempool_size(ctx->xch, domid, shadow_mem);
Nit: 'ctx' could be replace by using the macro 'CTX', without having to
declare a local ctx variable.
With or without this changed, patch looks fine:
Reviewed-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>
Thanks,
--
Anthony PERARD
|
