Re: [XEN PATCH for-4.17] libs/light: Propagate libxl__arch_domain_create() return code

[Jason Andryuk <jandryuk@xxxxxxxxx>]

On Fri, Nov 18, 2022 at 11:53 AM Anthony PERARD
<anthony.perard@xxxxxxxxxx> wrote:
>
> Commit 34990446ca91 started to overwrite the `rc` value from
> libxl__arch_domain_create(), thus error aren't propagated anymore.
>
> Check `rc` value before doing the next thing.
>
> Fixes: 34990446ca91 ("libxl: don't ignore the return value from 
> xc_cpuid_apply_policy")
> Reported-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> Signed-off-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>

Was the issue that libxl__arch_domain_create() failed, but then
libxl__cpuid_legacy() succeeded.  rc was overwritten, so
libxl__build_pre() returns success?

Reviewed-by: Jason Andryuk <jandryuk@xxxxxxxxx>

Thanks,
Jason