[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/2] tools/libxl: Fixes to libxl__domain_set_paging_mempool_size()
- To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- From: Anthony PERARD <anthony.perard@xxxxxxxxxx>
- Date: Mon, 21 Nov 2022 14:45:41 +0000
- Authentication-results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
- Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Henry Wang <Henry.Wang@xxxxxxx>
- Delivery-date: Mon, 21 Nov 2022 14:45:59 +0000
- Ironport-data: A9a23:4A6xKKASqVpeLBVW/0Xjw5YqxClBgxIJ4kV8jS/XYbTApDsi0zwPm DdMWzqBbvfYY2L1Ld0nad+z9RwP7ZTXm9JhQQY4rX1jcSlH+JHPbTi7wuUcHAvJd5GeExg3h yk6QoOdRCzhZiaE/n9BCpC48T8nk/nNHuCnYAL9EngZbRd+Tys8gg5Ulec8g4p56fC0GArIs t7pyyHlEAbNNwVcbyRFtcpvlDs15K6o4WpC5wRnDRx2lAS2e0c9Xcp3yZ6ZdxMUcqEMdsamS uDKyq2O/2+x13/B3fv8z94X2mVTKlLjFVDmZkh+AsBOsTAbzsAG6Y4pNeJ0VKtio27hc+ada jl6ncfYpQ8BZsUgkQmGOvVSO3kW0aZuoNcrLZUj2CA6IoKvn3bEmp1T4E8K0YIwpMl7H2JQx 80hCTUjbQy6jb7nz5GLY7w57igjBJGD0II3v3hhyXfSDOo8QICFSKLPjTNa9G5u3IYUR6+YP pdHL2o0BPjDS0Qn1lM/AZQinOCulz/nfidRsl69rqsr+WnDigd21dABNfKFJ4bVGJoNwy50o ErP5yPGMyARF+eylyTcwCiLg/XwnSTCDdd6+LqQqacx3Qz7KnYoID0bU0Gq58awjEGWUshab UcT/0IGvaU0sUCmUNT5dxm5u2Kf+A4RXcJKFO834x3LzbDbizt1HUBdEGQHMoZ/8pZrG3p6j Tdlgu8FGxQxn7GLSmyvx461qB2xJREfcT4NRh8tGF5tD8bYnKk/iRfGT9BGGaGzj8HoFTyY/ w1mvBTSlJ1I05dVivzTEUTvxmv1+8OXFlJdChD/BDrN0+9vWGKyi2VEA3D/5O0IEouWR0LpU JMsy5nHt7Bm4X1geUWwrAQx8FKBvazt3NjgbblHQfEcG8yFoSLLQGypyGgWyYcAGp9slcXVS EHSoxhNw5RYIWGna6R6C6roVZp6nPaxT4+5CKiIBjarXnSWXFbWlByCmGbKhzy9+KTSufxX1 WinnTaEUi9BVPUPIMueTOYBy747rh3SNkuKLa0WDn2Pj9KjWZJiYe1bawTfNrxlsv7sTce82 483CvZmAi53CIXWChQ7O6ZKRbzWBRDX3azLlvE=
- Ironport-hdrordr: A9a23:T9rmQ60oZozy3oES/ygvtAqjBLAkLtp133Aq2lEZdPRUGvb4qy mLpoV96faUskd0ZJhOo7y90cW7Lk80sKQFh7X5Xo3SOTUO2lHYT72KhLGKq1aLdhEWtNQtt5 uIG5IOceEYZmIbsS+V2meFL+o=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Mon, Nov 21, 2022 at 02:37:30PM +0000, Andrew Cooper wrote:
> The error message accidentally printed the bytes value as if it were kB.
>
> Furthermore, both b_info.shadow_memkb and shadow_mem are uint64_t, meaning
> there is a risk of overflow if the user specified a stupidly large value in
> the vm.cfg file. Check and reject such a condition.
>
> Fixes: 7c3bbd940dd8 ("xen/arm, libxl: Revert XEN_DOMCTL_shadow_op; use p2m
> mempool hypercalls")
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> ---
>
> v2:
> * Retain PRIu64
> * Check for overflow
>
> For 4.17. This is a low risk change, removes one overflow case, and makes an
> error message accurate.
Reviewed-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>
Thanks,
--
Anthony PERARD
|
