[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH 0/8] Oxenstored live update fixes


  • To: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • Date: Tue, 22 Nov 2022 15:20:35 +0000
  • Authentication-results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
  • Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Christian Lindig <christian.lindig@xxxxxxxxxx>, David Scott <dave@xxxxxxxxxx>, Edwin Torok <edvin.torok@xxxxxxxxxx>, Rob Hoes <Rob.Hoes@xxxxxxxxxx>
  • Delivery-date: Tue, 22 Nov 2022 15:21:11 +0000
  • Ironport-data: A9a23:xGDM26P4ItuxAGvvrR33l8FynXyQoLVcMsEvi/4bfWQNrUoigzBRz 2YdCm6Fa/+JYmX3eYhyPIzn9BkBu8TSyIUxHgto+SlhQUwRpJueD7x1DKtS0wC6dZSfER09v 63yTvGacajYm1eF/k/F3oDJ9CU6jufQA+KmU4YoAwgpLSd8UiAtlBl/rOAwh49skLCRDhiE/ Nj/uKUzAnf8s9JPGj9SuvzrRC9H5qyo4mpB5AZmOZingXeF/5UrJMNHTU2OByOQrrl8RoaSW +vFxbelyWLVlz9F5gSNy+uTnuUiG9Y+DCDW4pZkc/HKbitq/0Te5p0TJvsEAXq7vh3S9zxHJ HehgrTrIeshFvWkdO3wyHC0GQkmVUFN0OevzXRSLaV/ZqAJGpfh66wGMa04AWEX0tlVKDxCz +VGE28cXAGNgf+P76K4dfY506zPLOGzVG8eknRpzDWfBvc6W5HTBa7N4Le03h9p2JoIR6yHI ZNEN3w/N3wsYDUWUrsTILs4kP2lmT/UdDpApUjOjaE2/3LS3Ep6172F3N/9KoDbH50JwxnwS mTu9UWmDhoVG/KjkDOU7kiM3P/QjCencddHfFG/3qEz2wDCroAJMzUaXEW2ieO0gUm/X5RYM UN80jojq+0++VKmSvH5XgakuziUsxgEQd1SHuYmrgaXxcLpDx2xXzZeCGQbMZp/6ZFwFWdCO kK1c83BOh5G7bGvUCymqaamvD20JBE6PWw9enpRJeca2OUPsL3fnzqWEIgySP7u14ykcd3j6 2vU9XZj3t3/meZOjvzmpg6f3lpAs7CTFmYIChPrsnVJB++TTKqsfMSW5FfS9p6sx67JHwDa7 BDodyVzhd3i7K1hdwTXGo3h5Jnzu5643MT02DaC3/AJrlxBAUKLc4FK+y1ZL0x0KMsCcjKBS BaN51IJucINYyH0M/Afj2eN5yMClPiIKDgYfqqMMoomjmZZKWdrAx2ClWbPhjuwwSDAYIk0O IuBcNbEMJrpIf0P8dd3Ls9DuYIWKtcWnz6PFcuilk7/uVdcDVbMIYo43JK1RrhRxMu5TM/9q r6z6+PiJ81jbdDD
  • Ironport-hdrordr: A9a23:t//4JK9MLUiUJRzk48Buk+DSI+orL9Y04lQ7vn2YSXRuHfBw8P re+MjztCWE7Qr5N0tApTntAsS9qBDnhPxICOsqXYtKNTOO0ADDEGgL1/qE/9SKIUPDH4BmuZ uIC5IOa+HNMQ==
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

First set of Ocaml fixes, cleaned up from series posted previously.

Patch 1 fixes a logical error introduced in the xenstore live update support.

Patches 2-5 fix oxenstored to keep /dev/xen/evtchn open across live update.

Patches 6-8 fix various issues with diagnostics.

All previous feedback applied, but I've started this series again to avoid
confusion.

Andrew Cooper (1):
  tools/oxenstored: Fix incorrect scope after an if statement

Edwin Török (7):
  tools/ocaml/evtchn: OCaml 5 support, fix potential resource leak
  tools/ocaml/evtchn: Add binding for xenevtchn_fdopen()
  tools/ocaml/evtchn: Extend the init() binding with a cloexec flag
  tools/oxenstored: Keep /dev/xen/evtchn open across live update
  tools/oxenstored: Log live update issues at warning level
  tools/oxenstored: Set uncaught exception handler
  tools/oxenstored/syslog: Avoid potential NULL dereference

 tools/ocaml/libs/eventchn/xeneventchn.ml      |  6 +-
 tools/ocaml/libs/eventchn/xeneventchn.mli     | 13 +++-
 tools/ocaml/libs/eventchn/xeneventchn_stubs.c | 50 ++++++++++++--
 tools/ocaml/xenstored/domain.ml               |  6 +-
 tools/ocaml/xenstored/domains.ml              | 14 ++--
 tools/ocaml/xenstored/event.ml                |  8 ++-
 tools/ocaml/xenstored/logging.ml              | 29 +++++++++
 tools/ocaml/xenstored/syslog_stubs.c          |  7 +-
 tools/ocaml/xenstored/xenstored.ml            | 94 ++++++++++++++++++---------
 9 files changed, 179 insertions(+), 48 deletions(-)

-- 
2.11.0




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.