[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 3/3] x86/xen: add a dummy trampoline for Xen PV guests


  • To: Juergen Gross <jgross@xxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Wed, 23 Nov 2022 10:37:24 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=x5ty3CLTZ0hocY15yoErpTVc1qvUG4mLefS0k4LtJ8I=; b=Va84C3FqeJcUyNy5eMp469qv0bTS4KobtGM+aQjZ5Kv4lqkxWPWBj9rzm4PQ5JyNHWsaBMTsRzOnoAfNu4G/Rrxz/xfpMcJ9QfK1rAyAz8RBNV1rXE/Ee6FsSInNwWkUyiolVApjObBYPZaPFKDmsGuU7rjTLKdOaoMtiIEAx4qCEF/qjsA/mmwMJSQvnsv6pyC1I2Yrl9Nm0HiJm+x54MtXkJfi+7OQWWvUkcfvKmKxZdOygKqm/qCPlyB7TNUBh9AGpAnpudrmXgb2spmsaZO6862qay/z1YnMn5buJ3wfw1ZsjTtvn+XAGsG2AOgbEogyPJSzhXY0vA5tLs5VHA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AzVjYFI7anG0jg4L5qgC+pSMdtzcQstZSQdUI7YYd9CGUYAbFDKzmWFba/Kt4TX5RqECu8FZqJ4Q2txQFwUhNXO+Tjryf5p3Zu87eyagS4KStBVU9cK6vHxDua/xBR0v39682kpyDnLFIOgMtymsbCxIEbw+YzPch9t9fW7NtD1SSNDYS0WZO9X8sUB8xj4Mj0+ZKdubNsm6ukgd20ipn0toUKtyCHwoOvIbRZOJsegm2L4EDHFCjl7312rdBTAFW3GOuKzQA9E43fpViJiDK/+5xFJqTW9Mgyq0U7yIkGi0DPpQYh6lSEBjRrX/fkSvYT8p9zhBgEw7aaVJB3yslQ==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: Thomas Gleixner <tglx@xxxxxxxxxxxxx>, Ingo Molnar <mingo@xxxxxxxxxx>, Borislav Petkov <bp@xxxxxxxxx>, Dave Hansen <dave.hansen@xxxxxxxxxxxxxxx>, "H. Peter Anvin" <hpa@xxxxxxxxx>, Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, x86@xxxxxxxxxx
  • Delivery-date: Wed, 23 Nov 2022 09:37:31 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 22.11.2022 17:38, Juergen Gross wrote:
> @@ -137,12 +138,28 @@ static void __init xen_pv_init_platform(void)
>       xen_init_time_ops();
>  }
>  
> +static struct real_mode_header xen_rm_header;
> +
> +static __initdata struct trampoline_ref xen_dummy_trampoline = {
> +     .blob = (unsigned char *)&xen_rm_header,
> +     .blob_end = (unsigned char *)&xen_rm_header,

With both pointing to the start of the struct, doesn't it suffice
for the above to be xen_rm_header[0]? At which point there'd be no
reason to wonder whether that struct could live in .init.data ...

Jan



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.