[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN v3 12/12] xen/Arm: GICv3: Enable GICv3 for AArch32
- To: Ayan Kumar Halder <ayan.kumar.halder@xxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Michal Orzel <michal.orzel@xxxxxxx>
- Date: Wed, 23 Nov 2022 10:51:20 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=a3AFr8Lf68vB9ret9F/CZH0Sq9Bs6pdxsluAiTqFWBI=; b=H9jzBoqP1b+VG8djYhpt4k1vRusCFlElVHcHwOe+gY0C5HNKt+AYimJ+8Pwh29jHRY4igcEqzvK2K61yPKOt/hnhhvq8oUvD3Qm6adzoVdCduxTyzkXI/+F8Cdt7E76PG0H3AkY1QjGcyzbNrueuyZkdR7kgxV7ZPNwOVMuYvobm8ahhCzGhiiC6dPCohJMMcAPewuZoWrEfJUK/MC7V+hC8asqS56CKaiGiHlyXhIu9KGj+ZxeHuRSpekcZf1LZEG6qa/pD2U4yJYMI0QaeNQQ77ZA5TRQQFX/4ZBirwSvjO6Gz+CK7srlNoICT0BvMgveef2lVeeCOgLXI6YdN6A==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Qvi/Ce245i4V2ubyHOvypLPl5xdmskz3vw8anI4c8Ewo7A2IVxxxEaULOQvzllBzQQ0i6EC9swInl7ft6t1nAXxjrqXRDqwUckwlNoFbfz0z19AU1d9kV0IFqcRix003OL6yQ0LY4tXk9xdFVtgxDR0tdqnBAkxK0jmptn696PAMXSPka091vdBg+DozJH+iEOo+r8YubDpAulEaTxXilws8IiCq6MXMTmZ7NMSgBFWcZCEWe/JT5kclRL1Lqb94d3lOfXLSeDrav/tKMerf0Iti9YtBhI1ostO5hyAw+zEreJHnLTD4bwBT4q/iBS8zm4uM0BFxbN9gRYegYtLaqA==
- Cc: <sstabellini@xxxxxxxxxx>, <stefanos@xxxxxxxxxx>, <julien@xxxxxxx>, <Volodymyr_Babchuk@xxxxxxxx>, <bertrand.marquis@xxxxxxx>, <jgrall@xxxxxxxxxx>, <burzalodowa@xxxxxxxxx>
- Delivery-date: Wed, 23 Nov 2022 09:51:39 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
Hi Ayan,
On 11/11/2022 15:17, Ayan Kumar Halder wrote:
> One can now use GICv3 on AArch32 systems. However, ITS is not supported.
> The reason being currently we are trying to validate GICv3 on an AArch32_v8R
> system. Refer ARM DDI 0568A.c ID110520, B1.3.1,
> "A Generic Interrupt Controller (GIC) implemented with an Armv8-R PE must not
> implement LPI support."
>
> By default GICv3 is disabled on AArch32 and enabled on AArch64.
>
> Updated SUPPORT.md to state that GICv3 on Arm32 is not security supported.
>
> Signed-off-by: Ayan Kumar Halder <ayan.kumar.halder@xxxxxxx>
Reviewed-by: Michal Orzel <michal.orzel@xxxxxxx>
with one remark...
> ---
>
> Changed from :-
> v1 - 1. Remove "ARM_64 || ARM_32" as it is always true.
> 2. Updated SUPPORT.md.
>
> v2 - 1. GICv3 is enabled by default only on ARM_64.
> 2. Updated SUPPORT.md.
>
> SUPPORT.md | 7 +++++++
> xen/arch/arm/Kconfig | 9 +++++----
> xen/arch/arm/include/asm/cpufeature.h | 1 +
> 3 files changed, 13 insertions(+), 4 deletions(-)
>
> diff --git a/SUPPORT.md b/SUPPORT.md
> index ab71464cf6..3f16d83191 100644
> --- a/SUPPORT.md
> +++ b/SUPPORT.md
> @@ -82,6 +82,13 @@ Extension to the GICv3 interrupt controller to support MSI.
>
> Status: Experimental
>
> +### ARM/GICv3
... For me this section should go before the section ARM/GICv3 ITS.
The reason being ITS is an extension and your section being generic
should be listed before listing extension.
~Michal
|
