[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 0/2] x86/xen: Fix memory leak issue
- To: Xiu Jianfeng <xiujianfeng@xxxxxxxxxx>, boris.ostrovsky@xxxxxxxxxx, tglx@xxxxxxxxxxxxx, mingo@xxxxxxxxxx, bp@xxxxxxxxx, dave.hansen@xxxxxxxxxxxxxxx, hpa@xxxxxxxxx, jeremy@xxxxxxxx
- From: Juergen Gross <jgross@xxxxxxxx>
- Date: Wed, 23 Nov 2022 16:23:36 +0100
- Cc: x86@xxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
- Delivery-date: Wed, 23 Nov 2022 15:23:41 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 19.11.22 09:59, Xiu Jianfeng wrote:
The new string allocated by kasprintf() is leaked on error path
Xiu Jianfeng (2):
x86/xen: Fix memory leak in xen_smp_intr_init{_pv}()
x86/xen: Fix memory leak in xen_init_lock_cpu()
arch/x86/xen/smp.c | 16 ++++++++++++----
arch/x86/xen/smp_pv.c | 8 ++++++--
arch/x86/xen/spinlock.c | 3 ++-
3 files changed, 20 insertions(+), 7 deletions(-)
Hmm, I think it would make more sense to always store the name generated
via kasprintf() in the percpu variable (independently from succeeding to
bind the irq), and in the related free function to always kfree() it and
set it to NULL again.
This would result in less code.
Juergen
Attachment:
OpenPGP_0xB0DE9DD628BF132F.asc
Description: OpenPGP public key
Attachment:
OpenPGP_signature
Description: OpenPGP digital signature
|
