[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] tools/ocaml/xenctrl: OCaml 5 support, fix use-after-free
- To: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>
- From: Christian Lindig <christian.lindig@xxxxxxxxxx>
- Date: Thu, 24 Nov 2022 14:23:36 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MLitRt+OuYVvU+Z7wTGEFQj1aYGeuFAmjUJxA23086w=; b=hwKOYYgeHCYLdmUbGzD/T5NfsE2wFWbcsMg84peK0OIKmQAP7UIsDWFOS/PgObkMCcadisE/gbMp8VEQYYQu234i0to76feWNI5aJKz7PTwg8oBD3aEwg5jU0lGr6NoMReAuAzy+vRmiHXqim652cEAUcq5pb9jDfzt50Lsz+6VaD7j/FYlTG4VaM+8eauJ7LxE8CJhTFvcXWsRZL0BZdl2CUDmCS0EbJB7/zty7UK/WottMdiEzB1yHIs+j5aoHuLinL1BvOQypDVcfxaCB+R52jD0z4fEKyt52Os2vZCD1oPconnV3bBV01gfYzb8bGZN7HZTA+9PXMpQtxiYVjA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jxLd5Pea8YYJHmZBh3OAeag9hqgSSY/alxnYaz5JslQ3iZFr2SAaCkjV5+HnmNSxY361vqkuE7JOsjWS0W07g1fxCIbqy0B/qopqSR+ItKKk9d8FVTdPIxOaBVTZoIgkPJjOzVQWq8ceWSsWzp4pmjj+CU1NFBL6t34iNJvJvLbYi8lKFQc2QAUHA6C8ILFu+93oybU9KgsMnraQU2LyBx9hPrcE96lzZSfzeRH67j35zYyp7z1InFBorYEJfLC35nv/W8I7J9DqaNuDkOmN157yfrznJ7+1gL16b2qXN0O2/4THQNpZYmYFXojuVsD4A6Pa5umtlQ5Ufh4/h9K6lg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Edwin Torok <edvin.torok@xxxxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, David Scott <dave@xxxxxxxxxx>, Rob Hoes <Rob.Hoes@xxxxxxxxxx>
- Delivery-date: Thu, 24 Nov 2022 14:23:50 +0000
- Ironport-data: A9a23:tBX7Gqki8XmNwpmaUQ225fHo5gyfJ0RdPkR7XQ2eYbSJt1+Wr1Gzt xIfUDqAPamDM2ukeIonOoq0o0kE78LdmtdnHAI4rCtgRCMWpZLJC+rCIxarNUt+DCFhoGFPt JxCN4aafKjYaleG+39B55C49SEUOZmgH+a6U6icf3grHmeIcQ954Tp7gek1n4V0ttawBgKJq LvartbWfVSowFaYCEpNg064gE4p7aqaVA8w5ARkP6kS5gOGzRH5MbpETU2PByqgKmVrNrbSq 9brlNmR4m7f9hExPdKp+p6TnpoiG+O60aCm0xK6aoD66vRwjnVaPpUTbZLwXXx/mTSR9+2d/ f0W3XCGpaXFCYWX8AgVe0Ew/yiTpsSq8pefSZS0mZT7I0Er7xIAahihZa07FdRwxwp5PY1B3 aMbN29XXDKRvOX1+pzgdMZstOFyMvC+aevzulk4pd3YJdAPZMmbBoD1v5pf1jp2gd1SF/HDY cZfcSBocBnLfxxIPBEQFY46m+CrwHL4dlW0qnrM/fZxvzeVkVE3ieC1WDbWUoXiqcF9lUaCp 3na/m3/RBUbMtCexhKO8262h/+JliT+MG4XPO3lp6c70QPNroAVIDwdZVjrmueCsW+jed9/F WI62QUs9bdnoSRHSfG4BXVUukWsrhMaHtZdDeA+wAWM0bbPpRaUAHAeSTxMY8Bgs9U5LRQm3 0GEt8nkDjtutPuSU331y1uPhTa7OCxQKHBYYyYBFFMB+4O6+Nl1iQ/TRNF+FqLzlsfyBTz73 zGNqm45mqkXiskIka68+Dgrng6Rm3QAdSZtji2/Y45vxl8RiFKND2Bw1WXm0A==
- Ironport-hdrordr: A9a23:m3m406m+2fqVr995BXutPu9yPPzpDfMEiWdD5ihNYBxZY6Wkfp +V8cjzhCWftN9OYhodcIi7SdK9qXO1z+8X3WGIVY3SETUOy1HYVr2KirGSjwEIeheOvNK1sJ 0NT0EQMqyWMbEXt6fHCUyDYq4dKbq8ge+VbIXlvhFQpGhRAskOgTuRSDzra3GeLzM2Z6bRYa Dsgvav0ADQHEj/AP7aOlA1G8z44/HbnpPvZhALQzYh9Qm1lDutrJLqDhSC2R8acjVXhZMv63 LMnQDV7riq96jT8G6c60bjq7Bt3PfxwNpKA8KBzuATNzXXkw6tIKhxRrGYuzgxgee3rHInis PFrRsMN9l6r1nRYma2ix3w3BSI6kdh11bSjXujxVfzq83wQzw3T+Bbg5hCTxff4008+Plhza NixQuixtlqJCKFuB64y8nDVhlsmEbxi2Eli/Qvg3tWVpZbQKNNrLYY4FheHP47bWDHAcEcYa xT5fPnlbFrmGChHjbkV65UsYWRt0EIb1O7q445y5SoOnZt7StEJgAjtbEidz87he4Aot9/lq T52+1T5c9zZ95TYqRnCOgbR8yrTmTLXBLXKWqXZU/qDacdJhv22tfKCCVc3pDURHUk9upEpH 36aiIviUciP0b1TcGe1pxC9R7ABG27QDT208lbo5x0oKf1SrbnOTCKDAlGqbrqn9wPRsnAH/ qjMpNfBPHuaWPoBIZSxgX7H51fM2MXXsEZsssyH1iOvsXIIIv3sfGzSoeaGJP9VTI/Hm/vCH oKWzb+YM1G80CwQ3f9xAPcXnv8E3aPia6Y0JKqitT75LJ9RbGk6DJl+GhRzvv7WQFqo+gxYF Z0Jq/hn+eyuXS2lFy4nVlUBg==
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHY/4p+D/wPMbQAQkGOEHU/y0ZpLq5NyDSAgABOF4CAAAXGgIAAAqyAgAAC2oA=
- Thread-topic: [PATCH] tools/ocaml/xenctrl: OCaml 5 support, fix use-after-free
> On 24 Nov 2022, at 14:13, Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx> wrote:
>
> On 24/11/2022 14:03, Edwin Torok wrote:
>>
>>> On 24 Nov 2022, at 13:43, Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx> wrote:
>>>
>>> On 24/11/2022 09:03, Edwin Torok wrote:
>> Perhaps a compromise between the 2 extremes would be for xenopsd to open and
>> have its own xenctrl handle, even if that leads to some code duplication, it
>> would at least not rely on an undocumented and unstable internal detail of
>> an already unstable ABI. And that would still allow xenopsd to extend
>> xenctrl with bindings that are not (yet) present in Xen.
>> What do you think?
>
> Many of these problems will disappear with a stable tools interface.
> But yes, in the short term, xcext opening its own handle would
> definitely improve things by keeping the two sets of bindings separate.
>
> ~Andrew
Acked-by: Christian Lindig <christian.lindig@xxxxxxxxxx>
I agree with this approach. We want to keep the friction low but not having to
coordinate releases and re-compilation. Changes in xenopsd are public for
anyone curious and could be upstreamed to Xen later.
— C
Acked-by: Christian Lindig <christian.lindig@xxxxxxxxxx>
|
