[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2] process/release-technician-checklist: Explain how the banner in README is generated


  • To: Julien Grall <julien@xxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Fri, 25 Nov 2022 10:17:53 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=d8Fx0aXdUkvYV9pxscOdGfz/m7b7C11B1FxCnhAwm24=; b=IHbF5/mrIa5IoERkXQntnEXNBt2uTuOTgf8uHWfcBomy3crcHHbHAVYzkxbvmPlpw7kmtdmTqojPsKbLqG6UEqpqAVMJMWjK7AB99qMG9/8G0fhG8ijo7fB5ngSShcfvXNlYiKfr3/xleC5NIZHZubeCtYdMxkxFj5OSg/QGLYGi/Ws9Mb8l75JY1cLsJ9cA2WlAPls6OHMZ5sa5chlEtEHXq0Q0HrHA/BNHYFMaZKagvbddXRCiLULWzQn9qIUvLqlfk8ivz9fk4mSJYO7hAAEq7GfUDnFCbITDc9DFxJskp+nP3o5daAQjRb+x0CnC1H4y+sG2UXossD+HWB5MGQ==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VfxIXci+jt8fjNnj+h6PzRcXT1Z0btT5DClxEJgZlg89SWbif0wEAPBJPVxDImHX8f+9L2dAwgvHZEi9k650/PrH3Qtdp56AVA1dpMYBYPJvh4Ngu26268I48PiSAx1YqOM+ZwZVhRvW1Jj/bWFCQfmCDK7hzVTGWn4mzKq+8d2XSvyL+K1Mh19oZjE86awB9UnmeYTaMMAhDfUoXS0sxmlhmpQDrJne/s81amzXvYHH+uGwhbfyHQQ4rd6cCvZG9DNyqbM7zGuAl2QIRmBJ1aRgexgn86CkU4W0Bc6sfHN8I6AGORcecH7ebRy71bw5HqhZ743+oTdqG893mPfPgw==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: Julien Grall <jgrall@xxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • Delivery-date: Fri, 25 Nov 2022 09:18:16 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 24.11.2022 20:08, Julien Grall wrote:
> From: Julien Grall <jgrall@xxxxxxxxxx>
> 
> Explain how the banner in README is generated and take the opportunity
> to mention what it should look like for RC.
> 
> Signed-off-by: Julien Grall <jgrall@xxxxxxxxxx>

Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
albeit with a couple of nits:

> --- a/docs/process/release-technician-checklist.txt
> +++ b/docs/process/release-technician-checklist.txt
> @@ -48,7 +48,12 @@ t=RELEASE-$r
>  
>  * consider bumping sonames of shlibs
>  
> -* change xen-unstable README (should say "Xen 4.5" in releases and on stable 
> branches, "Xen 4.5-unstable" on unstable)
> +* change xen-unstable README. Should say:
> +    - "Xen 4.5" in releases and on stable branches
> +    - "Xen 4.5-unstable" on unstable
> +    - "Xen 4.5-rc" for release candidate
> +
> +*   The banner is generated using figlet
>  * change xen-unstable Config.mk

Perhaps insert another blank line between these two bullet points?
Or, if they're deemed to belong together, remove the one you insert?

The new bullet point you add also would likely want to match the
others in style, both for the number of spaces after * and for not
using a capital first letter (maybe "generate banner using figlet").

Jan



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.