[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH maybe for-4.17] tools/include: Fix clean and rework COPYING for installed Xen public header
- To: Anthony PERARD <anthony.perard@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Fri, 25 Nov 2022 10:28:52 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TPyue251BK+G2vemnLqNepnkO7/seUcFG+WjoH8+TZs=; b=mD8AEuZDqipoQyLKmywdRc7Y7kCf0RuKAqVScCz+BMWvdJaKll7LhZ11chk7qLGaGvZpK2jjEei6V0LdLeSVcSPYal4LjJcVvwiOQ5QZ/ewB//AeUG9ivULqEgWHXzLHP4Tw6HbmYFwvbGA9HV37XH4iwoJd3JMcFTDG6qubCiMzRfXEc9Cb9MMkOqIMsxRQEffmUVrgtQdR+uqHRWyNRnLMUzMh/63UpEA4mCOhqJI1CyTaFCOqGHto+ovrmVf3icV+0Df48W0iANUjUp/yOvEakZHOFaiUhklRuKsUi5mrV3hvB9+3cpa1N/Fua1vlexh+JEiuHmsHuxERG0+XMg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=N7knIanIdZhIn5tyG55OIeGPHGxVOae0UINHrxnufLSv5KJTp9x0wCzIJpV0toVz92x0C29uouW+mWosx/ADvGMMJ2X5isKjKJ6SBYMFIyMEM6D7yDp5R7+B8j+KbXc1EXgCLin/n/k8qXdQgiGzZeWzGLuM+4ni4BTRuB3G+6rWBDCzXujxu1X84mCCLTUlcejIzaNQG/SWVvXty63Wonb9Ou2CIwbQ2uvghJEMHnO5Q8w5xobZ4Ve44pbkk/ikW0vqdbOCGxlMb4VqdMAuxmAZ6eyJM/a1dLz2jZhJYK+QoXZI6nu5hEL/ptbVbtEdA2a9WCrmEE17/PkpIa6YLg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Henry Wang <Henry.Wang@xxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Fri, 25 Nov 2022 09:29:02 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 24.11.2022 17:42, Anthony PERARD wrote:
> Use actual include directory used to install the public header in
> COPYING file.
>
> Also, move the input file out of "tools/include/xen/" because that
> directory is removed on `make clean`.
>
> We can't used ./configure because $includedir contain another
> variable, so the change is done in Makefile.
>
> Fixes: 4ea75e9a9058 ("Rework COPYING installed in /usr/include/xen/, due to
> several licences")
> Signed-off-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
(with a question, perhaps just for my own education, at the end)
> ---
>
> Notes:
> For 4.17 inclusion:
>
> Doing `make clean && make` in the root dir is going to fail as make
> isn't going to find the COPYING file while trying to install the
> includes.
I second this would better be fixed for the release.
> --- a/tools/include/Makefile
> +++ b/tools/include/Makefile
> @@ -24,6 +24,7 @@ xen-foreign:
> xen-dir:
> mkdir -p xen/libelf acpi
> find xen/ acpi/ -type l -exec rm '{}' +
> + sed -e 's#@includedir@#$(includedir)/xen#g' xen.COPYING.in > xen/COPYING
Any particular reason for using -e here?
Jan
|
