[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH] x86/MSR: use latched "current"


  • To: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Tue, 29 Nov 2022 15:49:55 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=s/yZJ1LIts7VqeitQmCNVAh1vz5oW18vSF5fdrcLYBc=; b=Mxjw3oAYLp1dQFzQ9iRyqx9SMI9+QkSO3mFGNg6//pEjS186EjrHKmToor6gdS/fU65NoVz0h3PgJOaE1XzKs0+zigbwTZeL0ZCiVMuNtYsauo1fYRLYz7COvGcYuq4hHpZRofaOllQMAjSKmrhgHeZrqwv6+2nqA48qi/NSYXIdJhOoA5Rhd8fbeQSv6d4XdTkQITlCLl2Q90XcHcBbhZKp1XcyNkCQ3SGEAD1nnXzYLKhat+HKO3F+OtXFbaU/mDlBCatiwPNahYEq+Jl8Ste4laAFS+yZsvHnrQquh2mWHIN74pc4f06BRzG35ZrZZDEGsSScp3krH2jAlgNF4w==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NSARZHG+SOWHxHpTrrlTvU1UhF1JvRmVverI4jC6cBlHwqspL7Vz+Nt2aORhE/vL7Sm9/M/hQTIGx17ZzARLmBX8ifA5Yx0qpjjlbFjOksq7DyxDn94iBiUryjTQb3iQJyv8U9KU0UlKTOrbSamrwmalI0/zmKPOTfVANPWnCOKSbpOlekl2STTbBhvR37AOcMFQKeHZr8zvveEkDvp0rSmP5G8Elju4AJeYb+JQLFUN2RLkCAWVdkrf4Koy74mP7gPVR9u17qLK/WLInouGzKMy83X1TOy/8+TgklMhuVj5OKMHzkVythtIPgLB31cGcnSK8Fc9oqwUrCKNNIjlsg==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
  • Delivery-date: Tue, 29 Nov 2022 14:50:28 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

There's no need to recalculate / refetch the value from the stack
(pointer).

Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>

--- a/xen/arch/x86/msr.c
+++ b/xen/arch/x86/msr.c
@@ -417,7 +417,7 @@ int guest_rdmsr(struct vcpu *v, uint32_t
          * out of hardware.
          */
 #ifdef CONFIG_HVM
-        if ( v == current && is_hvm_domain(d) && v->arch.hvm.flag_dr_dirty )
+        if ( v == curr && is_hvm_domain(d) && v->arch.hvm.flag_dr_dirty )
             rdmsrl(msr, *val);
         else
 #endif
@@ -639,7 +639,7 @@ int guest_wrmsr(struct vcpu *v, uint32_t
         {
             uint64_t xcr0 = get_xcr0();
 
-            if ( v != current ||
+            if ( v != curr ||
                  handle_xsetbv(XCR_XFEATURE_ENABLED_MASK,
                                xcr0 | X86_XCR0_BNDREGS | X86_XCR0_BNDCSR) )
                 goto gp_fault;



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.