[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC PATCH 04/21] xen/arm: vIOMMU: add generic vIOMMU framework
- To: Rahul Singh <rahul.singh@xxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Fri, 2 Dec 2022 09:39:01 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5OWJ8qUSiYEjCXeJLwIb5HJ68rgWS3zgsiNnX43XXwo=; b=c47ZLNY6YyFmWLHnHtnfssR9nzohQG1wl7qLsig3emjQ5etIfAGZtzq8xbYLNpJ9RvR/9bDUkAehJbW3rRAT/nlZgxd7V7FuW+A3HuKk3jgMaklCJHDKIou2MpuUalf4GKg3A5IvqrZcx/wLIDD+uRJRttUeT8ZpeCNFg6AbDkcV6/56EzMZtdInrgGxNQ5C/iYsMhrVETduqKpZancH2rmvWDRMVraTyxcCTNPo3S1yspJDfrhgWBH2gZ7zSOjLgPRQWZ43BdAV0w/rTiyP6vxj9ZeZnMVPQUBiOj7JYNHbTq1p3Z1EeLc1BnNxUIGoD2QEB7mxheq8wen3EXLl8A==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HhdTGmYm9IgI30OzapbNP+uwQ1KW1/A0OqyOG3xuUUU96bbWPRDUeDIEMn//zpNQn/AXGcNs3uM2VzayoJOQVhQDLpMnrfQcFE7ubXcR1f4DSxFCm4K0pEuFg/bq0qgTR/PdPj7mZJxOodMlFK7+z+GsXvOjuaKK6/56B9gMqbOsYRODI3Qq+BxVu7pXkctPs4sRt++wGTfVTcyf+F9nipu66AOswsa3AK/e5T1W0nUlHZaCBTdnJXU4XomjhjSNPSGc9cZXR/fAK1T6gTKEjX0TY8UxbLhL5SyNcLfmzdMBrqQWD3zCmjVG8SIEBm99gShvU+YNrFlAqV1AppL0XQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Paul Durrant <paul@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Fri, 02 Dec 2022 08:39:11 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 01.12.2022 17:02, Rahul Singh wrote:
> --- a/xen/drivers/passthrough/Kconfig
> +++ b/xen/drivers/passthrough/Kconfig
> @@ -35,6 +35,12 @@ config IPMMU_VMSA
> (H3 ES3.0, M3-W+, etc) or Gen4 SoCs which IPMMU hardware supports
> stage 2
> translation table format and is able to use CPU's P2M table as is.
>
> +config VIRTUAL_IOMMU
> + bool "Virtual IOMMU Support (UNSUPPORTED)" if UNSUPPORTED
> + default n
> + help
> + Support virtual IOMMU infrastructure to implement vIOMMU.
I simply "virtual" specific enough in the name? Seeing that there are
multiple IOMMU flavors for Arm, and judging from the titles of subsequent
patches, you're implementing a virtualized form of only one variant.
Also, nit: Please omit "default n" here - it leads to a needless
line in the resulting .config, which in addition prevents the prompt
from appearing for user selection when someone later enables
UNSUPPORTED in their config and then runs e.g. "make oldconfig". But
perhaps you anyway really mean
config VIRTUAL_IOMMU
bool "Virtual IOMMU Support (UNSUPPORTED)"
depends on UNSUPPORTED
help
Support virtual IOMMU infrastructure to implement vIOMMU.
?
Note (nit again) the slightly altered indentation I'm also using in
the alternative suggestion.
Jan
|
