[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 3/4] tools/ocaml/libs/xc: add hvm_param_get binding
- To: Edwin Torok <edvin.torok@xxxxxxxxxx>
- From: Christian Lindig <christian.lindig@xxxxxxxxxx>
- Date: Fri, 2 Dec 2022 11:50:15 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Y1I07nZvZXjukZSzT68yIEwgGUxUWyJg4CbBDronIwY=; b=AvC6OoLnLvVsUBP686HbVqxlxwW2edtbpA8OzEgtWXFvPu8K/b4QnJUEXHQK7vJZguwXhEhp0xOGj80YgsdUkgtqlNHcMU/KuYTLTdzqdebV9G6I09OswPIXxPMOa0bm+tx6coetIaXXyK4FQ9pW3GLSgEHD+ZVAv/1noQKnJa0b7rupd4TmP3dZIyQeCY1zdxNTyjuzzniEKRRp+9UtD6Koesua7hJjguS76xLBYHRQe08ir1g3/Bu54b+YtaRpixNZdRVrEYja67AdIoGTBSszH6Etg0HScjNZoXp7+D7jGx3U3ihbiD5YIYfboBY5vLelIVzPmwdytLidkCHTlg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cR/oi2EvrNMoQzVVD58UNSupoiPtsoxTqr0Zry1FJVxc6pbrHDH0xfN/19qVT+nyNPTwUYNhXWenrdTWz/lJ+97s9d72yxcCM4HvOFWHauTMvljFoOiQn39ADUXrj/lD/XPkmTQfGMOaoFd0EjlkI/ngmoSXyGhBc1H16b6+Nc+Hx3KpPq9RdUvyGmnN8naXVjqLZGCVo0y713UK+yPHyNzx4MH5wXh25WdYqcJrQKbd187hpOVa7bf0DlwuMffYv5dP0SyJqvz1A4DOACh1ZYs/rSgBJYMSS/VNrp+HY7H1+MrCffcnxVMoVC6bkKeu+OUV2mXth3aRphlZZr9zng==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, David Scott <dave@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Anthony Perard <anthony.perard@xxxxxxxxxx>
- Delivery-date: Fri, 02 Dec 2022 11:50:31 +0000
- Ironport-data: A9a23:sZg2b6wYaH0qtNKNvVt6t+cVxyrEfRIJ4+MujC+fZmUNrF6WrkVTm 2QXCGiFbPeIamWnL4glaIyy8EkHupKHm4ViGldtrSAxQypGp/SeCIXCJC8cHc8wwu7rFxs7s ppEOrEsCOhuExcwcz/0auCJQUFUjP3OHfykTbaeYUidfCc8IA85kxVvhuUltYBhhNm9Emult Mj75sbSIzdJ4RYtWo4vw//F+U0HUMja4mtC5AVkPaoT5jcyqlFOZH4hDfDpR5fHatE88t6SH 47r0Ly/92XFyBYhYvvNfmHTKxBirhb6ZGBiu1IOM0SQqkEqSh8ai87XAME0e0ZP4whlqvgqo Dl7WT5cfi9yVkHEsLx1vxC1iEiSN4UekFPMCSDXXcB+UyQq2pYjqhljJBheAGEWxgp4KV5S5 8w0BWgsVzCOtaGo7IOkbPZG1/12eaEHPKtH0p1h5RfwKK9+BLrlHODN79Ie2yosjMdTG/qYf 9AedTdkcBXHZVtIJ0sTD5U92uyvgxETcRUB8A7T+fVxvDCVlVQruFTuGIO9ltiiTsVPn12Ep 2vAuWD4BB0bO/SUyCaf82LqjejK9c/+cNJPROXhp6U16LGV7moLKUVNZEmRnaOk02q1X8MPA G4LpjV7+MDe82TuFLERRSaQsHOC+xIRRddUO+k78x2WjLrZ5R6DAWoJRSIHb8Yp3Oc6TCIn/ kWElNToAXpoqrL9YW2Z3qeZq3W1Iyd9EIMZTSoNTA9A6d+8pog210rLVow6SPTzicDpEzbtx TzMtDI5m7gYkc8M0eO84EzDhDWv4JPOS2bZ+znqY45s1SshDKbNWmBiwQGzASpoRGpBcmS8g Q==
- Ironport-hdrordr: A9a23:rmWGqq0WpFTYW2usmB1SVQqjBEQkLtp133Aq2lEZdPU0SKGlfg 6V/MjztCWE7gr5PUtLpTnuAsa9qB/nm6KdpLNhX4tKPzOW31dATrsSjrcKqgeIc0HDH6xmpM JdmsBFY+EYZmIK6foSjjPYLz4hquP3j5xBh43lvglQpdcBUdAQ0+97YDzrYnGfXGN9dOME/A L33Ls7m9KnE05nFviTNz0+cMXogcbEr57iaQ5uPW9a1OHf5QnYk4ITCnKjr20jbw8=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHZBjy6tVGKXp8AVkOBzk6mFgDO865afAEA
- Thread-topic: [PATCH v2 3/4] tools/ocaml/libs/xc: add hvm_param_get binding
> On 2 Dec 2022, at 10:55, Edwin Török <edvin.torok@xxxxxxxxxx> wrote:
>
> Not to be confused which hvm_get_param, which also exists and has a
> different, more error-prone interface.
>
> This one always returns a 64-bit value, and that is retained in the
> OCaml binding as well, returning 'int64' (and not int, or nativeint
> which might have a different size).
>
> The integer here is unsigned in the C API, however OCaml only has signed
> integers.
>
> No bits are lost, it is just a matter of interpretation when printing
> and for certain arithmetic operations, however in the cases where the
> MSB is set it is very likely that the value is an address and no
> arithmetic should be performed on the OCaml side on it.
> (this is not a new problem with this binding, but worth mentioning given
> the difference in types)
>
> Signed-off-by: Edwin Török <edvin.torok@xxxxxxxxxx>
Acked-by: Christian Lindig <christian.lindig@xxxxxxxxxx>
|
