[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/8] x86/mm: Avoid hard-coding PAT in get_page_from_l1e()
- To: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Tue, 6 Dec 2022 12:07:49 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=f21hIBnvjdpCSssyREkyq4ksAWaZ0ZhSaml5UfIOdmk=; b=F8Bd7WUzhQDt2jFiMmuMfHMZqRWpNHcq8cDp7F+XzHvCgv6Xu1J45FvlJZlpSPMw7+gabLtAe5TQYR/rl6BM5YdIP8WZCu9WmYoRfvb+vTA6ihRQW21PFMXrhtSBADm85IT9K0xpV+FeXV+FstXwa6j217UBLws2HuYVQqnKFJ2pRwZfeTs+352HGy45GGycZSaRhzpEdstn1w1NqO4hWoT+p4HtvtQcUq+5DuaV7b7Jlcy0BjggAYzjgzEN3BkDfR/2dmbmmMwOGBRT4CNcO7eUDBnZN0u5qdUnDFtVqJvIG+7Cqs+hYWriMvKdrNfH0f98oMz147J4cZOM3qFDcA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gPy4QeECFK9X8WV7JSFdFMdcIp0B5KIM2YZoAO6MCv+KluVIxWZKGkjOR28IweuBRraZXWJfgmU5NCH4v4VuEp89oNFTR7R1k1emBA2SiSU5ePTNxxOztOQTUYQB3x3KnXuRaH6nCziqk4f+uctFV236BbvVqyNGuDqPn4RdBNxgk93DicgsDEsFp5w/nqfF2tOmWpBeSKfiOjomuu6kLsl1gSoR4z6jHK5NXAIUO1UHJpXLLuRoO9jAM2r309n6BgNxn8CEAwQ7AT7apOerw1Khgy7KDqFwnIYsnFZEpeFHJq+2vV3RJBBm6SQATcq8S0oQWbGWnx9uHVUUHOeD6w==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx>, Roger Pau Monne <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, George Dunlap <George.Dunlap@xxxxxxxxxx>, "Tim (Xen.org)" <tim@xxxxxxx>, Demi Marie Obenour <demi@xxxxxxxxxxxxxxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Tue, 06 Dec 2022 11:08:27 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 06.12.2022 11:42, Andrew Cooper wrote:
>> --- a/xen/arch/x86/mm.c
>> +++ b/xen/arch/x86/mm.c
>> @@ -961,13 +961,10 @@ get_page_from_l1e(
>>
>
> As you noted that this desperately needs a comment, how about
>
> /* Force cacheable memtypes to UC, */
>
> here?
The comment you appear to be missing is actually there, just perhaps a
bit too far ahead:
/* MMIO pages must not be mapped cachable unless requested so. */
In any event the comment you suggest to add merely re-states in different
words what this earlier one already says.
Jan
|
