[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 0/6] Make remove() of any bus based driver void returned
- To: Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx>
- From: Dawei Li <set_pte_at@xxxxxxxxxxx>
- Date: Tue, 6 Dec 2022 22:33:56 +0800
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=712H7lgui7y6JKIT38YiTq73OPMRMvLDDcUE25Lr6eo=; b=jfWz0NmFUhMsCvzTSd/KEx65x1IrkKWO0Vj2RN1Bt5zpbtesRdJ++FL47Z/jafNjEHlbRP6OHTOADGT74aI0fJjmWPzsPlfqmb4wHbFzR5II1Xx2j28rdPVz7XcGY5QUno6lQ4OFDZ7ZiweMDBcDgHcmXuA8TMlG/xN05dPYFVSZx3hvMt28E7Irqzq6t2ZVAvJH6N9C/xxOCEUdKdy7nTLUUKUiiLhwcYEbmY+F3Xzm2Tpprbm6CvxgWKshZGrQqpsq1/p5I4KGqBFHOfVG94Xby6ibL7F3kSG3omb9rZvBMgXDArUsA2Vnuhj6TbQWvermIipDgyqyOgEopXladQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=L5Xr7yttFZ6IKWmoDWIHQwulWLcEktykBS6I8Qpbl8ohoPnMJ1I+DYrOm/0vYtkMGoaDqnVFHVcvKSLKTtfg8hZDZVAXu+asmPQETvsPgsaVY7SInYgKNiE5RTQ6kqvF3X7Grk2aIgBemD3mKQTS0C2VHrcZSMtW1xpJyhk6Fin2fv2jrQv9t59OaC1QqoQXu+dkVuIMeUpDWCw/w+rRgqqVZEQXGwe7+rSJYmLJWZRPxssuiPmAojIvhw2WLC5GbJI2x9WzMeHxa9jG2nHrvEGmh8NAVlUTfPy8lUf0CI3dr6mNmmnmM+k9JFZN5t1lksV6uaAF+kYRy12K2dZU7g==
- Cc: johannes@xxxxxxxxxxxxxxxx, robert.jarzmik@xxxxxxx, jgross@xxxxxxxx, sstabellini@xxxxxxxxxx, oleksandr_tyshchenko@xxxxxxxx, roger.pau@xxxxxxxxxx, srinivas.kandagatla@xxxxxxxxxx, bgoswami@xxxxxxxxxxx, mpe@xxxxxxxxxxxxxx, npiggin@xxxxxxxxx, christophe.leroy@xxxxxxxxxx, kys@xxxxxxxxxxxxx, haiyangz@xxxxxxxxxxxxx, wei.liu@xxxxxxxxxx, decui@xxxxxxxxxxxxx, alsa-devel@xxxxxxxxxxxxxxxx, linuxppc-dev@xxxxxxxxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxxx, linux-hyperv@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
- Delivery-date: Tue, 06 Dec 2022 14:34:16 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Mon, Dec 05, 2022 at 05:00:52PM +0100, Greg KH wrote:
> On Mon, Dec 05, 2022 at 11:36:38PM +0800, Dawei Li wrote:
> > For bus-based driver, device removal is implemented as:
> > device_remove() => bus->remove() => driver->remove()
> >
> > Driver core needs no feedback from bus driver about the result of
> > remove callback. In which case, commit fc7a6209d571 ("bus: Make
> > remove callback return void") forces bus_type::remove be void-returned.
> >
> > Now we have the situation that both 1st & 2nd part of calling chain
> > are void returned, so it does not make much sense for the last one
> > (driver->remove) to return non-void to its caller.
> >
> > So the basic idea behind this patchset is making remove() callback of
> > any bus-based driver to be void returned.
> >
> > This patchset includes changes for drivers below:
> > 1. hyperv
> > 2. macio
> > 3. apr
> > 4. xen
> > 5. ac87
> > 6. soundbus
Hi Greg:
Thanks for the reviewing.
>
> Then that should be 6 different patchsets going to 6 different
> subsystems. No need to make this seems like a unified set of patches at
> all.
Right, will fix all the issues for this patchset and resend them in 6
independent patches.
Thanks
Dawei
>
> > Q: Why not platform drivers?
> > A: Too many of them.(maybe 4K+)
>
> That will have to be done eventually, right?
>
> thanks,
>
> greg k-h
|