[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [XEN][RFC PATCH v4 10/16] asm/smp.h: move cpu related function to asm/cpu.h


  • To: Vikram Garhwal <vikram.garhwal@xxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Wed, 7 Dec 2022 09:38:31 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Gl9icOvadYcBfPefK8H1y4p6Jsmqe2EENwuaB/xJsWc=; b=nRI02HF+YzCy09Tln6okbLM8K2j1kxH94OUr+FwJ+ugqKmC61ZiRieOlA38jCHRJ7d7m3sa4RL0YoNG92pSTMGkM3BSvo32Zc/1w7i/WZ0YehcAiiwxz0aWd3bvxZRPEsbH+DZSuNHA2Agy/QexYgfuiXL+Lm5ftKNmIV8ecyBuVOt0HMjKypq6h6/Xs1DtiXmjnLUbcYAfCzTYdKFfmNJyG6qXWk2FJCxS4ZKy/BNYvGAj05ghdB7vbHQ7csXMIlNPLC0KWN9zI0muhgTEgexwikE6r+HPpWbiPqlu5w+btlp6uzHC/aGlrxRaH5L8ThfWErz5TSOiDagWfo9zYnA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hOTBfYqFPsQCTi2PgehOpGHgbXpYIOezers0Y81zJtl2nYMSukTXrgaNBN9vfXV19LAGGSHsuhF2hvltLlPClLhV4hlBLgMZoEokYtSmmQTmTjP7fF6SuERP5gT4V2ce2S7wgmyYFHkdOWyz7RsYBmTeM1IoViCYzE5wGOyaW4gH10jipQtblgIqRWmFrEY8yCmr2sYFhp4kqbj8oFgkcEOlKd4r9b3ToKiSDKJgMA/SkookJ9eLZkh4zeQpWU1tRnJZtQfD1GdMexJzMayYo/iABaeZsIAPzPnwFc8RxsWroonWA8ZOKTJ3zhKJfTgXee0aVx/LpUvldh4QpTn9jg==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: sstabellini@xxxxxxxxxx, julien@xxxxxxx, Luca.Fancellu@xxxxxxx, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • Delivery-date: Wed, 07 Dec 2022 08:38:42 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 07.12.2022 07:18, Vikram Garhwal wrote:
> --- a/xen/include/xen/cpu.h
> +++ b/xen/include/xen/cpu.h
> @@ -5,6 +5,10 @@
>  #include <xen/spinlock.h>
>  #include <xen/notifier.h>
>  
> +#ifdef CONFIG_ARM
> +#include <asm/cpu.h>
> +#endif
> +
>  /* Safely access cpu_online_map, cpu_present_map, etc. */
>  bool get_cpu_maps(void);
>  void put_cpu_maps(void);
> --- a/xen/include/xen/softirq.h
> +++ b/xen/include/xen/softirq.h
> @@ -19,6 +19,10 @@ enum {
>  #include <asm/hardirq.h>
>  #include <asm/softirq.h>
>  
> +#ifdef CONFIG_ARM
> +#include <asm/cpu.h>
> +#endif

We generally try to avoid such #ifdef-ary whenever possible, so the
description wants to justify these if they cannot be avoided.

Jan



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.