[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/2] tools/libxl: enable in-band reconnect marker for stubdom QMP proxy
- To: Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx>
- From: Anthony PERARD <anthony.perard@xxxxxxxxxx>
- Date: Wed, 7 Dec 2022 15:26:09 +0000
- Authentication-results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
- Cc: <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Jason Andryuk <jandryuk@xxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Juergen Gross <jgross@xxxxxxxx>
- Delivery-date: Wed, 07 Dec 2022 15:26:29 +0000
- Ironport-data: A9a23:sZdQeKIWSJYf6L6WFE+RF5UlxSXFcZb7ZxGr2PjKsXjdYENShmFRy 2YWDzjTPKuPamagedl1PIuzoB8AucDTyYQyQAFlqX01Q3x08seUXt7xwmUcnc+xBpaaEB84t ZV2hv3odp1coqr0/0/1WlTZhSAgk/rOHv+kUrWs1hlZHWdMUD0mhQ9oh9k3i4tphcnRKw6Ws Jb5rta31GWNglaYCUpJrfPdwP9TlK6q4mlB5ARhPaojUGL2zBH5MrpOfcldEFOgKmVkNrbSb /rOyri/4lTY838FYj9yuu+mGqGiaue60Tmm0hK6aYD76vRxjnVaPpIAHOgdcS9qZwChxLid/ jnvWauYEm/FNoWU8AgUvoIx/ytWZcWq85efSZSzXFD6I+QrvBIAzt03ZHzaM7H09c5WLmpD+ M4pBQpXZ0iGl8my+aq8WrBz05FLwMnDZOvzu1llxDDdS/0nXYrCU+PB4towMDUY354UW6yEP oxANGQpPE+ojx5nYz/7DLo3mvuogX/uNSVVsluPqYI84nTJzRw327/oWDbQUozVGZoOwx/Bz o7A12H8LSwHZdia8GWmzV2XmcjRxwT8BatHQdVU8dY12QbOlwT/EiY+Sl+TsfS/zEmkVLp3K UMO/TE1hbMv70HtRd74NzW6qXiIpA8BWPJfFuQ77EeGza+8ywOQHG0NVDNCQN0gqs4tRDYu2 0OJntXmHjhmuvueTnf13qeZq3a+NDYYKUcGZDQYVk0V7t/7uoYxgxnTCNF5H8aIYsbdQG+qh WrQ9W5n2utV3ZVjO7iHEU7voh2nq5X7fyMPvAyPW3KO6jphY578eNn9gbTE1spoIIGcR1iHm XELncmC8ewDZa2weDyxrPYlR+/wuavcWNHIqRs2RsR6qWzxk5K2VdoIiAySMnuFJSrtldXBR EbI8T1c65ZIVJdBRf8mOtnhYyjGIEWJKDgEahw2RoAWCnSSXFXdlM2LWaJ39z6FraTUuftjU ap3iO71ZZrgNYxpzSCtW8AW2qIxyyY1yAv7HM6kl0/6iOTGPSDNFN/p1Wdiichgvcu5TPj9q Y4DZ6NmNT0AOAEBXsUn2dFKdg1bRZTKLZv3t9ZWZoa+zvlOQQkc5wvq6ep5IeRNxv0F/tokC 1nhAie0PnKj3yyYQehLA1g/AI7SsWFX9y1rZH1yYgr1gxDOo++Htc8iSnf+RpF/nMQL8BK+Z 6VtlxmoahiXdgn6xg==
- Ironport-hdrordr: A9a23:BqTOGqEYI+eT4xp/pLqENMeALOsnbusQ8zAXPiFKOGdom6mj/P xG88506faZslsssTIb6LW90dC7IE80rKQU3WBzB8bBYOCFghrREGgK1+KLqQEIfReOj9K1vp 0OT0ERMrHN5BdB/KLHCaSDYrEd6cjC2pqBwc3Zy25pTQlsYa0l1QFkEQyWe3cGJzWuQaBJcq ah2g==
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Mon, Sep 05, 2022 at 03:50:19PM +0200, Marek Marczykowski-Górecki wrote:
> This enables stubdom reliably detect when it needs to reconnect QMP
> socket. It is critical, as otherwise QEMU will not send its handshake,
> and so libxl will timeout while waiting on one. When it happens during
> domain startup, it can result in error like this:
>
> libxl: libxl_pci.c:1772:device_pci_add_done: Domain 3:libxl__device_pci_add
> failed for PCI device 0:0:14.0 (rc -9)
> libxl: libxl_create.c:1904:domcreate_attach_devices: Domain 3:unable to add
> pci devices
>
> See vchan-socket-proxy commit message for details about this reconnect
> corner case.
>
> Stubdomain side needs to use --reconnect-marker=1 option too.
>
> Signed-off-by: Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx>
Acked-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>
Thanks,
--
Anthony PERARD
|
