[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

RE: [PATCH v3] Use EfiACPIReclaimMemory for ESRT


  • To: Jan Beulich <jbeulich@xxxxxxxx>, Demi Marie Obenour <demi@xxxxxxxxxxxxxxxxxxxxxx>, Julien Grall <julien@xxxxxxx>
  • From: Henry Wang <Henry.Wang@xxxxxxx>
  • Date: Thu, 8 Dec 2022 08:53:48 +0000
  • Accept-language: zh-CN, en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7wb4d9UR5Zugk40nZOAR5r469bFJgjPQE/oAUUG2tM4=; b=X41mFiTFN6L4BwVrqUxCBvW7vP36+tGBfpqRdJIU+gEQPqQHYoAmIeQgh7/NxOAxBqgZjbcniXZF6NY8kaUVDK6TSlswUw/G/Z+fiX31Ax6NIuBVRyCJj1qRBLsokwQeG+fnXjSS36HEBhjUXZ2Aa5jH/iyCISEDJxUkFRFJnuRlXCY9VJvrM7viaVoozOYmVyiISv5xWJ5FXCyGYwTjbUKjXp/SMzC9zzFx3CDYUV2vaUxMNCrcabdTSvHO45HQxCWeimFregDPgjNP4F4wzwrqJhzTYB0RFxO2Y+/CUCXOz4CNxtvvJzliYK+DxP2doPgDvbu2kRbJfDtcGXEEpw==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=I6o2O5h9vFpx4qHG2AHbXqWUyhLq6lQxSi5vtnSu5GmKlxDwmN8UvKq3ys/N2gY004H2M7j3bttK8VruTSeqwvHR1NRk9Re6G5j9zoEP7sn2hJIlRj4pUAuYGwMlPrptAnMLOZJfi/wN/8NXaYmPb+Ne3+F78Dek10EiEb+4Vpl+sJc/jfTYVdCs8ArJjdn2xujEkXYy+EdR4AfG+GXQFXXEWmoVZaqaC3jgIm41vQg5ChiWvPZMQqab6afk2Qfi4MNJlFTljQb3zdc4Oq5xG8ZJVT45h5SJ3IcE7IspIwhv77veaEpsYd6gYmQICUc3gV5yqcvxuaH2TV+lm6F2iA==
  • Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
  • Cc: Ard Biesheuval <ardb@xxxxxxxxxx>, Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx>, Xen developer discussion <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Thu, 08 Dec 2022 08:54:38 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Nodisclaimer: true
  • Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
  • Thread-index: AQHZCuISzshQ7NkOqUOBoTPM3AzEWa5jro+g
  • Thread-topic: [PATCH v3] Use EfiACPIReclaimMemory for ESRT

Hi Jan,

> -----Original Message-----
> From: Jan Beulich <jbeulich@xxxxxxxx>
> Subject: Re: [PATCH v3] Use EfiACPIReclaimMemory for ESRT
> 
> On 07.12.2022 23:42, Demi Marie Obenour wrote:
> > A previous patch tried to get Linux to use the ESRT under Xen if it is
> > in memory of type EfiRuntimeServicesData.  However, EfiRuntimeServices*
> > memory needs to be included in the EFI page tables, so it is best to
> > minimize the amount of memory of this type.  Since EFI runtime services
> > do not need access to the ESRT, EfiACPIReclaimMemory is a better choice.
> >
> > Link: https://lists.xenproject.org/archives/html/xen-devel/2022-
> 09/msg01365.html
> > Fixes: dc7da0874ba4 ("EFI: preserve the System Resource Table for dom0")
> > Signed-off-by: Demi Marie Obenour <demi@xxxxxxxxxxxxxxxxxxxxxx>
> 
> Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
> 
> > Should this be included in 4.17?  It is a bug fix for a feature new to
> > 4.17, so I suspect yes, but it is ultimately up to Henry Wang.  The code
> > is identical to v2, but I have improved the commit message.
> 
> It may be too late now, looking at the state of the tree. Henry, Julien?

Like I said in v2, I don't object the change if you would like to include this 
patch
to 4.17, so if you are sure this patch is safe and want to commit it, feel free 
to add:

Release-acked-by: Henry Wang <Henry.Wang@xxxxxxx>

Since we also need to commit:
"[PATCH for-4.17] SUPPORT.md: Define support lifetime" so from my side
I am no problem. Julien might have different opinion though, if Julien object
the change I would like to respect his opinion and leave this patch uncommitted.

Kind regards,
Henry

> 
> Jan

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.