[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/3] acpi/processor: fix evaluating _PDC method when running as Xen dom0
- To: "Rafael J. Wysocki" <rafael@xxxxxxxxxx>
- From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Date: Fri, 9 Dec 2022 11:12:51 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JjP/Rrmdvq/WTnVAPklZD5PrBjU7PFIzInYp9GdVFMs=; b=Uq47bPPyJDUoBe1z607up7E/cSbMnnROBQDtxosIXon7ijAl3TBu9w8jrZXf4M1hreO5fc6MUCi/afEAPeZTZsK6/kZF6OlOEcfzB4d8dDwiKTqabXK0DTUDHLRahTBcPVl6phGYm1UP1t44InYDRZ/V+LCyPyjxMYVI5YRwMSTzFuO4eMEdf319H+FbuF3yssiCC+MpzrxWcKvHQzool7ke6bDpnQNqzKk4gA4zrrdowRS6s+bnUSHg10Fh2RegCpfjZkO4j1thH5S2ie+GlJ2Dwg+WJy+nvS+FH+dZ2KvcwPwCTv3sx2e3QgtQkQ2wFJ3Nl8MrtbFdBbSMMsvEjQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Cg87I3Erxk3hsb2I4OVDeHkYROB3IoS3fWkm0dv5l3Wq+gnnd/3NoWJScnKw1H6tWm8OQiEpQbYX6bb3iitIbZYO25u9XGYx3IwjYEN+5/Hd4sj5WNYSYA/y5FDTd61hiiPIP981WqwK5h91v35KHDDkaBamwBK+qYk5GW20JhUPv6/awX62UgemnID5vU8aP9qDyC7IWwVqc2Gvd/CyKehs1kKcfdrMdpCJ6wG/Hhcjtq+5HJZsc5KGjm6z+sQ0vNJbRGYjPfSLFT0XZkmP7Qj3RgMigeVR1BEJEOqSBSReNomO7eIBkbOrbjkQkEBOWpycUj3IKnn6UO46kg0oNw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Dave Hansen <dave.hansen@xxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxxx, jgross@xxxxxxxx, Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>, Thomas Gleixner <tglx@xxxxxxxxxxxxx>, Ingo Molnar <mingo@xxxxxxxxxx>, Borislav Petkov <bp@xxxxxxxxx>, Dave Hansen <dave.hansen@xxxxxxxxxxxxxxx>, x86@xxxxxxxxxx, "H. Peter Anvin" <hpa@xxxxxxxxx>, Len Brown <lenb@xxxxxxxxxx>, Alex Chiang <achiang@xxxxxx>, Venkatesh Pallipadi <venkatesh.pallipadi@xxxxxxxxx>, linux-acpi@xxxxxxxxxxxxxxx
- Delivery-date: Fri, 09 Dec 2022 10:13:07 +0000
- Ironport-data: A9a23:8tISwqKA1iaZC6JiFE+REJUlxSXFcZb7ZxGr2PjKsXjdYENS0DwEx 2MZXDqGPqmMYGSgfdEnbd7nph5XuZXcmtFkTAVlqX01Q3x08seUXt7xwmUcnc+xBpaaEB84t ZV2hv3odp1coqr0/0/1WlTZhSAgk/rOHv+kUrWs1hlZHWdMUD0mhQ9oh9k3i4tphcnRKw6Ws Jb5rta31GWNglaYCUpJrfPdwP9TlK6q4mlB5ARvPakjUGL2zBH5MrpOfcldEFOgKmVkNrbSb /rOyri/4lTY838FYj9yuu+mGqGiaue60Tmm0hK6aYD76vRxjnVaPpIAHOgdcS9qZwChxLid/ jnvWauYEm/FNoWU8AgUvoIx/ytWZcWq85efSZSzXFD6I+QrvBIAzt03ZHzaM7H09c5VHGNi2 KUmAwkAf0iHvL+mye+YRtlV05FLwMnDZOvzu1lG5BSBUbMDfsqGRK/Ho9hFwD03m8ZCW+7EY NYUYiZuaxKGZABTPlAQC9Q1m+LAanvXKmUE7g7K4/VspTGMkWSd05C0WDbRUsaNSshP2F6Ru 0rN/njjAwFcP9uaodaA2iLz27WVwX2hMG4UPILh28Y6skyp/DQWAz8sW3CamfqijkHrDrqzL GRRoELCt5Ma7kWlR9T5dx61uniJulgbQdU4O+Ez9gzLyqPS+AufLmkCUjNFLtchsaceQT0sy 0/MnN7zAzFrmKOaRGjb9bqOqz62fy8PIgcqdSICCAcI/dTniIUylQ7UCMZuFravid/4Ei22x CqFxAA8iK8UltUjzLig8BbMhDfEjpLOVA8uoALMQnii8Bh6daaifYWj7VWd5vFFRK6FQV2Rl HwFndWC9ucIDIHLmCHlaOAMGr6uz+yIPD3VnRhkGJxJ3z6103enfI1WsHdyKS9BPs8adHnpa UnItAV54J5VIWvsbKlrbob3AMMvpYDwRYrNVf3OaNdKJJ9re2ev/DlnTVyBw2f31kMrlMkXP Zqde+6vAGwcBKAhyyC5L88U2r8qzyYx7WPLA5v8ynyPz7eYZ3eJRKwFdkOHauQ49KqIoS3U9 cpSM42BzBA3eOn/ZDTHtIcYNVEiM3c2H9b1ptZRe+rFJRBpcFzNENfUyLIlPol6xaJck7+U+ mnnAxAFjl3imXfANAOGLGh5b6/iVop+qnR9OjEwOVGv2D4oZoPHALojSqbbtIIPrIRLpcOYh dFcEylcKpyjkgj6xgk=
- Ironport-hdrordr: A9a23:qW3AvazySfCA362QIcX/KrPw1r1zdoMgy1knxilNoHxuH/BwWf rPoB17726RtN91YhsdcL+7V5VoLUmzyXcX2/h1AV7BZniEhILAFugLgbcKqweKJ8SUzJ8+6U 4PSclD4N2bNykGsS75ijPIb+rJFrO8gd+VbeS19QYScelzAZsQiDuQkmygYzZLrA8tP+teKL OsovBpihCHYnotYsGyFhA+LpL+T42iruOeXfYebSRXkDWzsQ==
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Fri, Dec 02, 2022 at 06:06:26PM +0100, Rafael J. Wysocki wrote:
> On Fri, Dec 2, 2022 at 5:37 PM Roger Pau Monné <roger.pau@xxxxxxxxxx> wrote:
> >
> > On Fri, Dec 02, 2022 at 08:17:56AM -0800, Dave Hansen wrote:
> > > On 12/2/22 04:24, Roger Pau Monné wrote:
> > > > On the implementation side, is the proposed approach acceptable?
> > > > Mostly asking because it adds Xen conditionals to otherwise generic
> > > > ACPI code.
> > >
> > > That's a good Rafael question.
>
> Sorry for joining late, but first off _PDC has been deprecated since
> ACPI 3.0 (2004) and it is not even present in ACPI 6.5 any more.
>
> It follows from your description that _PDC is still used in the field,
> though, after 18 years of deprecation. Who uses it, if I may know?
I saw this issue on a Sapphire Rapids SDP from Intel, but I would
think there are other platforms affected.
> > > But, how do other places in the ACPI code handle things like this?
> >
> > Hm, I don't know of other places in the Xen case, the only resource
> > in ACPI AML tables managed by Xen are Processor objects/devices AFAIK.
> > The rest of devices are fully managed by the dom0 guest.
> >
> > I think such special handling is very specific to Xen, but maybe I'm
> > wrong and there are similar existing cases in ACPI code already.
> >
> > We could add some kind of hook (iow: a function pointer in some struct
> > that could be filled on a implementation basis?) but I didn't want
> > overengineering this if adding a conditional was deemed OK.
>
> What _PDC capabilities specifically do you need to pass to the
> firmware for things to work correctly?
I'm not sure what capabilities do I need to pass explicitly to _PSD,
but the call to _PDC as done by Linux currently changes the reported
_PSD Coordination Field (vs not doing the call).
Thanks, Roger.
|
