[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v8 3/3] ASoC: SOF: Fix deadlock when shutdown a frozen userspace
- To: Ricardo Ribalda <ribalda@xxxxxxxxxxxx>
- From: Kai Vehmanen <kai.vehmanen@xxxxxxxxxxxxxxx>
- Date: Fri, 9 Dec 2022 13:53:31 +0200 (EET)
- Cc: Oliver Neukum <oneukum@xxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, Mark Brown <broonie@xxxxxxxxxx>, Chromeos Kdump <chromeos-kdump@xxxxxxxxxx>, Daniel Baluta <daniel.baluta@xxxxxxx>, Christophe Leroy <christophe.leroy@xxxxxxxxxx>, Len Brown <len.brown@xxxxxxxxx>, Ard Biesheuvel <ardb@xxxxxxxxxx>, Ranjani Sridharan <ranjani.sridharan@xxxxxxxxxxxxxxx>, "Rafael J. Wysocki" <rafael@xxxxxxxxxx>, Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>, Nicholas Piggin <npiggin@xxxxxxxxx>, Michael Ellerman <mpe@xxxxxxxxxxxxxx>, Eric Biederman <ebiederm@xxxxxxxxxxxx>, Dave Hansen <dave.hansen@xxxxxxxxxxxxxxx>, Jaroslav Kysela <perex@xxxxxxxx>, Joel Fernandes <joel@xxxxxxxxxxxxxxxxx>, Liam Girdwood <lgirdwood@xxxxxxxxx>, Peter Ujfalusi <peter.ujfalusi@xxxxxxxxxxxxxxx>, Pavel Machek <pavel@xxxxxx>, Pierre-Louis Bossart <pierre-louis.bossart@xxxxxxxxxxxxxxx>, Kai Vehmanen <kai.vehmanen@xxxxxxxxxxxxxxx>, Steven Rostedt <rostedt@xxxxxxxxxxx>, "K. Y. Srinivasan" <kys@xxxxxxxxxxxxx>, Ingo Molnar <mingo@xxxxxxxxxx>, Bjorn Helgaas <bhelgaas@xxxxxxxxxx>, Dexuan Cui <decui@xxxxxxxxxxxxx>, Takashi Iwai <tiwai@xxxxxxxx>, "H. Peter Anvin" <hpa@xxxxxxxxx>, Bard Liao <yung-chuan.liao@xxxxxxxxxxxxxxx>, Haiyang Zhang <haiyangz@xxxxxxxxxxxxx>, Wei Liu <wei.liu@xxxxxxxxxx>, Thomas Gleixner <tglx@xxxxxxxxxxxxx>, Borislav Petkov <bp@xxxxxxxxx>, x86@xxxxxxxxxx, kexec@xxxxxxxxxxxxxxxxxxx, Alsa-devel <alsa-devel@xxxxxxxxxxxxxxxx>, stable@xxxxxxxxxxxxxxx, sound-open-firmware@xxxxxxxxxxxxxxxx, linuxppc-dev@xxxxxxxxxxxxxxxx, linux-hyperv@xxxxxxxxxxxxxxx, linux-pci@xxxxxxxxxxxxxxx, linux-pm@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-efi@xxxxxxxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Fri, 09 Dec 2022 11:58:34 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
Hi,
On Thu, 1 Dec 2022, Ricardo Ribalda wrote:
> On Thu, 1 Dec 2022 at 14:22, 'Oliver Neukum' via Chromeos Kdump
> <chromeos-kdump@xxxxxxxxxx> wrote:
> >
> > On 01.12.22 14:03, Ricardo Ribalda wrote:
> > > This patchset does not modify this behaviour. It simply fixes the
> > > stall for kexec().
> > >
> > > The patch that introduced the stall:
> > > 83bfc7e793b5 ("ASoC: SOF: core: unregister clients and machine drivers
> > > in .shutdown")
> >
> > That patch is problematic. I would go as far as saying that
> > it needs to be reverted.
>
> It fixes a real issue. We have not had any complaints until we tried
> to kexec in the platform.
> I wont recommend reverting it until we have an alternative implementation.
>
> kexec is far less common than suspend/reboot.
I've posted an alternative to ALSA list that reverts the problematic
patch and fixes the problem (the patch was originally addressing)
in a different way:
https://mailman.alsa-project.org/pipermail/alsa-devel/2022-December/209776.html
No changes outside sound/soc/ are needed with this approach.
Br, Kai
|
