[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [PATCH] xen/arm: efi-boot misra rule 4.1 fix
Hi, On 09/12/2022 09:04, Jan Beulich wrote: On 09.12.2022 01:41, Stefano Stabellini wrote:We have 3 violations of MISRA C Rule 4.1 ("Octal and hexadecimal escape sequences shall be terminated") in xen/arch/arm/efi/efi-boot.h. Fix them. Signed-off-by: Stefano Stabellini <stefano.stabellini@xxxxxxx>While I certainly agree, I wonder if you don't want to correct style (missing blank line after every one of these declarations) as well as data placement (all three should imo be static __initconst) at the same time. +1. And use 'const' as well :). Cheers, -- Julien Grall
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |