Re: [PATCH 1/5] x86/tboot: drop failed attempt to hash shadow page tables

[Jason Andryuk <jandryuk@xxxxxxxxx>]

On Tue, Dec 6, 2022 at 8:58 AM Jan Beulich <jbeulich@xxxxxxxx> wrote:
>
> On 06.12.2022 14:53, Jan Beulich wrote:
> > While plausible to do what was intended based on the name of the flag
> > (PGC_page_table), that name was misleading and is going to be changed.
> > It marks page tables pages _having_ a shadow, not shadows of page table
> > pages. The attempt also didn't cover the HAP case at all, and it
> > constituted a potentially very long loop doing nothing when
> > !SHADOW_PAGING. Instead leave a comment of what actually wants doing
> > there (which then also may need to account for e.g. the risk of A/D bits
> > becoming set behind our backs).
> >
> > Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>

Reviewed-by: Jason Andryuk <jandryuk@xxxxxxxxx>