Re: [PATCH 08/20] tools/xenstore: add hashlist for finding struct domain by domid

[Julien Grall <julien@xxxxxxx>]

Hi Juergen,

On 12/12/2022 12:08, Juergen Gross wrote:
> On 01.12.22 22:34, Julien Grall wrote:
> > Hi Juergen,
> >
> > On 01/11/2022 15:28, Juergen Gross wrote:
> > > @@ -341,49 +339,56 @@ static bool get_domain_info(unsigned int domid, 
> > > xc_dominfo_t *dominfo)
> > >              dominfo->domid == domid;
> > >   }
> > > -void check_domains(void)
> > > +static int check_domain(void *k, void *v, void *arg)
> > Looking at this callback, shouldn't 'k' be const? If not, wouldn't 
> > this mean a caller could potentially mess up with the hashtable?
> I have modified the previous patch to make k const. I hope you are
> fine with me having kept your "Reviewed-by:".
Yes I am fine with that.

Cheers,

--
Julien Grall