[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Relocate the ESRT when booting via multiboot2
- To: Demi Marie Obenour <demi@xxxxxxxxxxxxxxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Mon, 12 Dec 2022 16:19:21 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yCrI+FvUuYFwOEIpx25ixdeuHI8r9x4ZL53O04LkOIE=; b=MViEGYynCiLw0Dnvoo1mthF1U07wwA4pdqIXXwqFC/oVcxHxfckGGCti6MuCytFz4uN1060BNL/1IWvqi3RLR6FJSfFZCD3AT46P/nhwJMhw1/MP4jOVIv/o5UNUQW7GdfX/iio2z3Sk5Y4Ubt4CexAa7LAHzCEFDA7PeWhkxKIlUfOhDXdxsnXRb193OTIm6FmFjb4HsztEy6Kcax/HNBVsiKhDk2620JJrE+2Jz7dc+FYWmhP/ERhmHqu03tGf9ERUbo5J8h/7GYuzjyOf6OHAGOb9qWjVFgpcA23PfVFMtd3/B79ep0mBvnhWdcKHLcj4RDtMZlL+eHl6/f+cJQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eeE+vSrpHILBVY0kp6SgCtbK4avE+ue/ENXreDo3ZEBX9BGGoBuvndk/Luhr4SUlYb1arDp9T9Zr+RvbdD2pAIgwDWtDvgml7kAsDy2Cv6rk9r7tkLkT8fsvgDCGrtNvwPp4iZtq6BvIGl/TG2U8aghs1vxULbe91ErFH4j1Frwe6MKOV3pf6KnVS6GpW8RkVlv84yXp7lW+LFZVjhrsAMbapA2Dyqod3MflqQsXgsbO48tuafM4PJUWqGubtpEtUBpYev5cuARHL8pS3hUaUE0GewCIp0YpIqWQ1UuzDR6Ag473aIeIcmfuFxGV+YaIrHJEgzCS/jXmnnMJkhWUwQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Mon, 12 Dec 2022 15:19:26 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 09.12.2022 01:52, Demi Marie Obenour wrote:
> This was missed in the initial patchset.
>
> Signed-off-by: Demi Marie Obenour <demi@xxxxxxxxxxxxxxxxxxxxxx>
It looks as if, besides ...
> --- a/xen/arch/x86/efi/efi-boot.h
> +++ b/xen/arch/x86/efi/efi-boot.h
> @@ -818,6 +818,8 @@ void __init efi_multiboot2(EFI_HANDLE ImageHandle,
> EFI_SYSTEM_TABLE *SystemTable
> if ( gop )
> efi_set_gop_mode(gop, gop_mode);
>
> + efi_relocate_esrt(SystemTable);
> +
> efi_exit_boot(ImageHandle, SystemTable);
> }
>
... this core piece, the rest is merely pure code movement, with the goal
of avoiding a forward declaration. If such is the case, please say so in
your description. I'll add a sentence to this effect when committing, so
the remark if for future patches. Provided of course it is true (i.e. I'm
not overlooking any tiny change) - please confirm.
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
Jan
|
