[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 02/18] xen/arm64: flushtlb: Implement the TLBI repeat workaround for TLB flush by VA
- To: Julien Grall <julien@xxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Michal Orzel <michal.orzel@xxxxxxx>
- Date: Tue, 13 Dec 2022 10:23:21 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=xen.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=G8Ok8/F4ZfkpY+SoWaLL0+xyQKIus7BpNIU7NP/+sP8=; b=nm7oTkYsouF+akGwlPVg8QFZOh5+Eb0Ut/Jz2pFrijoJdfAdkWSsh6P8AdRemV3k5UnshN6uZ8jN0lKZ4sZpO55sluTnE20Mr4lsqfxXS56i9VOpJUh71GD/gr45420Z/ymLOnH3xT7XVIbmhPAqP9H+ylmbQjTXRwiYaRTTTHK/y3lYdt4efssJdEcUk7Xzg49m0nFh85uO72buIXjG4RHtJ0l/OOjpiFOW2UQlYlOXgIo0Kq1PSEd65/dT/YFCAE5VPzRHlIJINHiVWMRlhAReOANesPZOG4rtdOGU3vjShtbsdlTlfz0fOHZ0vpVBM+Pgd61EkoCv35Zl0iVnDg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WzBnqb7XrD/Qf6MKIjJ7PgMYaOklaLIMOgUMXsiKKhMKzmpVMg9yJH4nudZApuCNHKjKIxkGf2vyrO4yQJNKGry4cJjSudqbkPNS1vtn6yzIzXurhBqQ+ZuqPBbWgIhw244LIAA2TFWiI7omNzL8MmvoPFZWhWn9ZrD+fsG7SoibkU5gh1SbxSpSwZ2cP6GOKkmh/sI5nVabgZe4tBlRSf/J9IKLaK0gnUDRKMB/VK5XEBdvLuDP1r59FssPmTYbIO1ybXS1Y7bdgr5EUdH4NyBo6Wk5CrU7XYJnq6TXgfTj/0V6n9t5FaIOfWDyFQIbTaUCQ2VYSefCHWftBhJ3gQ==
- Cc: <Luca.Fancellu@xxxxxxx>, Julien Grall <jgrall@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Tue, 13 Dec 2022 09:23:34 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
Hi Julien,
On 12/12/2022 10:55, Julien Grall wrote:
>
>
> From: Julien Grall <jgrall@xxxxxxxxxx>
>
> Looking at the Neoverse N1 errata document, it is not clear to me
> why the TLBI repeat workaround is not applied for TLB flush by VA.
>
> The TBL flush by VA helpers are used in flush_xen_tlb_range_va_local()
> and flush_xen_tlb_range_va(). So if the range size if a fixed size smaller
> than a PAGE_SIZE, it would be possible that the compiler remove the loop
> and therefore replicate the sequence described in the erratum 1286807.
>
> So the TLBI repeat workaround should also be applied for the TLB flush
> by VA helpers.
>
> Fixes: 22e323d115d8 ("xen/arm: Add workaround for Cortex-A76/Neoverse-N1
> erratum #1286807")
> Signed-off-by: Julien Grall <jgrall@xxxxxxxxxx>
Reviewed-by: Michal Orzel <michal.orzel@xxxxxxx>
~Michal
|
