[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 4/5] multiboot2: parse console= option when setting GOP mode
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Daniel Kiper <daniel.kiper@xxxxxxxxxx>
- Date: Tue, 13 Dec 2022 12:41:22 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+uLSL5o0yzU34w/gGEHsG5WDd52rKFwHfr9/R3xuo4o=; b=QitmXza7EJC8V24ZmvxIL0a+wT0m6/LkBf+8rfhPKWSKCc8gNCr9cIr7E05BGr20Eu6pKH2Krw0Rsz/8Bjuklw5TSPskqjjOXPDW0otvZlXGQh4pqojgJaFSqwAHJQRcYVDXhtOy/BoDRriSztLAo66eBUxBIL88IVr2UPmgcuuxnEi957fMVLA2WG2qkxUgrpWOQASKaI9Mo9/mwHeA9ewAEZFrCtS+X22W/glOKjlmBFnSmXrV+8vuH2TbqWykey1kaokB5DYYlzO6guE2tZ3Ju6dl6mIgMou0giY6F3/Kivac6lRxAscSWmCtWZ8oFX9AaV+j7gSKo6Y0tA5czg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Sj1373DqWI6gKFAK4M/Fv1QJiyU1Y8QddQD4jNu9Z9ehxW6uSLi8AMa8Ri2Cxq01zHjqM1imO6qFXHhj9JBE354tJN5tI1lQrsF45tq9xFgOpqneMUhLHMgj6CWKgkgdBC3aqcPz9+aVuf69dgff4flM6GyN2ShOZkb1+VrJ6GrFucZoA++PLHZTjgk6UpVAqx/flyJHf9cIgvlmYb8DgqsneS4VEwoP0cSFkjTvPQK1IFEwLBoYuznrq3DG1bh0ggvADjD4A2DXw1mKATUXPBZos1ao9dPpYOb/z6IPUxlvNro6wSOwotXVVC4w8bJkQZQW02Dl/ACrq7lvonnXWw==
- Cc: Roger Pau Monne <roger.pau@xxxxxxxxxx>, marmarek@xxxxxxxxxxxxxxxxxxxxxx, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Tue, 13 Dec 2022 11:41:47 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
Sorry for late reply...
On Mon, Dec 05, 2022 at 04:10:28PM +0100, Jan Beulich wrote:
> On 23.11.2022 16:45, Roger Pau Monne wrote:
> > Only set the GOP mode if vga is selected in the console option,
> > otherwise just fetch the information from the current mode in order to
> > make it available to dom0.
> >
> > Introduce support for passing the command line to the efi_multiboot2()
> > helper, and parse the console= option if present.
> >
> > Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
> > ---
> > I'm unsure why the parsing of the multiboot2 tags is done in assembly,
> > it could very well be done in efi_multiboot2() in C, but I don't want
> > to switch that code now.
>
> I guess that's mainly mirroring the non-EFI boot path, where the amount
> of work needed to eventually enter C land is quite a bit larger?
> Anything beyond that Daniel may want to point out.
Yeah, you are right, its mainly mirroring the non-EFI boot path and it
evolved from that code. However, if you want to move it to C go for it...
Daniel
|
