[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 2/3] x86/vmx: introduce helper to set VMX_INTR_SHADOW_NMI
- To: "Tian, Kevin" <kevin.tian@xxxxxxxxx>
- From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Date: Tue, 13 Dec 2022 15:42:24 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wi1FT+R79LLj6/DKLBVwhCjfsJ2N7DoGX0am970KiKw=; b=ieHRbFkSTyb4JINmdgMud7/nCmaQ5TphDxcjB1l/TqGCW8zTaYrqGgjQzu7uJE/XKCnFYkP4xNLvAb49KHBJx1JZmQ3EDUadKGHvWbrRmNNzDOwoTXPsEwpzcKd/t0eyC5pNRjylni2NsAughArDOUa+lnv3PKA4s5Dc3vqocN/9CoPmzzqJmIPiL11mzWuBkD2GK7MD44SwEf8NfVmdOvCqz6iDx2yoWKWSjAzu5DvT0pFyqyNKKNulXLn7lwdudZaPCSWjlfQYafCCrDckjkkmNF8YFI9Dsnue5xrEAWW8EfHk1D3GaAoYnZK5Fnkw0BAUsyNtd32IvfKDTKuGYg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WBATAZk8xyBn1zeocQdq+GMZpnSMDM3hsBZBTPV+uohPSUY52kLPkTsfF26YHOeqcrXurELeAav+wSuhbu7YB5y7ZaD9VBwx69Q4f6WHOfHlY7qfm41/JIx8JHevD5RNOUW25PrSEyQTCGxt7vnTpeSV4B3kLoQgmJzZov+UedsFUyB5qtHG+sZDIJzSzJe2frAFQuATSOHcU6qQtRI51P3RhyjQD/c+JA/WavudhuFYNdglQLdhLwAx0CCixlWidbjPmzHwX1w3wB/jy+q1xu+ucz7ylssa7e3L6rCwhK1mTzYhpcCkLm2w7bXpulc5czmW6s/vJTD52llpjfa18A==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "Nakajima, Jun" <jun.nakajima@xxxxxxxxx>, "Beulich, Jan" <JBeulich@xxxxxxxx>, "Cooper, Andrew" <andrew.cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
- Delivery-date: Tue, 13 Dec 2022 14:42:55 +0000
- Ironport-data: A9a23:/7DNV6m/anrjVYsyTEwtL/fo5gxLJ0RdPkR7XQ2eYbSJt1+Wr1Gzt xJNUW+BPa7YNmCjcot/bYzi9h5Sv8DSytM3SQttqi5kEyMWpZLJC+rCIxarNUt+DCFhoGFPt JxCN4aafKjYaleG+39B55C49SEUOZmgH+a6U6icf3grHmeIcQ954Tp7gek1n4V0ttawBgKJq LvartbWfVSowFaYCEpNg064gE4p7aqaVA8w5ARkP6kR5QSGzRH5MbpETU2PByqgKmVrNrbSq 9brlNmR4m7f9hExPdKp+p6TnpoiG+O60aCm0xK6aoD66vRwjnVaPpUTbZLwXXx/mTSR9+2d/ f0W3XCGpaXFCYWX8AgVe0Ew/yiTpsSq8pefSZS0mZT7I0Er7xIAahihZa07FdRwxwp5PY1B3 flbCT81UyibvsOZ/o7mQcZjj894M8a+aevzulk4pd3YJdAPZMifBonvu5pf1jp2gd1SF/HDY cZfcSBocBnLfxxIPBEQFY46m+CrwHL4dlW0qnrM/fZxvzeVk1c3jOSF3Nn9I7RmQe1PmUmVv CTe9nnRCRAGLt2PjzGC9xpAg8eexX2hBNJPRNVU8NZJuBqq1GM5EidRD1uyhdLmmEHvRP52f hl8Fi0G6PJaGFaQZtrwQRy+5mKFtxg0WtxMHul84waIooLE7gDcCmUaQzppbN09qNRwVTEsz kWOnd7iGXpoqrL9YXCA8PGSpDC7OykQJEcDYzMJSU0O5NyLiKMZgw/LT91jOLWoldCzEjb1q xiVqAAuirNVitQEv5hX5njCijOo45TMEAg8412LWnr/tl8lIom4e4av9F7Xq+5aK5qURUWAu 35CnNWC6OcJDteGkynlrPgxIYxFLs2taFX06WOD1bF4n9hx0xZPpbxt3Qw=
- Ironport-hdrordr: A9a23:MqWWP6jrAZ/rT2m66ljrFXeDP3BQXhIji2hC6mlwRA09TyX4rb HSoB1/73TJYVkqNk3I9ersBEDCexPhHOdOkO8s1O6ZLXDbUQiTTb2Kj7GSuQEIcheWnoRgPM FbAtND4bbLYmSS4/yX3OD2KadC/PC3tI2lgOfAw2x8JDsaDp2JiG9Ce36m++BNNW177N4CZf 2hz9sCoza7Y3wYYua2FhA+Lor+m+E=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Tue, Jul 19, 2022 at 07:33:47AM +0000, Tian, Kevin wrote:
> > From: Roger Pau Monne <roger.pau@xxxxxxxxxx>
> > Sent: Friday, July 1, 2022 9:17 PM
> >
> > @@ -225,6 +225,9 @@ static inline void pi_clear_sn(struct pi_desc *pi_desc)
> >
> > /*
> > * Interruption-information format
> > + *
> > + * Note INTR_INFO_NMI_UNBLOCKED_BY_IRET is also used with Exit
> > Qualification
> > + * field under some circumstances.
> > */
> > #define INTR_INFO_VECTOR_MASK 0xff /* 7:0 */
> > #define INTR_INFO_INTR_TYPE_MASK 0x700 /* 10:8 */
>
> Overall this is good. But I wonder whether the readability is slightly better
> by defining a dedicate flag bit for exit qualification with a clear comment
> on which events it makes sense to...
I've expanded the comment to:
"Note INTR_INFO_NMI_UNBLOCKED_BY_IRET is also used with Exit Qualification
field for EPT violations, PML full and SPP-related event vmexits."
I leave the creation of the specific flag to a separate commit, to not
block the series on that.
Thanks, Roger.
|
