[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH V10 0/3] toolstack support for generic virtio devices on Arm
- To: Viresh Kumar <viresh.kumar@xxxxxxxxxx>, Oleksandr Tyshchenko <olekstysh@xxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Wed, 14 Dec 2022 10:09:21 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IS4SLI/aYBwcqNtkEeoDT6szLWznrVlJ2qNED8YZLhY=; b=QKoDybMBdwFHU5DMwwUE0HoYJuVcAz3NU7QHQgl0jzdgc9ZEcO/1Qj6+5rWiGPUbWE8hRLfFP9dfkNGTsIwt+sQu6mJyMUYcZyg7ut0Tee79kUoEXMNGmB3KYN5V4Yj0JcTjLseNZn/HdJ7IBmu/jJ3U6lN/U2FJCnUIyPkoo/7Ac1EC3NP/4pGFkjhulXj+xU/iTc/Shly4nprqbe6m5Ou2QQvnElj730USMppv9MJ6ZLNJD4CpqlRtzmLayLeQIqzyxkEuCfhdgxbYpXEAPMe6F8KZJdiq4hVimAN3UgKoYYbjA9fJtf7LR7oWXfdmJHhXQ0Z0N3yX3n5fwR6s/w==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Y38XZjczS4W/ks7xVsjr3tcUZGdBJ/PxpLoecZ0oYTDQ5y1oPa3mYd5BGO/OeT2f4xoSkdkVgZipixWErXBUPAivgEZHhHncUSqGIWK4VdcyYFcAzwxp/yS+S0aEl5qcb3t7J0oZ1GJeYti162srHCeUva7WDsOcCktYQS6GkHx1Fy2JhRWyQbd3zt6w6FU5PvSoRYa8OAx4UuCUhz3PdhccfA50ZoJ/aGa9WuG1DR5+wRFvGVLKD47Ly5Xr468w8ytoBpLnXrjsiGReR0d4em9c0lAtfqxL0GBRy+TJocUlRqb0HAZB3RblM139szCdw2rkyNQypJ5jCpe/fhlz4w==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Vincent Guittot <vincent.guittot@xxxxxxxxxx>, stratos-dev@xxxxxxxxxxxxxxxxxxx, Alex Bennée <alex.bennee@xxxxxxxxxx>, Stefano Stabellini <stefano.stabellini@xxxxxxxxxx>, Mathieu Poirier <mathieu.poirier@xxxxxxxxxx>, Mike Holmes <mike.holmes@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxx, Juergen Gross <jgross@xxxxxxxx>, Julien Grall <julien@xxxxxxx>
- Delivery-date: Wed, 14 Dec 2022 09:09:32 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 14.12.2022 09:34, Viresh Kumar wrote:
> On 14-12-22, 09:21, Jan Beulich wrote:
>> On 14.12.2022 06:19, Viresh Kumar wrote:
>>> This patchset adds toolstack support for I2C, GPIO and generic virtio
>>> devices.
>>> This is inspired from the work done by Oleksandr for the Disk device.
>>>
>>> This is developed as part of Linaro's Project Stratos, where we are working
>>> towards Hypervisor agnostic Rust based backends [1].
>>>
>>> This is based of Xen's master branch.
>>>
>>> V9->V10:
>>> - Swap I2C/GPIO compatible strings, they were wrongly added earlier.
>>> - Arrange tags in timely order and add new ones.
>>
>> The affected patch surely needed all tags to be dropped which weren't
>> explicitly indicated to remain valid across the bug fix.
>
> Hmm, since it was a very small change (only fixed the compatible
> strings) I thought it would be okay to carry the tags and rather harsh
> to the reviewers to drop them, since they invested a lot of time
> reviewing these. Though I do get what you are suggesting here.
>
> Should I ask Oleksandr / Anthony to provide their tags for patch 1/3
> again ?
Let's simply wait for them to confirm their tags.
Jan
|